[INFO] fetching crate radix_trie 0.2.1... [INFO] checking radix_trie-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate radix_trie 0.2.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate radix_trie 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate radix_trie 0.2.1 [INFO] finished tweaking crates.io crate radix_trie 0.2.1 [INFO] tweaked toml for crates.io crate radix_trie 0.2.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate radix_trie 0.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c5c1441bbf47092b925c63ecfe7d2263b78db3569267d1ca61457dd9343eedfc [INFO] running `Command { std: "docker" "start" "-a" "c5c1441bbf47092b925c63ecfe7d2263b78db3569267d1ca61457dd9343eedfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c5c1441bbf47092b925c63ecfe7d2263b78db3569267d1ca61457dd9343eedfc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c5c1441bbf47092b925c63ecfe7d2263b78db3569267d1ca61457dd9343eedfc", kill_on_drop: false }` [INFO] [stdout] c5c1441bbf47092b925c63ecfe7d2263b78db3569267d1ca61457dd9343eedfc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a8b743f4b491dd3e16e64cbc74f820202f7bcb47a938b14b0257f2a4b647f35d [INFO] running `Command { std: "docker" "start" "-a" "a8b743f4b491dd3e16e64cbc74f820202f7bcb47a938b14b0257f2a4b647f35d", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling libc v0.2.79 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling const_fn v0.4.2 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Compiling syn v1.0.46 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking regex-syntax v0.3.9 [INFO] [stderr] Checking utf8-ranges v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.0 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex-syntax v0.6.20 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking oorandom v11.1.2 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking memchr v0.1.11 [INFO] [stderr] Checking thread-id v2.0.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking thread_local v0.2.7 [INFO] [stderr] Checking aho-corasick v0.5.3 [INFO] [stderr] Checking radix_trie v0.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iter.rs:107:21 [INFO] [stdout] | [INFO] [stdout] 107 | prefix: self.prefix.clone().join(&node.key), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie.rs:99:18 [INFO] [stdout] | [INFO] [stdout] 96 | let key_fragments = key.encode(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | .map(|node| node.as_subtrie(key_fragments)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie.rs:116:18 [INFO] [stdout] | [INFO] [stdout] 112 | let key_fragments = key.encode(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | .map(move |node| node.as_subtrie_mut(key_fragments, length_ref)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie.rs:138:18 [INFO] [stdout] | [INFO] [stdout] 135 | let mut key_fragments = key.encode(); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | .map(|(node, node_key_len)| { [INFO] [stdout] | __________________^ [INFO] [stdout] 139 | | key_fragments.split(node_key_len); [INFO] [stdout] 140 | | node.as_subtrie(key_fragments) [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie.rs:186:47 [INFO] [stdout] | [INFO] [stdout] 185 | let mut nv = key.encode(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | self.node.get_raw_descendant(&nv).map(|desc| { [INFO] [stdout] | _______________________________________________^ [INFO] [stdout] 187 | | let (node, prefix) = match desc { [INFO] [stdout] 188 | | NoModification(node) => (node, nv), [INFO] [stdout] 189 | | ExtendKey(node, depth, extension) => { [INFO] [stdout] ... | [INFO] [stdout] 194 | | node.as_subtrie(prefix) [INFO] [stdout] 195 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_common.rs:64:10 [INFO] [stdout] | [INFO] [stdout] 63 | fn prefix(self) -> &'a Nibblet { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | &self.trie_node().key [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_common.rs:148:23 [INFO] [stdout] | [INFO] [stdout] 147 | fn children(self) -> Children<'a, K, V> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 148 | Children::new(self.prefix.clone(), self.node) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_node.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn with_key_value(key_fragments: Nibblet, key: K, value: V) -> TrieNode { [INFO] [stdout] | ---------------------- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | key_value: Some(Box::new(KeyValue { [INFO] [stdout] | ________________________^ [INFO] [stdout] 52 | | key: key, [INFO] [stdout] 53 | | value: value, [INFO] [stdout] 54 | | })), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trie_node.rs:55:23 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn with_key_value(key_fragments: Nibblet, key: K, value: V) -> TrieNode { [INFO] [stdout] | ---------------------- ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | children: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `radix_trie` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "a8b743f4b491dd3e16e64cbc74f820202f7bcb47a938b14b0257f2a4b647f35d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a8b743f4b491dd3e16e64cbc74f820202f7bcb47a938b14b0257f2a4b647f35d", kill_on_drop: false }` [INFO] [stdout] a8b743f4b491dd3e16e64cbc74f820202f7bcb47a938b14b0257f2a4b647f35d