[INFO] fetching crate radix-substate-store-impls 1.2.0... [INFO] checking radix-substate-store-impls-1.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate radix-substate-store-impls 1.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate radix-substate-store-impls 1.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate radix-substate-store-impls 1.2.0 [INFO] finished tweaking crates.io crate radix-substate-store-impls 1.2.0 [INFO] tweaked toml for crates.io crate radix-substate-store-impls 1.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 122 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.9.1 (latest: v0.11.0) [INFO] [stderr] Adding bindgen v0.65.1 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding block-buffer v0.9.0 (latest: v0.10.4) [INFO] [stderr] Adding curve25519-dalek v3.2.1 (latest: v4.1.3) [INFO] [stderr] Adding digest v0.9.0 (latest: v0.10.7) [INFO] [stderr] Adding ed25519 v1.5.3 (latest: v2.2.3) [INFO] [stderr] Adding ed25519-dalek v1.0.1 (latest: v2.1.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding getrandom v0.1.16 (latest: v0.2.15) [INFO] [stderr] Adding hashbrown v0.13.2 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding librocksdb-sys v0.11.0+8.1.1 (latest: v6.20.3) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding peeking_take_while v0.1.2 (latest: v1.0.0) [INFO] [stderr] Adding rand v0.7.3 (latest: v0.8.5) [INFO] [stderr] Adding rand_chacha v0.2.2 (latest: v0.3.1) [INFO] [stderr] Adding rand_core v0.5.1 (latest: v0.6.4) [INFO] [stderr] Adding rand_hc v0.2.0 (latest: v0.3.2) [INFO] [stderr] Adding rocksdb v0.21.0 (latest: v0.22.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding secp256k1 v0.28.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (latest: v0.10.0) [INFO] [stderr] Adding sha2 v0.9.9 (latest: v0.10.8) [INFO] [stderr] Adding signature v1.6.4 (latest: v2.2.0) [INFO] [stderr] Adding strum v0.24.1 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.24.3 (latest: v0.26.4) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding wasi v0.9.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zeroize v1.3.0 (latest: v1.8.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c6fa5f6d300708f4d26268a0022b2d840d68becfc27e7b969500eacff6ae4ad3 [INFO] running `Command { std: "docker" "start" "-a" "c6fa5f6d300708f4d26268a0022b2d840d68becfc27e7b969500eacff6ae4ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c6fa5f6d300708f4d26268a0022b2d840d68becfc27e7b969500eacff6ae4ad3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6fa5f6d300708f4d26268a0022b2d840d68becfc27e7b969500eacff6ae4ad3", kill_on_drop: false }` [INFO] [stdout] c6fa5f6d300708f4d26268a0022b2d840d68becfc27e7b969500eacff6ae4ad3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e13fcac1524b625ff96125480043faf881ba53aa5a6607a706a45505d4e56713 [INFO] running `Command { std: "docker" "start" "-a" "e13fcac1524b625ff96125480043faf881ba53aa5a6607a706a45505d4e56713", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling getrandom v0.1.16 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Compiling const-sha1 v0.3.0 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Compiling blst v0.3.13 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signature v1.6.4 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking threadpool v1.8.1 [INFO] [stderr] Checking ed25519 v1.5.3 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking sha2 v0.9.9 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking radix-rust v1.2.0 [INFO] [stderr] Checking bnum v0.11.0 [INFO] [stderr] Checking bech32 v0.9.1 [INFO] [stderr] Compiling sbor-derive-common v1.2.0 [INFO] [stderr] Compiling strum_macros v0.24.3 [INFO] [stderr] Compiling sbor-derive v1.2.0 [INFO] [stderr] Compiling radix-sbor-derive v1.2.0 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Checking sbor v1.2.0 [INFO] [stderr] Checking zeroize v1.3.0 [INFO] [stderr] Checking curve25519-dalek v3.2.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking strum v0.24.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking ed25519-dalek v1.0.1 [INFO] [stderr] Checking radix-common v1.2.0 [INFO] [stderr] Checking radix-substate-store-interface v1.2.0 [INFO] [stderr] Checking radix-substate-store-impls v1.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `fuzzing` [INFO] [stdout] --> src/state_tree/types.rs:1172:21 [INFO] [stdout] | [INFO] [stdout] 1172 | #[cfg(any(test, feature = "fuzzing"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, `rocksdb`, and `std` [INFO] [stdout] = help: consider adding `fuzzing` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `fuzzing` [INFO] [stdout] --> src/state_tree/types.rs:1172:21 [INFO] [stdout] | [INFO] [stdout] 1172 | #[cfg(any(test, feature = "fuzzing"))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `alloc`, `default`, `rocksdb`, and `std` [INFO] [stdout] = help: consider adding `fuzzing` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/entity_tier.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | let partition_tier_mapper = self.create_partition_tier_mapper(); // we soon lose `self` [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | iter_leaves_from(Rc::new(self), from).map(partition_tier_mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/partition_tier.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | let substate_tier_mapper = self.create_substate_tier_mapper(); // we soon lose `self` [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | iter_leaves_from(Rc::new(self), from.as_ref()).map(substate_tier_mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/substate_tier.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 119 | let summary_mapper = self.create_summary_mapper(); // we soon lose `self` [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | iter_leaves_from(Rc::new(self), from).map(summary_mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/tier_framework.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 93 | tier: impl Deref + Clone + 't, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / tier.root_version() [INFO] [stdout] 101 | | .map(|version| { [INFO] [stdout] 102 | | recurse_until_leaves( [INFO] [stdout] 103 | | tier, [INFO] [stdout] ... | [INFO] [stdout] 108 | | ) [INFO] [stdout] 109 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/tier_framework.rs:154:46 [INFO] [stdout] | [INFO] [stdout] 127 | tier: impl Deref + Clone + 't, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | recurse_until_leaves(tier.clone(), child_key, child_from_nibbles) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/jellyfish.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 165 | value_set: BTreeMap>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let mut batch = TreeUpdateBatch::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let root_node_opt = if let Some(persisted_version) = persisted_version { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let root_hash = if let Some(root_node) = root_node_opt { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok((root_hash, batch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/jellyfish.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 319 | let new_child_node_option = match child { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | Ok((child_index, new_child_node_option)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/jellyfish.rs:715:33 [INFO] [stdout] | [INFO] [stdout] 711 | pub fn put_node(&mut self, node_key: TreeNodeKey, node: Node

) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 715 | self.node_batch[0].push((node_key, node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/types.rs:1179:20 [INFO] [stdout] | [INFO] [stdout] 1178 | pub fn new_leaf(leaf_key: LeafKey, value_hash: Hash, payload: P, version: Version) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1179 | Node::Leaf(LeafNode::new(leaf_key, value_hash, payload, version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn deconstruct(self) -> (S, DatabaseUpdates) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (self.root, self.overlay.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:269:18 [INFO] [stdout] | [INFO] [stdout] 264 | let underlying = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | Box::new(OverlayingIterator::new(underlying, overlying).map(|(value, _)| value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:385:43 [INFO] [stdout] | [INFO] [stdout] 385 | .map(|(key, value)| (key, NodeDatabaseUpdates::from(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:394:27 [INFO] [stdout] | [INFO] [stdout] 392 | fn from(value: DatabaseUpdates) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | Self { [INFO] [stdout] 394 | node_updates: value [INFO] [stdout] | ___________________________^ [INFO] [stdout] 395 | | .node_updates [INFO] [stdout] 396 | | .into_iter() [INFO] [stdout] 397 | | .map(|(key, value)| (key, StagingNodeDatabaseUpdates::from(value))) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:414:43 [INFO] [stdout] | [INFO] [stdout] 414 | .map(|(key, value)| (key, PartitionDatabaseUpdates::from(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:423:32 [INFO] [stdout] | [INFO] [stdout] 421 | fn from(value: NodeDatabaseUpdates) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | Self { [INFO] [stdout] 423 | partition_updates: value [INFO] [stdout] | ________________________________^ [INFO] [stdout] 424 | | .partition_updates [INFO] [stdout] 425 | | .into_iter() [INFO] [stdout] 426 | | .map(|(key, value)| (key, StagingPartitionDatabaseUpdates::from(value))) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `radix-substate-store-impls` (lib) due to 16 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/entity_tier.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 47 | let partition_tier_mapper = self.create_partition_tier_mapper(); // we soon lose `self` [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | iter_leaves_from(Rc::new(self), from).map(partition_tier_mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/partition_tier.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 77 | let substate_tier_mapper = self.create_substate_tier_mapper(); // we soon lose `self` [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 78 | iter_leaves_from(Rc::new(self), from.as_ref()).map(substate_tier_mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/substate_tier.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 119 | let summary_mapper = self.create_summary_mapper(); // we soon lose `self` [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | iter_leaves_from(Rc::new(self), from).map(summary_mapper) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/tier_framework.rs:100:5 [INFO] [stdout] | [INFO] [stdout] 93 | tier: impl Deref + Clone + 't, [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | / tier.root_version() [INFO] [stdout] 101 | | .map(|version| { [INFO] [stdout] 102 | | recurse_until_leaves( [INFO] [stdout] 103 | | tier, [INFO] [stdout] ... | [INFO] [stdout] 108 | | ) [INFO] [stdout] 109 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/tier_framework.rs:154:46 [INFO] [stdout] | [INFO] [stdout] 127 | tier: impl Deref + Clone + 't, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | recurse_until_leaves(tier.clone(), child_key, child_from_nibbles) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/jellyfish.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 165 | value_set: BTreeMap>, [INFO] [stdout] | ----------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | let mut batch = TreeUpdateBatch::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | let root_node_opt = if let Some(persisted_version) = persisted_version { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let root_hash = if let Some(root_node) = root_node_opt { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | Ok((root_hash, batch)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/jellyfish.rs:338:12 [INFO] [stdout] | [INFO] [stdout] 319 | let new_child_node_option = match child { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 338 | Ok((child_index, new_child_node_option)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/jellyfish.rs:715:33 [INFO] [stdout] | [INFO] [stdout] 711 | pub fn put_node(&mut self, node_key: TreeNodeKey, node: Node

) { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 715 | self.node_batch[0].push((node_key, node)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/test.rs:943:38 [INFO] [stdout] | [INFO] [stdout] 941 | changes: impl IntoIterator, [INFO] [stdout] | ------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 942 | ) -> Option { [INFO] [stdout] 943 | self.apply_database_updates(&DatabaseUpdates::from_delta_maps( [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 944 | | Self::index_to_delta_maps(changes), [INFO] [stdout] 945 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/test.rs:954:38 [INFO] [stdout] | [INFO] [stdout] 952 | values: impl IntoIterator, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 953 | ) -> Option { [INFO] [stdout] 954 | self.apply_database_updates(&DatabaseUpdates { [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 955 | | node_updates: indexmap!( [INFO] [stdout] 956 | | node_key => NodeDatabaseUpdates { [INFO] [stdout] 957 | | partition_updates: indexmap!( [INFO] [stdout] ... | [INFO] [stdout] 963 | | ), [INFO] [stdout] 964 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/test.rs:1016:9 [INFO] [stdout] | [INFO] [stdout] 1000 | let stale_node_keys = binding [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1016 | / self.tree_store [INFO] [stdout] 1017 | | .tree_nodes [INFO] [stdout] 1018 | | .borrow() [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/state_tree/types.rs:1179:20 [INFO] [stdout] | [INFO] [stdout] 1178 | pub fn new_leaf(leaf_key: LeafKey, value_hash: Hash, payload: P, version: Version) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1179 | Node::Leaf(LeafNode::new(leaf_key, value_hash, payload, version)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:51:21 [INFO] [stdout] | [INFO] [stdout] 50 | pub fn deconstruct(self) -> (S, DatabaseUpdates) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | (self.root, self.overlay.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:269:18 [INFO] [stdout] | [INFO] [stdout] 264 | let underlying = self [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 269 | Box::new(OverlayingIterator::new(underlying, overlying).map(|(value, _)| value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:385:43 [INFO] [stdout] | [INFO] [stdout] 385 | .map(|(key, value)| (key, NodeDatabaseUpdates::from(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:394:27 [INFO] [stdout] | [INFO] [stdout] 392 | fn from(value: DatabaseUpdates) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 393 | Self { [INFO] [stdout] 394 | node_updates: value [INFO] [stdout] | ___________________________^ [INFO] [stdout] 395 | | .node_updates [INFO] [stdout] 396 | | .into_iter() [INFO] [stdout] 397 | | .map(|(key, value)| (key, StagingNodeDatabaseUpdates::from(value))) [INFO] [stdout] | |___________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:414:43 [INFO] [stdout] | [INFO] [stdout] 414 | .map(|(key, value)| (key, PartitionDatabaseUpdates::from(value))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/substate_database_overlay.rs:423:32 [INFO] [stdout] | [INFO] [stdout] 421 | fn from(value: NodeDatabaseUpdates) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 422 | Self { [INFO] [stdout] 423 | partition_updates: value [INFO] [stdout] | ________________________________^ [INFO] [stdout] 424 | | .partition_updates [INFO] [stdout] 425 | | .into_iter() [INFO] [stdout] 426 | | .map(|(key, value)| (key, StagingPartitionDatabaseUpdates::from(value))) [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `radix-substate-store-impls` (lib test) due to 19 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "e13fcac1524b625ff96125480043faf881ba53aa5a6607a706a45505d4e56713", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e13fcac1524b625ff96125480043faf881ba53aa5a6607a706a45505d4e56713", kill_on_drop: false }` [INFO] [stdout] e13fcac1524b625ff96125480043faf881ba53aa5a6607a706a45505d4e56713