[INFO] fetching crate radicle-source 0.4.0... [INFO] checking radicle-source-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate radicle-source 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate radicle-source 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate radicle-source 0.4.0 [INFO] finished tweaking crates.io crate radicle-source 0.4.0 [INFO] tweaked toml for crates.io crate radicle-source 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 103 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding bitvec v0.19.6 (latest: v1.0.1) [INFO] [stderr] Adding funty v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding lexical-core v0.7.6 (latest: v0.8.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding nom v6.1.2 (latest: v7.1.3) [INFO] [stderr] Adding nonempty v0.5.0 (latest: v0.10.0) [INFO] [stderr] Adding nonempty v0.6.0 (latest: v0.10.0) [INFO] [stderr] Adding quick-xml v0.32.0 (latest: v0.36.1) [INFO] [stderr] Adding radicle-surf v0.8.0 (latest: v0.22.0) [INFO] [stderr] Adding radium v0.5.3 (latest: v1.1.0) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding syntect v4.6.0 (latest: v5.2.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding wyz v0.2.0 (latest: v0.6.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 52cad7896f9bcd5ffb4ca20435018d2b0283b527fa393b1e8290eaeaa19356d7 [INFO] running `Command { std: "docker" "start" "-a" "52cad7896f9bcd5ffb4ca20435018d2b0283b527fa393b1e8290eaeaa19356d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "52cad7896f9bcd5ffb4ca20435018d2b0283b527fa393b1e8290eaeaa19356d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "52cad7896f9bcd5ffb4ca20435018d2b0283b527fa393b1e8290eaeaa19356d7", kill_on_drop: false }` [INFO] [stdout] 52cad7896f9bcd5ffb4ca20435018d2b0283b527fa393b1e8290eaeaa19356d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9363db435dd629c1852eb894db3f39ef63cf50e5ce818aa98d5a7d68e92977d0 [INFO] running `Command { std: "docker" "start" "-a" "9363db435dd629c1852eb894db3f39ef63cf50e5ce818aa98d5a7d68e92977d0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling adler2 v2.0.0 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling radium v0.5.3 [INFO] [stderr] Compiling miniz_oxide v0.8.0 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling lexical-core v0.7.6 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Checking funty v1.1.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking wyz v0.2.0 [INFO] [stderr] Compiling flate2 v1.0.33 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking nonempty v0.5.0 [INFO] [stderr] Checking nonempty v0.6.0 [INFO] [stderr] Checking bitvec v0.19.6 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling filetime v0.2.25 [INFO] [stderr] Compiling cc v1.1.15 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Compiling tar v0.4.41 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Compiling libz-sys v1.1.20 [INFO] [stderr] Compiling libgit2-sys v0.17.0+1.8.1 [INFO] [stderr] Compiling radicle-surf v0.8.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking git2 v0.19.0 [INFO] [stderr] Checking radicle-source v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revision.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 110 | peer_id: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | user: U, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | / NonEmpty::from_vec(remote_branches).map(|branches| Revisions { [INFO] [stdout] 119 | | peer_id, [INFO] [stdout] 120 | | user, [INFO] [stdout] 121 | | branches, [INFO] [stdout] ... | [INFO] [stdout] 124 | | tags: vec![], [INFO] [stdout] 125 | | }), [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revision.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn local(browser: &Browser, peer_id: P, user: U) -> Result>, Error> [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | / NonEmpty::from_vec(local_branches).map(|branches| Revisions { [INFO] [stdout] 145 | | peer_id, [INFO] [stdout] 146 | | user, [INFO] [stdout] 147 | | branches, [INFO] [stdout] 148 | | tags, [INFO] [stdout] 149 | | }), [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revision.rs:118:9 [INFO] [stdout] | [INFO] [stdout] 110 | peer_id: P, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 111 | user: U, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | / NonEmpty::from_vec(remote_branches).map(|branches| Revisions { [INFO] [stdout] 119 | | peer_id, [INFO] [stdout] 120 | | user, [INFO] [stdout] 121 | | branches, [INFO] [stdout] ... | [INFO] [stdout] 124 | | tags: vec![], [INFO] [stdout] 125 | | }), [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/revision.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 137 | pub fn local(browser: &Browser, peer_id: P, user: U) -> Result>, Error> [INFO] [stdout] | ---------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 144 | / NonEmpty::from_vec(local_branches).map(|branches| Revisions { [INFO] [stdout] 145 | | peer_id, [INFO] [stdout] 146 | | user, [INFO] [stdout] 147 | | branches, [INFO] [stdout] 148 | | tags, [INFO] [stdout] 149 | | }), [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `radicle-source` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `radicle-source` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "9363db435dd629c1852eb894db3f39ef63cf50e5ce818aa98d5a7d68e92977d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9363db435dd629c1852eb894db3f39ef63cf50e5ce818aa98d5a7d68e92977d0", kill_on_drop: false }` [INFO] [stdout] 9363db435dd629c1852eb894db3f39ef63cf50e5ce818aa98d5a7d68e92977d0