[INFO] fetching crate radiant 0.3.0... [INFO] checking radiant-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate radiant 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate radiant 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate radiant 0.3.0 [INFO] finished tweaking crates.io crate radiant 0.3.0 [INFO] tweaked toml for crates.io crate radiant 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate radiant 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb1c17e80b88c017e4f62fcf71d57d852c50fbdef36aa0bb34e301bc8b7149f8 [INFO] running `Command { std: "docker" "start" "-a" "bb1c17e80b88c017e4f62fcf71d57d852c50fbdef36aa0bb34e301bc8b7149f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb1c17e80b88c017e4f62fcf71d57d852c50fbdef36aa0bb34e301bc8b7149f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb1c17e80b88c017e4f62fcf71d57d852c50fbdef36aa0bb34e301bc8b7149f8", kill_on_drop: false }` [INFO] [stdout] bb1c17e80b88c017e4f62fcf71d57d852c50fbdef36aa0bb34e301bc8b7149f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] eb734e46268b918c5afa3d75a7fcc6ae0b085b7f6b907553c1bdefd30185649c [INFO] running `Command { std: "docker" "start" "-a" "eb734e46268b918c5afa3d75a7fcc6ae0b085b7f6b907553c1bdefd30185649c", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling pkg-config v0.3.19 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling xml-rs v0.8.3 [INFO] [stderr] Compiling once_cell v1.7.0 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling regex-syntax v0.6.22 [INFO] [stderr] Compiling unicode-width v0.1.8 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling libloading v0.7.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling humantime v2.1.0 [INFO] [stderr] Compiling bindgen v0.56.0 [INFO] [stderr] Compiling thread_local v1.1.3 [INFO] [stderr] Compiling termcolor v1.1.2 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Compiling nom v5.1.2 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling aho-corasick v0.7.15 [INFO] [stderr] Compiling nom v6.1.2 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling clang-sys v1.1.1 [INFO] [stderr] Compiling wayland-sys v0.27.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Checking downcast-rs v1.2.0 [INFO] [stderr] Compiling x11-dl v2.18.5 [INFO] [stderr] Compiling wayland-scanner v0.27.0 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling cc v1.0.67 [INFO] [stderr] Compiling cargo-husky v1.5.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Checking radiant v0.3.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling which v3.1.1 [INFO] [stdout] warning: struct `ScanlinesIter` is never constructed [INFO] [stdout] --> src/loader.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 220 | struct ScanlinesIter { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:217:5 [INFO] [stdout] | [INFO] [stdout] 216 | pub fn load(reader: R) -> Result { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Loader::new(reader)?.load_image() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 19 | pub fn new(mut reader: R) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | let (width, height, reader) = header::parse_header(reader)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | [INFO] [stdout] 30 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 31 | | width, [INFO] [stdout] 32 | | height, [INFO] [stdout] 33 | | reader, [INFO] [stdout] 34 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader/header.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) fn parse_header(mut reader: R) -> LoadResult<(usize, usize, R)> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | DimParser::new(reader)?.parse() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader/header.rs:9:34 [INFO] [stdout] | [INFO] [stdout] 9 | let mut next_is_eol = || reader.read_byte().map(|b| b == EOL); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader/header.rs:26:12 [INFO] [stdout] | [INFO] [stdout] 24 | fn new(mut reader: R) -> LoadResult { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let byte = reader.read_byte()?; [INFO] [stdout] 26 | Ok(Self { reader, byte }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/loader/header.rs:36:12 [INFO] [stdout] | [INFO] [stdout] 29 | fn parse(mut self) -> LoadResult<(usize, usize, R)> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | Ok((x, y, self.reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling clap v2.33.3 [INFO] [stderr] error: could not compile `radiant` (lib) due to 7 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "eb734e46268b918c5afa3d75a7fcc6ae0b085b7f6b907553c1bdefd30185649c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eb734e46268b918c5afa3d75a7fcc6ae0b085b7f6b907553c1bdefd30185649c", kill_on_drop: false }` [INFO] [stdout] eb734e46268b918c5afa3d75a7fcc6ae0b085b7f6b907553c1bdefd30185649c