[INFO] fetching crate rabbit-digger 0.1.1... [INFO] checking rabbit-digger-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate rabbit-digger 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate rabbit-digger 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate rabbit-digger 0.1.1 [INFO] finished tweaking crates.io crate rabbit-digger 0.1.1 [INFO] tweaked toml for crates.io crate rabbit-digger 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate rabbit-digger 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 82390545a8cca1e343277e40c5b8d1bedab203672705b783a8c462899c997a20 [INFO] running `Command { std: "docker" "start" "-a" "82390545a8cca1e343277e40c5b8d1bedab203672705b783a8c462899c997a20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "82390545a8cca1e343277e40c5b8d1bedab203672705b783a8c462899c997a20", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "82390545a8cca1e343277e40c5b8d1bedab203672705b783a8c462899c997a20", kill_on_drop: false }` [INFO] [stdout] 82390545a8cca1e343277e40c5b8d1bedab203672705b783a8c462899c997a20 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d4ae55f3bd6d65a762476e067bf45a7a67e89e8e519a6f6d9203833023ba49dc [INFO] running `Command { std: "docker" "start" "-a" "d4ae55f3bd6d65a762476e067bf45a7a67e89e8e519a6f6d9203833023ba49dc", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling libc v0.2.93 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking futures-core v0.3.14 [INFO] [stderr] Checking futures-sink v0.3.14 [INFO] [stderr] Checking once_cell v1.7.2 [INFO] [stderr] Checking pin-project-lite v0.2.6 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking futures-channel v0.3.14 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking futures-task v0.3.14 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking futures-io v0.3.14 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling serde_json v1.0.64 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling anyhow v1.0.38 [INFO] [stderr] Compiling unicode-segmentation v1.7.1 [INFO] [stderr] Compiling rustversion v1.0.4 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Compiling indexmap v1.6.2 [INFO] [stderr] Compiling tokio v1.5.0 [INFO] [stderr] Compiling getrandom v0.2.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking thread_local v1.1.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.2 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking regex-syntax v0.6.22 [INFO] [stderr] Checking paw-raw v1.0.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking dtoa v0.4.7 [INFO] [stderr] Checking managed v0.7.2 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking mio v0.7.11 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking socket2 v0.4.0 [INFO] [stderr] Checking lru_time_cache v0.11.10 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking dotenv v0.15.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking topological-sort v0.1.0 [INFO] [stderr] Checking smoltcp v0.7.1 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Checking regex v1.4.3 [INFO] [stderr] Checking env_logger v0.8.3 [INFO] [stderr] Compiling darling_core v0.12.4 [INFO] [stderr] Compiling futures-macro v0.3.14 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling async-trait v0.1.42 [INFO] [stderr] Compiling paw-attributes v1.0.2 [INFO] [stderr] Compiling structopt-derive v0.4.14 [INFO] [stderr] Checking paw v1.0.0 [INFO] [stderr] Checking futures-util v0.3.14 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking structopt v0.3.21 [INFO] [stderr] Compiling darling_macro v0.12.4 [INFO] [stderr] Compiling darling v0.12.4 [INFO] [stderr] Compiling serde_with_macros v1.4.1 [INFO] [stderr] Checking futures-executor v0.3.14 [INFO] [stderr] Checking futures v0.3.13 [INFO] [stderr] Checking serde_yaml v0.8.17 [INFO] [stderr] Checking serde_with v1.9.0 [INFO] [stderr] Checking rd-interface v0.4.0 [INFO] [stderr] Checking rd-std v0.1.0 [INFO] [stderr] Checking rabbit-digger v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/controller/event.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | NewTcp(Address), [INFO] [stdout] | ------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | NewTcp(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/controller/event.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | Outbound(usize), [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | Outbound(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/controller/event.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | Inbound(usize), [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 11 | Inbound(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `uuid`, `event_type`, and `time` are never read [INFO] [stdout] --> src/controller/event.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Event { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 16 | pub uuid: Uuid, [INFO] [stdout] | ^^^^ [INFO] [stdout] 17 | pub event_type: EventType, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 18 | pub time: Instant, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/matcher.rs:16:35 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | MaybeAsync::Sync { value: Some(value) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/rule_net.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 32 | fn new(net: HashMap, config: CompositeRule) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let rule = config [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let rule = Arc::new(rule); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | [INFO] [stdout] 50 | Ok(Rule { rule }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/rule_net.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 37 | let matcher = get_matcher(matcher)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(RuleItem { [INFO] [stdout] | ____________________^ [INFO] [stdout] 39 | | matcher, [INFO] [stdout] 40 | | target: net [INFO] [stdout] 41 | | .get(&target) [INFO] [stdout] ... | [INFO] [stdout] 44 | | target_name: target, [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/rule_net.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(net: HashMap, config: CompositeRule) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(RuleNet { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | rule: Rule::new(net, config)?, [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | .into_dyn()) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/udp.rs:51:33 [INFO] [stdout] | [INFO] [stdout] 37 | fn new(udp: UdpSocket, tx: Sender) -> DroppableUdpSocket { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let (stop_sender, mut stop) = oneshot::channel::<()>(); [INFO] [stdout] | ----------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let u = udp.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | DroppableUdpSocket(udp, Some(stop_sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/udp.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(rule: Rule, context: Context, bind_addr: Address) -> UdpRuleSocket { [INFO] [stdout] | ---------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let (tx, rx) = channel::(100); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let nat = Mutex::new(LruCache::with_expiry_duration_and_capacity( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | rx: Mutex::new(rx), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/select.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(net: HashMap) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let nets = net.into_iter().map(|(_, v)| v).collect::>(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(SelectNet(nets).into_dyn()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn get_net(&self, net: Net) -> Net { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | / ControllerNet { [INFO] [stdout] 100 | | net, [INFO] [stdout] 101 | | sender: self.sender.clone(), [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rabbit_digger.rs:98:63 [INFO] [stdout] | [INFO] [stdout] 98 | let net_cfg = config.net.into_iter().map(|(k, v)| (k, AllNet::Net(v))); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rabbit_digger.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|(k, v)| (k, AllNet::Composite(v))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rabbit_digger.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let name = i.name; [INFO] [stdout] 113 | start_server(i.server).map(|r| (name, r)).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn topological_sort(mut map: HashMap, get_deps: D) -> Option> [INFO] [stdout] | ---------------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let mut ts = TopologicalSort::<&K>::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let mut list = Vec::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / list.into_iter() [INFO] [stdout] 29 | | .map(|k| { [INFO] [stdout] 30 | | let v = map.remove(&k); [INFO] [stdout] 31 | | v.map(|v| (k, v)) [INFO] [stdout] 32 | | }) [INFO] [stdout] 33 | | .filter_map(|i| i) [INFO] [stdout] 34 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:31:23 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|k| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let v = map.remove(&k); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | v.map(|v| (k, v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rabbit-digger` (lib test) due to 14 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/controller/event.rs:8:12 [INFO] [stdout] | [INFO] [stdout] 8 | NewTcp(Address), [INFO] [stdout] | ------ ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 8 | NewTcp(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/controller/event.rs:10:14 [INFO] [stdout] | [INFO] [stdout] 10 | Outbound(usize), [INFO] [stdout] | -------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 10 | Outbound(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/controller/event.rs:11:13 [INFO] [stdout] | [INFO] [stdout] 11 | Inbound(usize), [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `EventType` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 11 | Inbound(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `uuid`, `event_type`, and `time` are never read [INFO] [stdout] --> src/controller/event.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct Event { [INFO] [stdout] | ----- fields in this struct [INFO] [stdout] 16 | pub uuid: Uuid, [INFO] [stdout] | ^^^^ [INFO] [stdout] 17 | pub event_type: EventType, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 18 | pub time: Instant, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/matcher.rs:16:35 [INFO] [stdout] | [INFO] [stdout] 15 | fn from(value: T) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | MaybeAsync::Sync { value: Some(value) } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/rule_net.rs:50:12 [INFO] [stdout] | [INFO] [stdout] 32 | fn new(net: HashMap, config: CompositeRule) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | let rule = config [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let rule = Arc::new(rule); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | [INFO] [stdout] 50 | Ok(Rule { rule }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/rule_net.rs:38:20 [INFO] [stdout] | [INFO] [stdout] 37 | let matcher = get_matcher(matcher)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(RuleItem { [INFO] [stdout] | ____________________^ [INFO] [stdout] 39 | | matcher, [INFO] [stdout] 40 | | target: net [INFO] [stdout] 41 | | .get(&target) [INFO] [stdout] ... | [INFO] [stdout] 44 | | target_name: target, [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/rule_net.rs:89:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(net: HashMap, config: CompositeRule) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 89 | Ok(RuleNet { [INFO] [stdout] | ____________^ [INFO] [stdout] 90 | | rule: Rule::new(net, config)?, [INFO] [stdout] 91 | | } [INFO] [stdout] 92 | | .into_dyn()) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/udp.rs:51:33 [INFO] [stdout] | [INFO] [stdout] 37 | fn new(udp: UdpSocket, tx: Sender) -> DroppableUdpSocket { [INFO] [stdout] | -------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | let (stop_sender, mut stop) = oneshot::channel::<()>(); [INFO] [stdout] | ----------- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let u = udp.clone(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | DroppableUdpSocket(udp, Some(stop_sender)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/rule/udp.rs:80:17 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn new(rule: Rule, context: Context, bind_addr: Address) -> UdpRuleSocket { [INFO] [stdout] | ---------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 65 | let (tx, rx) = channel::(100); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | let nat = Mutex::new(LruCache::with_expiry_duration_and_capacity( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | rx: Mutex::new(rx), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/composite/select.rs:15:12 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn new(net: HashMap) -> anyhow::Result { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let nets = net.into_iter().map(|(_, v)| v).collect::>(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 15 | Ok(SelectNet(nets).into_dyn()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn get_net(&self, net: Net) -> Net { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | / ControllerNet { [INFO] [stdout] 100 | | net, [INFO] [stdout] 101 | | sender: self.sender.clone(), [INFO] [stdout] 102 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rabbit_digger.rs:98:63 [INFO] [stdout] | [INFO] [stdout] 98 | let net_cfg = config.net.into_iter().map(|(k, v)| (k, AllNet::Net(v))); [INFO] [stdout] | ------ ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rabbit_digger.rs:102:31 [INFO] [stdout] | [INFO] [stdout] 102 | .map(|(k, v)| (k, AllNet::Composite(v))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rabbit_digger.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 111 | .map(|i| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | let name = i.name; [INFO] [stdout] 113 | start_server(i.server).map(|r| (name, r)).boxed() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 5 | pub fn topological_sort(mut map: HashMap, get_deps: D) -> Option> [INFO] [stdout] | ---------------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | let mut ts = TopologicalSort::<&K>::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | let mut list = Vec::::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | / list.into_iter() [INFO] [stdout] 29 | | .map(|k| { [INFO] [stdout] 30 | | let v = map.remove(&k); [INFO] [stdout] 31 | | v.map(|v| (k, v)) [INFO] [stdout] 32 | | }) [INFO] [stdout] 33 | | .filter_map(|i| i) [INFO] [stdout] 34 | | .collect(), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:31:23 [INFO] [stdout] | [INFO] [stdout] 29 | .map(|k| { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | let v = map.remove(&k); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | v.map(|v| (k, v)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `rabbit-digger` (lib) due to 14 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d4ae55f3bd6d65a762476e067bf45a7a67e89e8e519a6f6d9203833023ba49dc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d4ae55f3bd6d65a762476e067bf45a7a67e89e8e519a6f6d9203833023ba49dc", kill_on_drop: false }` [INFO] [stdout] d4ae55f3bd6d65a762476e067bf45a7a67e89e8e519a6f6d9203833023ba49dc