[INFO] fetching crate ra_ap_ssr 0.0.39... [INFO] checking ra_ap_ssr-0.0.39 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ra_ap_ssr 0.0.39 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate ra_ap_ssr 0.0.39 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ra_ap_ssr 0.0.39 [INFO] finished tweaking crates.io crate ra_ap_ssr 0.0.39 [INFO] tweaked toml for crates.io crate ra_ap_ssr 0.0.39 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 139 packages to latest compatible versions [INFO] [stderr] Adding always-assert v0.1.3 (latest: v0.2.0) [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding chalk-derive v0.58.0 (latest: v0.98.0) [INFO] [stderr] Adding chalk-ir v0.58.0 (latest: v0.98.0) [INFO] [stderr] Adding chalk-recursive v0.58.0 (latest: v0.98.0) [INFO] [stderr] Adding chalk-solve v0.58.0 (latest: v0.98.0) [INFO] [stderr] Adding countme v2.0.4 (latest: v3.0.1) [INFO] [stderr] Adding dashmap v4.0.2 (latest: v6.0.1) [INFO] [stderr] Adding fixedbitset v0.2.0 (latest: v0.5.7) [INFO] [stderr] Adding hashbrown v0.9.1 (latest: v0.14.5) [INFO] [stderr] Adding hashbrown v0.12.3 (latest: v0.14.5) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding indexmap v1.9.3 (latest: v2.5.0) [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding matchers v0.0.1 (latest: v0.2.0) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding petgraph v0.5.1 (latest: v0.6.5) [INFO] [stderr] Adding ra_ap_base_db v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_cfg v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_hir v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_hir_def v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_hir_expand v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_hir_ty v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_ide_db v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_la-arena v0.0.39 (latest: v0.0.149) [INFO] [stderr] Adding ra_ap_mbe v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_parser v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_paths v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_profile v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_stdx v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_syntax v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_test_utils v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_text_edit v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_tt v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding ra_ap_vfs v0.0.39 (latest: v0.0.232) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding rowan v0.12.6 (latest: v0.15.16) [INFO] [stderr] Adding rustc-ap-rustc_lexer v707.0.0 (latest: v727.0.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding smol_str v0.1.24 (latest: v0.2.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding tracing-log v0.1.4 (latest: v0.2.0) [INFO] [stderr] Adding tracing-subscriber v0.2.25 (latest: v0.3.18) [INFO] [stderr] Adding tracing-tree v0.1.11 (latest: v0.4.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7586ddecb306d74f6c3b8cfbc0eae51b1ec8ead798d17ea48835a42d1fb14268 [INFO] running `Command { std: "docker" "start" "-a" "7586ddecb306d74f6c3b8cfbc0eae51b1ec8ead798d17ea48835a42d1fb14268", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7586ddecb306d74f6c3b8cfbc0eae51b1ec8ead798d17ea48835a42d1fb14268", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7586ddecb306d74f6c3b8cfbc0eae51b1ec8ead798d17ea48835a42d1fb14268", kill_on_drop: false }` [INFO] [stdout] 7586ddecb306d74f6c3b8cfbc0eae51b1ec8ead798d17ea48835a42d1fb14268 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 891e5d4eaef9cdc259e4b3151972036865c686ec4288ff41052503f06a80ba68 [INFO] running `Command { std: "docker" "start" "-a" "891e5d4eaef9cdc259e4b3151972036865c686ec4288ff41052503f06a80ba68", kill_on_drop: false }` [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking dashmap v4.0.2 [INFO] [stderr] Checking always-assert v0.1.3 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking perf-event-open-sys v4.0.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking ra_ap_stdx v0.0.39 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Checking ra_ap_la-arena v0.0.39 [INFO] [stderr] Checking dissimilar v1.0.9 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking perf-event v0.4.8 [INFO] [stderr] Checking countme v2.0.4 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking unicode-xid v0.2.5 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking rustc-ap-rustc_lexer v707.0.0 [INFO] [stderr] Checking ra_ap_profile v0.0.39 [INFO] [stderr] Checking ra_ap_parser v0.0.39 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking ra_ap_text_edit v0.0.39 [INFO] [stderr] Checking rowan v0.12.6 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking ra_ap_paths v0.0.39 [INFO] [stderr] Checking fixedbitset v0.2.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking ra_ap_vfs v0.0.39 [INFO] [stderr] Checking petgraph v0.5.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking ena v0.14.3 [INFO] [stderr] Checking scoped-tls v1.0.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking smol_str v0.1.24 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Checking ra_ap_tt v0.0.39 [INFO] [stderr] Checking ra_ap_cfg v0.0.39 [INFO] [stderr] Checking ra_ap_test_utils v0.0.39 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking ra_ap_syntax v0.0.39 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling salsa-macros v0.16.0 [INFO] [stderr] Compiling chalk-derive v0.58.0 [INFO] [stderr] Checking ra_ap_mbe v0.0.39 [INFO] [stderr] Checking tracing-tree v0.1.11 [INFO] [stderr] Checking chalk-ir v0.58.0 [INFO] [stderr] Checking salsa v0.16.1 [INFO] [stderr] Checking ra_ap_base_db v0.0.39 [INFO] [stderr] Checking ra_ap_hir_expand v0.0.39 [INFO] [stderr] Checking chalk-solve v0.58.0 [INFO] [stderr] Checking ra_ap_hir_def v0.0.39 [INFO] [stderr] Checking chalk-recursive v0.58.0 [INFO] [stderr] Checking ra_ap_hir_ty v0.0.39 [INFO] [stderr] Checking ra_ap_hir v0.0.39 [INFO] [stderr] Checking ra_ap_ide_db v0.0.39 [INFO] [stderr] Checking ra_ap_ssr v0.0.39 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `raw` is never read [INFO] [stdout] --> src/lib.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 94 | pub struct SsrPattern { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 95 | raw: parsing::RawPattern, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SsrPattern` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `node` is never read [INFO] [stdout] --> src/matching.rs:67:16 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) struct PlaceholderMatch { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | pub(crate) node: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `PlaceholderMatch` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 122 | let sema = Semantics::new(db); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let resolution_scope = resolving::ResolutionScope::new(&sema, lookup_context); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | MatchFinder { sema, rules: Vec::new(), resolution_scope, restrict_ranges } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:30 [INFO] [stdout] | [INFO] [stdout] 135 | .and_then(|root| db.source_root(root.clone()).iter().next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 164 | let mut matches_by_file = FxHashMap::default(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / matches_by_file [INFO] [stdout] 173 | | .into_iter() [INFO] [stdout] 174 | | .map(|(file_id, matches)| { [INFO] [stdout] 175 | | ( [INFO] [stdout] ... | [INFO] [stdout] 182 | | ) [INFO] [stdout] 183 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:179:26 [INFO] [stdout] | [INFO] [stdout] 174 | .map(|(file_id, matches)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | &self.sema.db.file_text(file_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matching.rs:385:15 [INFO] [stdout] | [INFO] [stdout] 382 | pattern: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | code: Option, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | ) -> Result<(), MatchFailed> { [INFO] [stdout] 385 | match (pattern, code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matching.rs:598:51 [INFO] [stdout] | [INFO] [stdout] 598 | &code.arg_list().and_then(|code_args| code_args.args().next()), [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 100 | pattern: Result, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | template: Option>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) { [INFO] [stdout] 103 | match (pattern, template) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 206 | let raw_pattern = pattern_str.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let parsed_rules = ParsedRule::new(&raw_pattern, None)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | Ok(SsrPattern { raw: raw_pattern, parsed_rules }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:310:8 [INFO] [stdout] | [INFO] [stdout] 278 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | let mut constraints = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | let name = name.ok_or_else(|| SsrError::new("Placeholder ($) with no name"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | Ok(Placeholder::new(name, constraints)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolving.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 45 | rule: parsing::ParsedRule, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let resolver = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Resolver { resolution_scope, placeholders_by_stand_in: rule.placeholders_by_stand_in }; [INFO] [stdout] 51 | let resolved_template = if let Some(template) = rule.template { [INFO] [stdout] | ----------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(ResolvedRule { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | pattern: resolver.resolve_pattern_tree(rule.pattern)?, [INFO] [stdout] 58 | | template: resolved_template, [INFO] [stdout] 59 | | index, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolving.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn resolve_pattern_tree(&self, pattern: SyntaxNode) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let mut resolved_paths = FxHashMap::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.resolve(pattern.clone(), 0, &mut resolved_paths)?; [INFO] [stdout] 82 | let ufcs_function_calls = resolved_paths [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(ResolvedPattern { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | node: pattern, [INFO] [stdout] 108 | | resolved_paths, [INFO] [stdout] 109 | | placeholders_by_stand_in: self.placeholders_by_stand_in.clone(), [INFO] [stdout] 110 | | ufcs_function_calls, [INFO] [stdout] 111 | | contains_self, [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolving.rs:259:34 [INFO] [stdout] | [INFO] [stdout] 259 | path.segment().map(|segment| segment.self_token().is_some()).unwrap_or(false) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:279:34 [INFO] [stdout] | [INFO] [stdout] 279 | .map(|(node, resolved)| (node.text().len(), resolved)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_ssr` (lib) due to 14 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `raw` is never read [INFO] [stdout] --> src/lib.rs:95:5 [INFO] [stdout] | [INFO] [stdout] 94 | pub struct SsrPattern { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] 95 | raw: parsing::RawPattern, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `SsrPattern` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:124:36 [INFO] [stdout] | [INFO] [stdout] 122 | let sema = Semantics::new(db); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | let resolution_scope = resolving::ResolutionScope::new(&sema, lookup_context); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | MatchFinder { sema, rules: Vec::new(), resolution_scope, restrict_ranges } [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:135:30 [INFO] [stdout] | [INFO] [stdout] 135 | .and_then(|root| db.source_root(root.clone()).iter().next()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:172:9 [INFO] [stdout] | [INFO] [stdout] 164 | let mut matches_by_file = FxHashMap::default(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | / matches_by_file [INFO] [stdout] 173 | | .into_iter() [INFO] [stdout] 174 | | .map(|(file_id, matches)| { [INFO] [stdout] 175 | | ( [INFO] [stdout] ... | [INFO] [stdout] 182 | | ) [INFO] [stdout] 183 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:179:26 [INFO] [stdout] | [INFO] [stdout] 174 | .map(|(file_id, matches)| { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | &self.sema.db.file_text(file_id), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matching.rs:385:15 [INFO] [stdout] | [INFO] [stdout] 382 | pattern: Option, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 383 | code: Option, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 384 | ) -> Result<(), MatchFailed> { [INFO] [stdout] 385 | match (pattern, code) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/matching.rs:598:51 [INFO] [stdout] | [INFO] [stdout] 598 | &code.arg_list().and_then(|code_args| code_args.args().next()), [INFO] [stdout] | --------- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:103:15 [INFO] [stdout] | [INFO] [stdout] 100 | pattern: Result, [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | template: Option>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | ) { [INFO] [stdout] 103 | match (pattern, template) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:208:12 [INFO] [stdout] | [INFO] [stdout] 206 | let raw_pattern = pattern_str.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | let parsed_rules = ParsedRule::new(&raw_pattern, None)?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 208 | Ok(SsrPattern { raw: raw_pattern, parsed_rules }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parsing.rs:310:8 [INFO] [stdout] | [INFO] [stdout] 278 | let mut name = None; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 279 | let mut constraints = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 309 | let name = name.ok_or_else(|| SsrError::new("Placeholder ($) with no name"))?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | Ok(Placeholder::new(name, constraints)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolving.rs:56:12 [INFO] [stdout] | [INFO] [stdout] 45 | rule: parsing::ParsedRule, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | let resolver = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | Resolver { resolution_scope, placeholders_by_stand_in: rule.placeholders_by_stand_in }; [INFO] [stdout] 51 | let resolved_template = if let Some(template) = rule.template { [INFO] [stdout] | ----------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 56 | Ok(ResolvedRule { [INFO] [stdout] | ____________^ [INFO] [stdout] 57 | | pattern: resolver.resolve_pattern_tree(rule.pattern)?, [INFO] [stdout] 58 | | template: resolved_template, [INFO] [stdout] 59 | | index, [INFO] [stdout] 60 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolving.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 77 | fn resolve_pattern_tree(&self, pattern: SyntaxNode) -> Result { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 80 | let mut resolved_paths = FxHashMap::default(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | self.resolve(pattern.clone(), 0, &mut resolved_paths)?; [INFO] [stdout] 82 | let ufcs_function_calls = resolved_paths [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(ResolvedPattern { [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | node: pattern, [INFO] [stdout] 108 | | resolved_paths, [INFO] [stdout] 109 | | placeholders_by_stand_in: self.placeholders_by_stand_in.clone(), [INFO] [stdout] 110 | | ufcs_function_calls, [INFO] [stdout] 111 | | contains_self, [INFO] [stdout] 112 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resolving.rs:259:34 [INFO] [stdout] | [INFO] [stdout] 259 | path.segment().map(|segment| segment.self_token().is_some()).unwrap_or(false) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:279:34 [INFO] [stdout] | [INFO] [stdout] 279 | .map(|(node, resolved)| (node.text().len(), resolved)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_ssr` (lib test) due to 14 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "891e5d4eaef9cdc259e4b3151972036865c686ec4288ff41052503f06a80ba68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "891e5d4eaef9cdc259e4b3151972036865c686ec4288ff41052503f06a80ba68", kill_on_drop: false }` [INFO] [stdout] 891e5d4eaef9cdc259e4b3151972036865c686ec4288ff41052503f06a80ba68