[INFO] fetching crate ra_ap_base_db 0.0.232... [INFO] checking ra_ap_base_db-0.0.232 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate ra_ap_base_db 0.0.232 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate ra_ap_base_db 0.0.232 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate ra_ap_base_db 0.0.232 [INFO] finished tweaking crates.io crate ra_ap_base_db 0.0.232 [INFO] tweaked toml for crates.io crate ra_ap_base_db 0.0.232 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 88 packages to latest compatible versions [INFO] [stderr] Adding dashmap v5.5.3 (latest: v6.0.1) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding ra-ap-rustc_lexer v0.63.0 (latest: v0.66.0) [INFO] [stderr] Adding rowan v0.15.15 (latest: v0.15.16) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b0ab4accb1c153552c221fdd32a66606b4d3524545900828d4eb80baa6eb55e7 [INFO] running `Command { std: "docker" "start" "-a" "b0ab4accb1c153552c221fdd32a66606b4d3524545900828d4eb80baa6eb55e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b0ab4accb1c153552c221fdd32a66606b4d3524545900828d4eb80baa6eb55e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0ab4accb1c153552c221fdd32a66606b4d3524545900828d4eb80baa6eb55e7", kill_on_drop: false }` [INFO] [stdout] b0ab4accb1c153552c221fdd32a66606b4d3524545900828d4eb80baa6eb55e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9d6176a40070c5b60dc9101b42a6446ad4b30ed5a1e7ff90a894ce31d6c64335 [INFO] running `Command { std: "docker" "start" "-a" "9d6176a40070c5b60dc9101b42a6446ad4b30ed5a1e7ff90a894ce31d6c64335", kill_on_drop: false }` [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking unicode-xid v0.2.5 [INFO] [stderr] Checking jod-thread v0.1.2 [INFO] [stderr] Checking unicode-properties v0.1.2 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Compiling fst v0.4.7 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking drop_bomb v0.1.5 [INFO] [stderr] Checking sptr v0.3.2 [INFO] [stderr] Checking ra_ap_limit v0.0.232 [INFO] [stderr] Compiling ra_ap_salsa-macros v0.0.232 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking cov-mark v2.0.0 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking ra-ap-rustc_lexer v0.63.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking la-arena v0.3.1 [INFO] [stderr] Checking lz4_flex v0.11.3 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking always-assert v0.2.0 [INFO] [stderr] Checking ra_ap_parser v0.0.232 [INFO] [stderr] Checking ra_ap_paths v0.0.232 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking dashmap v5.5.3 [INFO] [stderr] Checking rowan v0.15.15 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking ra_ap_stdx v0.0.232 [INFO] [stderr] Checking ra_ap_text_edit v0.0.232 [INFO] [stderr] Checking ra_ap_vfs v0.0.232 [INFO] [stderr] Checking triomphe v0.1.13 [INFO] [stderr] Checking ra_ap_intern v0.0.232 [INFO] [stderr] Checking ra_ap_salsa v0.0.232 [INFO] [stderr] Checking ra_ap_syntax v0.0.232 [INFO] [stderr] Checking ra_ap_tt v0.0.232 [INFO] [stderr] Checking ra_ap_cfg v0.0.232 [INFO] [stderr] Checking ra_ap_span v0.0.232 [INFO] [stderr] Checking ra_ap_base_db v0.0.232 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:242:56 [INFO] [stdout] | [INFO] [stdout] 241 | let crate_name = CrateName::normalize_dashes(canonical_name); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | CrateDisplayName { crate_name, canonical_name: Symbol::intern(canonical_name) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:430:55 [INFO] [stdout] | [INFO] [stdout] 430 | let path = path.into_iter().map(|it| (it, self[it].display_name.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_base_db` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:242:56 [INFO] [stdout] | [INFO] [stdout] 241 | let crate_name = CrateName::normalize_dashes(canonical_name); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | CrateDisplayName { crate_name, canonical_name: Symbol::intern(canonical_name) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:430:55 [INFO] [stdout] | [INFO] [stdout] 430 | let path = path.into_iter().map(|it| (it, self[it].display_name.clone())).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `ra_ap_base_db` (lib test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "9d6176a40070c5b60dc9101b42a6446ad4b30ed5a1e7ff90a894ce31d6c64335", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d6176a40070c5b60dc9101b42a6446ad4b30ed5a1e7ff90a894ce31d6c64335", kill_on_drop: false }` [INFO] [stdout] 9d6176a40070c5b60dc9101b42a6446ad4b30ed5a1e7ff90a894ce31d6c64335