[INFO] fetching crate r2d2_odbc_api 0.2.0... [INFO] checking r2d2_odbc_api-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate r2d2_odbc_api 0.2.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate r2d2_odbc_api 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate r2d2_odbc_api 0.2.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate r2d2_odbc_api 0.2.0 [INFO] tweaked toml for crates.io crate r2d2_odbc_api 0.2.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate r2d2_odbc_api 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0ec60f58a9a967756f426abde45078337302ff4206c1b95b020381bb776e6d7a [INFO] running `Command { std: "docker" "start" "-a" "0ec60f58a9a967756f426abde45078337302ff4206c1b95b020381bb776e6d7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0ec60f58a9a967756f426abde45078337302ff4206c1b95b020381bb776e6d7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ec60f58a9a967756f426abde45078337302ff4206c1b95b020381bb776e6d7a", kill_on_drop: false }` [INFO] [stdout] 0ec60f58a9a967756f426abde45078337302ff4206c1b95b020381bb776e6d7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50e4a3dee992747b294efb6ebbcbb572bfdc09e7fb6719a3741429fc3bf4778d [INFO] running `Command { std: "docker" "start" "-a" "50e4a3dee992747b294efb6ebbcbb572bfdc09e7fb6719a3741429fc3bf4778d", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling futures-channel v0.3.21 [INFO] [stderr] Compiling proc-macro2-diagnostics v0.9.1 [INFO] [stderr] Compiling futures-util v0.3.21 [INFO] [stderr] Compiling yansi v0.5.1 [INFO] [stderr] Compiling subtle v2.4.1 [INFO] [stderr] Compiling indexmap v1.8.1 [INFO] [stderr] Compiling pin-project-lite v0.2.9 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.21 [INFO] [stderr] Compiling bytes v1.1.0 [INFO] [stderr] Compiling futures-sink v0.3.21 [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Compiling cpufeatures v0.2.2 [INFO] [stderr] Compiling itoa v1.0.2 [INFO] [stderr] Compiling uncased v0.9.7 [INFO] [stderr] Compiling time-macros v0.2.4 [INFO] [stderr] Compiling opaque-debug v0.3.0 [INFO] [stderr] Compiling tracing-core v0.1.26 [INFO] [stderr] Compiling futures-task v0.3.21 [INFO] [stderr] Compiling cookie v0.16.0 [INFO] [stderr] Compiling pin-utils v0.1.0 [INFO] [stderr] Checking futures-io v0.3.21 [INFO] [stderr] Compiling slab v0.4.6 [INFO] [stderr] Compiling ref-cast v1.0.7 [INFO] [stderr] Compiling pear_codegen v0.2.3 [INFO] [stderr] Compiling http v0.2.7 [INFO] [stderr] Compiling ref-cast-impl v1.0.7 [INFO] [stderr] Compiling hashbrown v0.11.2 [INFO] [stderr] Compiling tracing v0.1.34 [INFO] [stderr] Compiling ppv-lite86 v0.2.16 [INFO] [stderr] Compiling bitflags v1.3.2 [INFO] [stderr] Compiling devise_core v0.3.1 [INFO] [stderr] Compiling try-lock v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.8.5 [INFO] [stderr] Compiling num_threads v0.1.6 [INFO] [stderr] Compiling mio v0.8.3 [INFO] [stderr] Checking socket2 v0.4.4 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Compiling getrandom v0.2.6 [INFO] [stderr] Compiling http-body v0.4.4 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking universal-hash v0.4.1 [INFO] [stderr] Checking cipher v0.3.0 [INFO] [stderr] Compiling tokio v1.18.2 [INFO] [stderr] Compiling time v0.3.9 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking aead v0.4.3 [INFO] [stderr] Checking polyval v0.5.3 [INFO] [stderr] Compiling want v0.3.0 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Compiling httparse v1.7.1 [INFO] [stderr] Checking aes v0.7.5 [INFO] [stderr] Checking ctr v0.8.0 [INFO] [stderr] Checking ghash v0.4.4 [INFO] [stderr] Checking instant v0.1.12 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Compiling tower-service v0.3.1 [INFO] [stderr] Compiling devise_codegen v0.3.1 [INFO] [stderr] Checking inlinable_string v0.1.15 [INFO] [stderr] Compiling sha2 v0.10.2 [INFO] [stderr] Compiling httpdate v1.0.2 [INFO] [stderr] Compiling aes-gcm v0.9.4 [INFO] [stderr] Compiling hkdf v0.12.3 [INFO] [stderr] Compiling base64 v0.13.0 [INFO] [stderr] Compiling percent-encoding v2.1.0 [INFO] [stderr] Compiling pear v0.2.3 [INFO] [stderr] Compiling devise v0.3.1 [INFO] [stderr] Checking parking_lot_core v0.9.3 [INFO] [stderr] Compiling stable-pattern v0.1.0 [INFO] [stderr] Compiling atomic v0.5.1 [INFO] [stderr] Compiling multer v2.0.2 [INFO] [stderr] Compiling figment v0.10.6 [INFO] [stderr] Compiling state v0.5.3 [INFO] [stderr] Compiling async-trait v0.1.53 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling smallvec v1.8.0 [INFO] [stderr] Checking parking_lot v0.12.0 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking futures v0.3.21 [INFO] [stderr] Checking toml v0.5.9 [INFO] [stderr] Compiling async-stream-impl v0.3.3 [INFO] [stderr] Compiling rocket v0.5.0-rc.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.12 [INFO] [stderr] Compiling unicode-xid v0.2.3 [INFO] [stderr] Checking fastrand v1.7.0 [INFO] [stderr] Checking spin v0.9.3 [INFO] [stderr] Compiling thiserror v1.0.37 [INFO] [stderr] Compiling odbc-sys v0.21.2 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Checking scheduled-thread-pool v0.2.5 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking async-stream v0.3.3 [INFO] [stderr] Checking ubyte v0.10.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling thiserror-impl v1.0.37 [INFO] [stderr] Checking binascii v0.1.4 [INFO] [stderr] Compiling crossbeam-queue v0.3.6 [INFO] [stderr] Checking r2d2 v0.8.10 [INFO] [stderr] Compiling rocket_sync_db_pools_codegen v0.1.0-rc.2 [INFO] [stderr] Compiling anyhow v1.0.65 [INFO] [stderr] Checking widestring v1.0.2 [INFO] [stderr] Checking force-send-sync v1.0.0 [INFO] [stderr] Checking odbc-api v0.50.0 [INFO] [stderr] Compiling tokio-util v0.7.2 [INFO] [stderr] Checking tokio-util v0.6.10 [INFO] [stderr] Checking tokio-stream v0.1.8 [INFO] [stderr] Compiling h2 v0.3.13 [INFO] [stderr] Compiling hyper v0.14.18 [INFO] [stderr] Checking rocket_http v0.5.0-rc.2 [INFO] [stderr] Compiling rocket_codegen v0.5.0-rc.2 [INFO] [stderr] Checking rocket_sync_db_pools v0.1.0-rc.2 [INFO] [stderr] Checking r2d2_odbc_api v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use odbc_api::Environment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Environment` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use odbc_api::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use odbc_api::Environment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use odbc_api::Environment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Environment` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub use odbc_api::*; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use odbc_api::Environment; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `attach` is never used [INFO] [stdout] --> src/pool/connection.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | pub trait AttachODBC { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 74 | fn attach(self, manager: ODBCConnectionManager) -> ODBCConnection; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:21 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new>(connection_string: S, limit: u32) -> ODBCConnectionManager { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ODBCConnectionManager { [INFO] [stdout] 41 | shared: SharedPool::new_arc(connection_string.into(), limit), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 126 | let manager = ODBCConnectionManager::new(&config.url, config.pool_size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok(r2d2::Pool::builder() [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | .max_size(config.pool_size) [INFO] [stdout] 129 | | .build(manager)?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn new(pool: Arc, connection: Connection) -> Self { [INFO] [stdout] | --------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { [INFO] [stdout] 17 | connection: Some(connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn new(pool: Arc, connection: Connection) -> Self { [INFO] [stdout] | --------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn detach(mut self) -> Connection { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | / self.connection [INFO] [stdout] 24 | | .take() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 78 | fn attach(self, manager: ODBCConnectionManager) -> ODBCConnection { [INFO] [stdout] | ---- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ODBCConnection::new(Arc::clone(&manager.shared), self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/shared.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 23 | let pool = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let conn_str = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let conn = env.connect_with_connection_string(conn_str.as_str())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let connection = unsafe { conn.promote_to_send() }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(ODBCConnection::new(Arc::clone(self), connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `attach` is never used [INFO] [stdout] --> src/pool/connection.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 73 | pub trait AttachODBC { [INFO] [stdout] | ---------- method in this trait [INFO] [stdout] 74 | fn attach(self, manager: ODBCConnectionManager) -> ODBCConnection; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:41:21 [INFO] [stdout] | [INFO] [stdout] 39 | pub fn new>(connection_string: S, limit: u32) -> ODBCConnectionManager { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | ODBCConnectionManager { [INFO] [stdout] 41 | shared: SharedPool::new_arc(connection_string.into(), limit), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:127:12 [INFO] [stdout] | [INFO] [stdout] 126 | let manager = ODBCConnectionManager::new(&config.url, config.pool_size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | Ok(r2d2::Pool::builder() [INFO] [stdout] | ____________^ [INFO] [stdout] 128 | | .max_size(config.pool_size) [INFO] [stdout] 129 | | .build(manager)?) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |____________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:17:25 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn new(pool: Arc, connection: Connection) -> Self { [INFO] [stdout] | --------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Self { [INFO] [stdout] 17 | connection: Some(connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:18:19 [INFO] [stdout] | [INFO] [stdout] 15 | pub(crate) fn new(pool: Arc, connection: Connection) -> Self { [INFO] [stdout] | --------------------- ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | pool: Some(pool), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn detach(mut self) -> Connection { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | / self.connection [INFO] [stdout] 24 | | .take() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/connection.rs:79:29 [INFO] [stdout] | [INFO] [stdout] 78 | fn attach(self, manager: ODBCConnectionManager) -> ODBCConnection { [INFO] [stdout] | ---- ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 79 | ODBCConnection::new(Arc::clone(&manager.shared), self) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pool/shared.rs:47:12 [INFO] [stdout] | [INFO] [stdout] 23 | let pool = self [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | let conn_str = self [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let conn = env.connect_with_connection_string(conn_str.as_str())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let connection = unsafe { conn.promote_to_send() }; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 46 | [INFO] [stdout] 47 | Ok(ODBCConnection::new(Arc::clone(self), connection)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r2d2_odbc_api` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r2d2_odbc_api` (lib) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "50e4a3dee992747b294efb6ebbcbb572bfdc09e7fb6719a3741429fc3bf4778d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50e4a3dee992747b294efb6ebbcbb572bfdc09e7fb6719a3741429fc3bf4778d", kill_on_drop: false }` [INFO] [stdout] 50e4a3dee992747b294efb6ebbcbb572bfdc09e7fb6719a3741429fc3bf4778d