[INFO] fetching crate r-tftpd 0.3.3... [INFO] checking r-tftpd-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate r-tftpd 0.3.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate r-tftpd 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate r-tftpd 0.3.3 [INFO] finished tweaking crates.io crate r-tftpd 0.3.3 [INFO] tweaked toml for crates.io crate r-tftpd 0.3.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate r-tftpd 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ddb6aa7d3ef24dd88e4ac21f6be92445e0d4e46ad6a6b5a6b14e86cf3354722d [INFO] running `Command { std: "docker" "start" "-a" "ddb6aa7d3ef24dd88e4ac21f6be92445e0d4e46ad6a6b5a6b14e86cf3354722d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ddb6aa7d3ef24dd88e4ac21f6be92445e0d4e46ad6a6b5a6b14e86cf3354722d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ddb6aa7d3ef24dd88e4ac21f6be92445e0d4e46ad6a6b5a6b14e86cf3354722d", kill_on_drop: false }` [INFO] [stdout] ddb6aa7d3ef24dd88e4ac21f6be92445e0d4e46ad6a6b5a6b14e86cf3354722d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f85dd91b58188754150e27f8363d5d0f74edba9eabbdab42440b0edb907bde89 [INFO] running `Command { std: "docker" "start" "-a" "f85dd91b58188754150e27f8363d5d0f74edba9eabbdab42440b0edb907bde89", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.85 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking pin-project-lite v0.2.14 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling cc v1.0.99 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling serde v1.0.203 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking foreign-types-shared v0.1.1 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking foreign-types v0.3.2 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking tower-layer v0.3.2 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking miniz_oxide v0.7.3 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking flate2 v1.0.30 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking rustls-pki-types v1.7.0 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Compiling syn v2.0.66 [INFO] [stderr] Checking rustls-pemfile v2.1.2 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking http-body v1.0.0 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking ipnet v2.9.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking http-body-util v0.1.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking clap_builder v4.5.6 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking listenfd v1.0.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking num-format v0.4.4 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap v4.5.6 [INFO] [stderr] Checking hyper v1.3.1 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-socks v0.5.1 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking async-compression v0.4.11 [INFO] [stderr] Checking hyper-util v0.1.5 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking reqwest v0.12.4 [INFO] [stderr] Checking r-tftpd-proxy v0.1.0 [INFO] [stderr] Checking r-tftpd v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 216 | async fn tokio_main(env: Environment, info: Either) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | run(env, info).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/udpsocket.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 20 | fn unwrap_opt(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | self.ok_or(Error::Internal("Option is None")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/udpsocket.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn from_raw(fd: OwnedFd) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 260 | | fd: AsyncFd::new(fd)?, [INFO] [stdout] 261 | | af: addr.get_af(), [INFO] [stdout] 262 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r-tftpd` (bin "r-tftpd") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `2` is never read [INFO] [stdout] --> src/test.rs:41:43 [INFO] [stdout] | [INFO] [stdout] 41 | TestProxy(&'static str, &'static str, &'static str), [INFO] [stdout] | --------- field in this variant ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FileSpec` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 41 | TestProxy(&'static str, &'static str, ()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:217:20 [INFO] [stdout] | [INFO] [stdout] 216 | async fn tokio_main(env: Environment, info: Either) -> Result<()> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | run(env, info).await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/udpsocket.rs:21:20 [INFO] [stdout] | [INFO] [stdout] 20 | fn unwrap_opt(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | self.ok_or(Error::Internal("Option is None")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/udpsocket.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn from_raw(fd: OwnedFd) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 259 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 260 | | fd: AsyncFd::new(fd)?, [INFO] [stdout] 261 | | af: addr.get_af(), [INFO] [stdout] 262 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test/httpd.rs:136:15 [INFO] [stdout] | [INFO] [stdout] 88 | let sock = std::net::TcpListener::bind(addr).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let tmpdir = TempDir::new().unwrap(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let mut proc = Command::new("/bin/sh"); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let child = proc.spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | process: Some(child), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `r-tftpd` (bin "r-tftpd" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f85dd91b58188754150e27f8363d5d0f74edba9eabbdab42440b0edb907bde89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f85dd91b58188754150e27f8363d5d0f74edba9eabbdab42440b0edb907bde89", kill_on_drop: false }` [INFO] [stdout] f85dd91b58188754150e27f8363d5d0f74edba9eabbdab42440b0edb907bde89