[INFO] fetching crate quocktail 0.1.6... [INFO] checking quocktail-0.1.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate quocktail 0.1.6 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate quocktail 0.1.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate quocktail 0.1.6 [INFO] finished tweaking crates.io crate quocktail 0.1.6 [INFO] tweaked toml for crates.io crate quocktail 0.1.6 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate quocktail 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f78bd4017a121557cd91672dc7664b879c8ce47236741a88ce36ecda9ed27d9d [INFO] running `Command { std: "docker" "start" "-a" "f78bd4017a121557cd91672dc7664b879c8ce47236741a88ce36ecda9ed27d9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f78bd4017a121557cd91672dc7664b879c8ce47236741a88ce36ecda9ed27d9d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f78bd4017a121557cd91672dc7664b879c8ce47236741a88ce36ecda9ed27d9d", kill_on_drop: false }` [INFO] [stdout] f78bd4017a121557cd91672dc7664b879c8ce47236741a88ce36ecda9ed27d9d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] af9cc56cd04c2e2d3ad7e64265689436b18a33ffb84f62e385768a9e45a1c211 [INFO] running `Command { std: "docker" "start" "-a" "af9cc56cd04c2e2d3ad7e64265689436b18a33ffb84f62e385768a9e45a1c211", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking thread_local v1.1.7 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking gimli v0.28.1 [INFO] [stderr] Compiling eyre v0.6.12 [INFO] [stderr] Checking miniz_oxide v0.7.2 [INFO] [stderr] Checking indenter v0.3.3 [INFO] [stderr] Checking strsim v0.11.0 [INFO] [stderr] Compiling pulldown-cmark v0.10.0 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Compiling camino v1.1.6 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking anstream v0.6.12 [INFO] [stderr] Checking convert_case v0.6.0 [INFO] [stderr] Checking walkdir v2.4.0 [INFO] [stderr] Checking supports-color v3.0.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking object v0.32.2 [INFO] [stderr] Checking enable-ansi-support v0.2.1 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking clap_builder v4.5.1 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling syn v2.0.49 [INFO] [stderr] Checking is-terminal v0.4.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking supports-color v2.1.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking owo-colors v4.0.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Compiling backtrace v0.3.69 [INFO] [stderr] Checking color-spantrace v0.2.1 [INFO] [stderr] Checking addr2line v0.21.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Compiling clap_derive v4.5.0 [INFO] [stderr] Checking clap v4.5.1 [INFO] [stderr] Checking quocktail v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|(k, v)| (Yaml::String(k), v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 52 | fn new(str: CowStr<'_>) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let mut frontmatter_vec = match YamlLoader::load_from_str(&str) { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(yaml) => yaml, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let first_item = frontmatter_vec.pop()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let hash = first_item.into_hash()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | Some(Ingredients { hash }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:233:14 [INFO] [stdout] | [INFO] [stdout] 184 | let parser = Parser::new_ext(input, *PARSER_OPTIONS); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let mut iterator = TextMergeStream::new(parser).peekable(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let ingredients = if let Some(Event::Text(str)) = iterator.next() { [INFO] [stdout] | ----------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | let ingredients = Ingredients::new(str)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Some(Recipe { [INFO] [stdout] | ______________^ [INFO] [stdout] 234 | | name, [INFO] [stdout] 235 | | ingredients, [INFO] [stdout] 236 | | instructions, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quocktail` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:14:28 [INFO] [stdout] | [INFO] [stdout] 14 | .map(|(k, v)| (Yaml::String(k), v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:64:14 [INFO] [stdout] | [INFO] [stdout] 52 | fn new(str: CowStr<'_>) -> Option { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | let mut frontmatter_vec = match YamlLoader::load_from_str(&str) { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(yaml) => yaml, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | let first_item = frontmatter_vec.pop()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | let hash = first_item.into_hash()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | [INFO] [stdout] 64 | Some(Ingredients { hash }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parse.rs:233:14 [INFO] [stdout] | [INFO] [stdout] 184 | let parser = Parser::new_ext(input, *PARSER_OPTIONS); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 185 | [INFO] [stdout] 186 | let mut iterator = TextMergeStream::new(parser).peekable(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 197 | let ingredients = if let Some(Event::Text(str)) = iterator.next() { [INFO] [stdout] | ----------- --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | let ingredients = Ingredients::new(str)?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Some(Recipe { [INFO] [stdout] | ______________^ [INFO] [stdout] 234 | | name, [INFO] [stdout] 235 | | ingredients, [INFO] [stdout] 236 | | instructions, [INFO] [stdout] 237 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quocktail` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "af9cc56cd04c2e2d3ad7e64265689436b18a33ffb84f62e385768a9e45a1c211", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "af9cc56cd04c2e2d3ad7e64265689436b18a33ffb84f62e385768a9e45a1c211", kill_on_drop: false }` [INFO] [stdout] af9cc56cd04c2e2d3ad7e64265689436b18a33ffb84f62e385768a9e45a1c211