[INFO] fetching crate quing 2.2.1... [INFO] checking quing-2.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate quing 2.2.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate quing 2.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate quing 2.2.1 [INFO] finished tweaking crates.io crate quing 2.2.1 [INFO] tweaked toml for crates.io crate quing 2.2.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate quing 2.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2f30073f33a981fa017087b335ef0baa35d93f0dc9813883e3984e22b3addc0f [INFO] running `Command { std: "docker" "start" "-a" "2f30073f33a981fa017087b335ef0baa35d93f0dc9813883e3984e22b3addc0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2f30073f33a981fa017087b335ef0baa35d93f0dc9813883e3984e22b3addc0f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2f30073f33a981fa017087b335ef0baa35d93f0dc9813883e3984e22b3addc0f", kill_on_drop: false }` [INFO] [stdout] 2f30073f33a981fa017087b335ef0baa35d93f0dc9813883e3984e22b3addc0f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a245903a1895ab2be100c00ae2427ce2dd641f695925123f72f38da862c84b6d [INFO] running `Command { std: "docker" "start" "-a" "a245903a1895ab2be100c00ae2427ce2dd641f695925123f72f38da862c84b6d", kill_on_drop: false }` [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking alsa v0.9.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fastrand v2.1.0 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking cpal v0.15.3 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking rodio v0.19.0 [INFO] [stderr] Checking serde v1.0.204 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking quing v2.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/in_out.rs:176:6 [INFO] [stdout] | [INFO] [stdout] 133 | let sound_out = rodio::OutputStream::try_default()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | let (signal_sender, signal_receiver) = channel::unbounded(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let (exit_notifier, exit_receiver) = channel::unbounded(); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let key_handler = move || // NOTE(by: @OST-Gh): Pray to god that the caller actually joins the thread... [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let control_thread = Builder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let controls = Controls { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let playback = Sink::try_new(&sound_out.1)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | sound_out, [INFO] [stdout] 178 | | controls, [INFO] [stdout] 179 | | playback, [INFO] [stdout] 180 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:103:6 [INFO] [stdout] | [INFO] [stdout] 82 | iterator: impl IntoIterator, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result, Error> { [INFO] [stdout] 84 | let mut rest = Vec::with_capacity(8); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut outliers = SerDePlaylist { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(rest.into_iter() [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | .filter(|list| !list.is_empty()) [INFO] [stdout] 105 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:130:6 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn flatten(lists: Vec) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let tracks: Vec = lists [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | vary: Some(shuffle), [INFO] [stdout] 132 | | song: tracks, [INFO] [stdout] 133 | | time: Some(repeats), [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playback.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 313 | fn try_from(SerDePlaylist { song, time, vary }: SerDePlaylist) -> Result { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | match song [INFO] [stdout] | _______________^ [INFO] [stdout] 330 | | .into_iter() [INFO] [stdout] 331 | | .enumerate() [INFO] [stdout] 332 | | .map(|(index, track)| Ok((index, track.try_into()?))) [INFO] [stdout] 333 | | .collect::, Error>>() [INFO] [stdout] 334 | | .map(f) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/in_out.rs:176:6 [INFO] [stdout] | [INFO] [stdout] 133 | let sound_out = rodio::OutputStream::try_default()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | [INFO] [stdout] 135 | let (signal_sender, signal_receiver) = channel::unbounded(); [INFO] [stdout] | ------------- --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 136 | let (exit_notifier, exit_receiver) = channel::unbounded(); [INFO] [stdout] | ------------- ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 137 | let key_handler = move || // NOTE(by: @OST-Gh): Pray to god that the caller actually joins the thread... [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let control_thread = Builder::new() [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 167 | let controls = Controls { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 173 | let playback = Sink::try_new(&sound_out.1)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | sound_out, [INFO] [stdout] 178 | | controls, [INFO] [stdout] 179 | | playback, [INFO] [stdout] 180 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:103:6 [INFO] [stdout] | [INFO] [stdout] 82 | iterator: impl IntoIterator, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 83 | ) -> Result, Error> { [INFO] [stdout] 84 | let mut rest = Vec::with_capacity(8); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let mut outliers = SerDePlaylist { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Ok(rest.into_iter() [INFO] [stdout] | ____________^ [INFO] [stdout] 104 | | .filter(|list| !list.is_empty()) [INFO] [stdout] 105 | | .collect()) [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde.rs:130:6 [INFO] [stdout] | [INFO] [stdout] 112 | pub fn flatten(lists: Vec) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | let tracks: Vec = lists [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 130 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 131 | | vary: Some(shuffle), [INFO] [stdout] 132 | | song: tracks, [INFO] [stdout] 133 | | time: Some(repeats), [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/playback.rs:329:9 [INFO] [stdout] | [INFO] [stdout] 313 | fn try_from(SerDePlaylist { song, time, vary }: SerDePlaylist) -> Result { [INFO] [stdout] | ------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 329 | match song [INFO] [stdout] | _______________^ [INFO] [stdout] 330 | | .into_iter() [INFO] [stdout] 331 | | .enumerate() [INFO] [stdout] 332 | | .map(|(index, track)| Ok((index, track.try_into()?))) [INFO] [stdout] 333 | | .collect::, Error>>() [INFO] [stdout] 334 | | .map(f) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quing` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quing` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "a245903a1895ab2be100c00ae2427ce2dd641f695925123f72f38da862c84b6d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a245903a1895ab2be100c00ae2427ce2dd641f695925123f72f38da862c84b6d", kill_on_drop: false }` [INFO] [stdout] a245903a1895ab2be100c00ae2427ce2dd641f695925123f72f38da862c84b6d