[INFO] fetching crate quest_bind 0.3.7... [INFO] checking quest_bind-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate quest_bind 0.3.7 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate quest_bind 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate quest_bind 0.3.7 [INFO] finished tweaking crates.io crate quest_bind 0.3.7 [INFO] tweaked toml for crates.io crate quest_bind 0.3.7 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate quest_bind 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a2d19fa68f3c0beffca0b639d684f651cb1c2d9534fe9e87d25c0506ac559911 [INFO] running `Command { std: "docker" "start" "-a" "a2d19fa68f3c0beffca0b639d684f651cb1c2d9534fe9e87d25c0506ac559911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a2d19fa68f3c0beffca0b639d684f651cb1c2d9534fe9e87d25c0506ac559911", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a2d19fa68f3c0beffca0b639d684f651cb1c2d9534fe9e87d25c0506ac559911", kill_on_drop: false }` [INFO] [stdout] a2d19fa68f3c0beffca0b639d684f651cb1c2d9534fe9e87d25c0506ac559911 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f5cb21c7a4290060b85518a666aedeb8a9beb9585301ab4304963987e1a78d98 [INFO] running `Command { std: "docker" "start" "-a" "f5cb21c7a4290060b85518a666aedeb8a9beb9585301ab4304963987e1a78d98", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling num-iter v0.1.43 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.10 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Compiling quest_bind v0.3.7 (/opt/rustwide/workdir) [INFO] [stderr] Checking num v0.4.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn catch_quest_exception(f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | panic::catch_unwind(f).map_err(|e| match e.downcast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:89:46 [INFO] [stdout] | [INFO] [stdout] 89 | panic::catch_unwind(f).map_err(|e| match e.downcast::() { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operators.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 95 | let filename = CString::new(fn_).map_err(QuestError::NulError)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | [INFO] [stdout] 97 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | env, [INFO] [stdout] 99 | | op: catch_quest_exception(|| unsafe { [INFO] [stdout] 100 | | ffi::createDiagonalOpFromPauliHamilFile( [INFO] [stdout] ... | [INFO] [stdout] 104 | | })?, [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/questenv.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mut cstr = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / catch_quest_exception(|| { [INFO] [stdout] 87 | | unsafe { [INFO] [stdout] 88 | | let cstr_ptr = cstr.into_raw(); [INFO] [stdout] 89 | | ffi::getEnvironmentString(self.0, cstr_ptr); [INFO] [stdout] ... | [INFO] [stdout] 93 | | cstr.into_string().map_err(QuestError::IntoStringError) [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/questenv.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 83 | let mut cstr = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | cstr.into_string().map_err(QuestError::IntoStringError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quest_bind` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:89:5 [INFO] [stdout] | [INFO] [stdout] 84 | pub fn catch_quest_exception(f: F) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | panic::catch_unwind(f).map_err(|e| match e.downcast::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:89:46 [INFO] [stdout] | [INFO] [stdout] 89 | panic::catch_unwind(f).map_err(|e| match e.downcast::() { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/operators.rs:97:12 [INFO] [stdout] | [INFO] [stdout] 95 | let filename = CString::new(fn_).map_err(QuestError::NulError)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | [INFO] [stdout] 97 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 98 | | env, [INFO] [stdout] 99 | | op: catch_quest_exception(|| unsafe { [INFO] [stdout] 100 | | ffi::createDiagonalOpFromPauliHamilFile( [INFO] [stdout] ... | [INFO] [stdout] 104 | | })?, [INFO] [stdout] 105 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/questenv.rs:86:9 [INFO] [stdout] | [INFO] [stdout] 83 | let mut cstr = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | / catch_quest_exception(|| { [INFO] [stdout] 87 | | unsafe { [INFO] [stdout] 88 | | let cstr_ptr = cstr.into_raw(); [INFO] [stdout] 89 | | ffi::getEnvironmentString(self.0, cstr_ptr); [INFO] [stdout] ... | [INFO] [stdout] 93 | | cstr.into_string().map_err(QuestError::IntoStringError) [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/questenv.rs:93:13 [INFO] [stdout] | [INFO] [stdout] 83 | let mut cstr = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | cstr.into_string().map_err(QuestError::IntoStringError) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quest_bind` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "f5cb21c7a4290060b85518a666aedeb8a9beb9585301ab4304963987e1a78d98", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5cb21c7a4290060b85518a666aedeb8a9beb9585301ab4304963987e1a78d98", kill_on_drop: false }` [INFO] [stdout] f5cb21c7a4290060b85518a666aedeb8a9beb9585301ab4304963987e1a78d98