[INFO] fetching crate queens-rock 0.1.1... [INFO] checking queens-rock-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate queens-rock 0.1.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate queens-rock 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate queens-rock 0.1.1 [INFO] finished tweaking crates.io crate queens-rock 0.1.1 [INFO] tweaked toml for crates.io crate queens-rock 0.1.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate queens-rock 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d9601bd158b52bd068e7f2dbaf422c754a4bcac2416d0960e55cdb11262084e5 [INFO] running `Command { std: "docker" "start" "-a" "d9601bd158b52bd068e7f2dbaf422c754a4bcac2416d0960e55cdb11262084e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d9601bd158b52bd068e7f2dbaf422c754a4bcac2416d0960e55cdb11262084e5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9601bd158b52bd068e7f2dbaf422c754a4bcac2416d0960e55cdb11262084e5", kill_on_drop: false }` [INFO] [stdout] d9601bd158b52bd068e7f2dbaf422c754a4bcac2416d0960e55cdb11262084e5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f4261da7085c6fd9dd2511bc53762b6ecb6bddfbb605cb98b4cdb902d223fa6 [INFO] running `Command { std: "docker" "start" "-a" "0f4261da7085c6fd9dd2511bc53762b6ecb6bddfbb605cb98b4cdb902d223fa6", kill_on_drop: false }` [INFO] [stderr] Compiling autocfg v0.1.5 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Checking cfg-if v0.1.9 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling arrayvec v0.4.11 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Compiling libc v0.2.61 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling rayon-core v1.5.0 [INFO] [stderr] Checking adler32 v1.0.3 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Compiling num-derive v0.2.5 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking crossbeam-utils v0.6.6 [INFO] [stderr] Checking color_quant v1.0.1 [INFO] [stderr] Checking inflate v0.4.5 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking queens-rock v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking crossbeam-queue v0.1.2 [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/gf256.rs:90:30 [INFO] [stdout] | [INFO] [stdout] 90 | self.exp[((255 + self.log[omega_x] as usize - self.log[sd_x] as usize) % 255)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 90 - self.exp[((255 + self.log[omega_x] as usize - self.log[sd_x] as usize) % 255)]; [INFO] [stdout] 90 + self.exp[(255 + self.log[omega_x] as usize - self.log[sd_x] as usize) % 255]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/gf256.rs:114:39 [INFO] [stdout] | [INFO] [stdout] 114 | *item ^= self.exp[((self.log[c as usize] as usize + i * j) % self.p)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 114 - *item ^= self.exp[((self.log[c as usize] as usize + i * j) % self.p)]; [INFO] [stdout] 114 + *item ^= self.exp[(self.log[c as usize] as usize + i * j) % self.p]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/gf256.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | [((self.log[*v as usize] as usize + log_c as usize) % self.p as usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - [((self.log[*v as usize] as usize + log_c as usize) % self.p as usize)]; [INFO] [stdout] 192 + [(self.log[*v as usize] as usize + log_c as usize) % self.p as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/pixels.rs:209:26 [INFO] [stdout] | [INFO] [stdout] 209 | for i in row[(left..=right)].iter_mut() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - for i in row[(left..=right)].iter_mut() { [INFO] [stdout] 209 + for i in row[left..=right].iter_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking gif v0.10.2 [INFO] [stderr] Compiling num-traits v0.2.8 [INFO] [stderr] Compiling num-integer v0.1.41 [INFO] [stderr] Compiling num-rational v0.2.2 [INFO] [stderr] Compiling num-iter v0.1.39 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stdout] warning: fields `ring` and `stone` are never read [INFO] [stdout] --> src/identify.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Capstone { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 22 | pub ring: Rc>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 23 | pub stone: Rc>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Capstone` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking num_cpus v1.10.1 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling memoffset v0.5.1 [INFO] [stderr] Checking crossbeam-epoch v0.7.2 [INFO] [stderr] Checking png v0.15.0 [INFO] [stderr] Checking crossbeam-deque v0.6.3 [INFO] [stderr] Checking rayon v1.1.0 [INFO] [stderr] Checking jpeg-decoder v0.1.15 [INFO] [stderr] Checking tiff v0.3.1 [INFO] [stderr] Checking image v0.22.1 [INFO] [stdout] warning: fields `error` and `text` are never read [INFO] [stdout] --> examples/scanner.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 10 | struct Code { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 11 | pub error: Option, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | pub text: Option, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Code` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/gf256.rs:90:30 [INFO] [stdout] | [INFO] [stdout] 90 | self.exp[((255 + self.log[omega_x] as usize - self.log[sd_x] as usize) % 255)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 90 - self.exp[((255 + self.log[omega_x] as usize - self.log[sd_x] as usize) % 255)]; [INFO] [stdout] 90 + self.exp[(255 + self.log[omega_x] as usize - self.log[sd_x] as usize) % 255]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/gf256.rs:114:39 [INFO] [stdout] | [INFO] [stdout] 114 | *item ^= self.exp[((self.log[c as usize] as usize + i * j) % self.p)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 114 - *item ^= self.exp[((self.log[c as usize] as usize + i * j) % self.p)]; [INFO] [stdout] 114 + *item ^= self.exp[(self.log[c as usize] as usize + i * j) % self.p]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/gf256.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | [((self.log[*v as usize] as usize + log_c as usize) % self.p as usize)]; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 192 - [((self.log[*v as usize] as usize + log_c as usize) % self.p as usize)]; [INFO] [stdout] 192 + [(self.log[*v as usize] as usize + log_c as usize) % self.p as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around index expression [INFO] [stdout] --> src/pixels.rs:209:26 [INFO] [stdout] | [INFO] [stdout] 209 | for i in row[(left..=right)].iter_mut() { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 209 - for i in row[(left..=right)].iter_mut() { [INFO] [stdout] 209 + for i in row[left..=right].iter_mut() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `ring` and `stone` are never read [INFO] [stdout] --> src/identify.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 21 | pub struct Capstone { [INFO] [stdout] | -------- fields in this struct [INFO] [stdout] 22 | pub ring: Rc>, [INFO] [stdout] | ^^^^ [INFO] [stdout] 23 | pub stone: Rc>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Capstone` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/test_data.rs:16:22 [INFO] [stdout] | [INFO] [stdout] 16 | .map(|i| image::load_from_memory(i).unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `queens-rock` (lib test) due to 2 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0f4261da7085c6fd9dd2511bc53762b6ecb6bddfbb605cb98b4cdb902d223fa6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f4261da7085c6fd9dd2511bc53762b6ecb6bddfbb605cb98b4cdb902d223fa6", kill_on_drop: false }` [INFO] [stdout] 0f4261da7085c6fd9dd2511bc53762b6ecb6bddfbb605cb98b4cdb902d223fa6