[INFO] fetching crate quanta 0.12.3... [INFO] checking quanta-0.12.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate quanta 0.12.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate quanta 0.12.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate quanta 0.12.3 [INFO] finished tweaking crates.io crate quanta 0.12.3 [INFO] tweaked toml for crates.io crate quanta 0.12.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding average v0.14.2 (latest: v0.15.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cast v0.2.7 (latest: v0.3.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.3 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.9.0 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding plotters v0.2.15 (latest: v0.3.6) [INFO] [stderr] Adding prost v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-types v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 97294efc797d5e4e54d7c49e87a73552dc3155b67ac8507cd4317ff3010b5f87 [INFO] running `Command { std: "docker" "start" "-a" "97294efc797d5e4e54d7c49e87a73552dc3155b67ac8507cd4317ff3010b5f87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "97294efc797d5e4e54d7c49e87a73552dc3155b67ac8507cd4317ff3010b5f87", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "97294efc797d5e4e54d7c49e87a73552dc3155b67ac8507cd4317ff3010b5f87", kill_on_drop: false }` [INFO] [stdout] 97294efc797d5e4e54d7c49e87a73552dc3155b67ac8507cd4317ff3010b5f87 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f496ef4d43d7c68e7f0146279db0c4a6bad318746e4e5378c405cc4e365dd9b [INFO] running `Command { std: "docker" "start" "-a" "4f496ef4d43d7c68e7f0146279db0c4a6bad318746e4e5378c405cc4e365dd9b", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling cast v0.2.7 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking easy-cast v0.5.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking raw-cpuid v11.1.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking float-ord v0.3.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking average v0.14.2 [INFO] [stderr] Checking quanta v0.12.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:489:25 [INFO] [stdout] | [INFO] [stdout] 488 | pub fn with_clock(clock: &Clock, f: impl FnOnce() -> T) -> T { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 489 | CLOCK_OVERRIDE.with(|current| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 490 | | let old = current.replace(Some(clock.clone())); [INFO] [stdout] 491 | | let result = f(); [INFO] [stdout] 492 | | current.replace(old); [INFO] [stdout] 493 | | result [INFO] [stdout] 494 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:509:56 [INFO] [stdout] | [INFO] [stdout] 509 | if let Some(instant) = CLOCK_OVERRIDE.with(|clock| clock.borrow().as_ref().map(Clock::now)) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/upkeep.rs:151:12 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn start(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | let clock = self.clock; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | let done = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 129 | let their_done = done.clone(); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 130 | [INFO] [stdout] 131 | let result = thread::Builder::new() [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 149 | let handle = result?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 150 | [INFO] [stdout] 151 | Ok(Handle { [INFO] [stdout] | ____________^ [INFO] [stdout] 152 | | done, [INFO] [stdout] 153 | | handle: Some(handle), [INFO] [stdout] 154 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quanta` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4f496ef4d43d7c68e7f0146279db0c4a6bad318746e4e5378c405cc4e365dd9b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f496ef4d43d7c68e7f0146279db0c4a6bad318746e4e5378c405cc4e365dd9b", kill_on_drop: false }` [INFO] [stdout] 4f496ef4d43d7c68e7f0146279db0c4a6bad318746e4e5378c405cc4e365dd9b