[INFO] fetching crate quackdb-internal 0.5.0... [INFO] checking quackdb-internal-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate quackdb-internal 0.5.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate quackdb-internal 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate quackdb-internal 0.5.0 [INFO] finished tweaking crates.io crate quackdb-internal 0.5.0 [INFO] tweaked toml for crates.io crate quackdb-internal 0.5.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 120 packages to latest compatible versions [INFO] [stderr] Adding arrow v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-arith v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-array v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-buffer v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-cast v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-csv v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-data v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ipc v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-json v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-ord v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-row v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-schema v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-select v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding arrow-string v48.0.1 (latest: v52.2.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding flatbuffers v23.5.26 (latest: v24.3.25) [INFO] [stderr] Adding heck v0.4.1 (latest: v0.5.0) [INFO] [stderr] Adding libduckdb-sys v0.9.2 (latest: v1.0.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding strum v0.25.0 (latest: v0.26.3) [INFO] [stderr] Adding strum_macros v0.25.3 (latest: v0.26.4) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1a167c62b655d57b751866b04f386e45f40ff51e5c3ec9978cc0a7775a9a7167 [INFO] running `Command { std: "docker" "start" "-a" "1a167c62b655d57b751866b04f386e45f40ff51e5c3ec9978cc0a7775a9a7167", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1a167c62b655d57b751866b04f386e45f40ff51e5c3ec9978cc0a7775a9a7167", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1a167c62b655d57b751866b04f386e45f40ff51e5c3ec9978cc0a7775a9a7167", kill_on_drop: false }` [INFO] [stdout] 1a167c62b655d57b751866b04f386e45f40ff51e5c3ec9978cc0a7775a9a7167 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 281e94eee39729874b945ea8576385ae7e6023f8d415fdc9dde673e6d0582aa9 [INFO] running `Command { std: "docker" "start" "-a" "281e94eee39729874b945ea8576385ae7e6023f8d415fdc9dde673e6d0582aa9", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling adler2 v2.0.0 [INFO] [stderr] Checking lexical-util v0.8.5 [INFO] [stderr] Compiling miniz_oxide v0.8.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking arrow-schema v48.0.1 [INFO] [stderr] Compiling crc32fast v1.4.2 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling flatbuffers v23.5.26 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking lexical-parse-integer v0.8.6 [INFO] [stderr] Checking lexical-write-integer v0.8.5 [INFO] [stderr] Checking lexical-write-float v0.8.5 [INFO] [stderr] Compiling flate2 v1.0.33 [INFO] [stderr] Checking lexical-parse-float v0.8.5 [INFO] [stderr] Compiling filetime v0.2.25 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking lexical-core v0.8.5 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Compiling xattr v1.3.1 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Compiling tar v0.4.41 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Checking arrow-buffer v48.0.1 [INFO] [stderr] Compiling libduckdb-sys v0.9.2 [INFO] [stderr] Checking arrow-data v48.0.1 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking arrow-array v48.0.1 [INFO] [stderr] Checking arrow-select v48.0.1 [INFO] [stderr] Checking arrow-arith v48.0.1 [INFO] [stderr] Checking arrow-row v48.0.1 [INFO] [stderr] Checking arrow-cast v48.0.1 [INFO] [stderr] Checking arrow-ord v48.0.1 [INFO] [stderr] Checking arrow-string v48.0.1 [INFO] [stderr] Checking arrow-json v48.0.1 [INFO] [stderr] Checking arrow-ipc v48.0.1 [INFO] [stderr] Checking arrow-csv v48.0.1 [INFO] [stderr] Checking arrow v48.0.1 [INFO] [stderr] Checking quackdb-internal v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `primitive::*` [INFO] [stdout] --> src/conversion/to_duckdb/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub use primitive::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::*` [INFO] [stdout] --> src/conversion/to_duckdb/mod.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use chrono::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `primitive::*` [INFO] [stdout] --> src/conversion/to_duckdb/mod.rs:2:9 [INFO] [stdout] | [INFO] [stdout] 2 | pub use primitive::*; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `chrono::*` [INFO] [stdout] --> src/conversion/to_duckdb/mod.rs:6:9 [INFO] [stdout] | [INFO] [stdout] 6 | pub use chrono::*; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp_micros`: use `.and_utc().timestamp_micros()` instead [INFO] [stdout] --> src/conversion/to_duckdb/chrono.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 62 | micros: self.timestamp_micros(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_micros`: use `DateTime::from_timestamp_micros` instead [INFO] [stdout] --> src/conversion/to_duckdb/chrono.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 68 | Self::from_timestamp_micros(value.micros).expect("from duckdb_timestamp") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `chrono::NaiveDateTime::timestamp_micros`: use `.and_utc().timestamp_micros()` instead [INFO] [stdout] --> src/conversion/to_duckdb/chrono.rs:62:26 [INFO] [stdout] | [INFO] [stdout] 62 | micros: self.timestamp_micros(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated associated function `chrono::NaiveDateTime::from_timestamp_micros`: use `DateTime::from_timestamp_micros` instead [INFO] [stdout] --> src/conversion/to_duckdb/chrono.rs:68:15 [INFO] [stdout] | [INFO] [stdout] 68 | Self::from_timestamp_micros(value.micros).expect("from duckdb_timestamp") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/arrow.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 24 | connection: Arc, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | _parent: ArrowResultParent::Connection(connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/arrow.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 35 | statement: Arc, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | _parent: ArrowResultParent::Statement(statement), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/connection.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 22 | pub unsafe fn from_raw(raw: ffi::duckdb_connection, parent: Arc) -> Arc { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 24 | | raw, [INFO] [stdout] 25 | | _parent: parent, [INFO] [stdout] 26 | | table_functions: Mutex::new(vec![]), [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/statement.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 34 | parent: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ) -> Arc { [INFO] [stdout] 36 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 37 | | raw, [INFO] [stdout] 38 | | _parent: parent, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quackdb-internal` (lib) due to 5 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/arrow.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 24 | connection: Arc, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | _parent: ArrowResultParent::Connection(connection), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/arrow.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 35 | statement: Arc, [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | _parent: ArrowResultParent::Statement(statement), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/connection.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 22 | pub unsafe fn from_raw(raw: ffi::duckdb_connection, parent: Arc) -> Arc { [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 24 | | raw, [INFO] [stdout] 25 | | _parent: parent, [INFO] [stdout] 26 | | table_functions: Mutex::new(vec![]), [INFO] [stdout] 27 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/handles/statement.rs:36:18 [INFO] [stdout] | [INFO] [stdout] 34 | parent: Arc, [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | ) -> Arc { [INFO] [stdout] 36 | Arc::new(Self { [INFO] [stdout] | __________________^ [INFO] [stdout] 37 | | raw, [INFO] [stdout] 38 | | _parent: parent, [INFO] [stdout] 39 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `quackdb-internal` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "281e94eee39729874b945ea8576385ae7e6023f8d415fdc9dde673e6d0582aa9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "281e94eee39729874b945ea8576385ae7e6023f8d415fdc9dde673e6d0582aa9", kill_on_drop: false }` [INFO] [stdout] 281e94eee39729874b945ea8576385ae7e6023f8d415fdc9dde673e6d0582aa9