[INFO] fetching crate qsv-sniffer 0.10.3... [INFO] checking qsv-sniffer-0.10.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate qsv-sniffer 0.10.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate qsv-sniffer 0.10.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate qsv-sniffer 0.10.3 [INFO] finished tweaking crates.io crate qsv-sniffer 0.10.3 [INFO] tweaked toml for crates.io crate qsv-sniffer 0.10.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate qsv-sniffer 0.10.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b808fd545c09b04f9a1d258747ef71363e31b2384ddb4c85c233da84f54724b6 [INFO] running `Command { std: "docker" "start" "-a" "b808fd545c09b04f9a1d258747ef71363e31b2384ddb4c85c233da84f54724b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b808fd545c09b04f9a1d258747ef71363e31b2384ddb4c85c233da84f54724b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b808fd545c09b04f9a1d258747ef71363e31b2384ddb4c85c233da84f54724b6", kill_on_drop: false }` [INFO] [stdout] b808fd545c09b04f9a1d258747ef71363e31b2384ddb4c85c233da84f54724b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 462ea2ae00bc6c40899c4c5bd67097388a136240f2525f23e78648f3a5449598 [INFO] running `Command { std: "docker" "start" "-a" "462ea2ae00bc6c40899c4c5bd67097388a136240f2525f23e78648f3a5449598", kill_on_drop: false }` [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling anyhow v1.0.80 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking simdutf8 v0.1.4 [INFO] [stderr] Checking tabwriter v1.4.0 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking bytecount v0.6.7 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking chrono v0.4.34 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking qsv-dateparser v0.12.0 [INFO] [stderr] Checking qsv-sniffer v0.10.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn open_path>(&self, path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | self.open_reader(File::open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn open_reader(&self, mut rdr: R) -> Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | snip_preamble(&mut rdr, self.header.num_preamble_rows)?; [INFO] [stdout] 134 | let bldr: ReaderBuilder = self.clone().into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(bldr.from_reader(rdr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sniffer.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn open_path>(&mut self, path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | self.open_reader(File::open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sniffer.rs:143:50 [INFO] [stdout] | [INFO] [stdout] 143 | self.is_utf8 = Some(IS_UTF8.with(|flag| *flag.borrow())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sniffer.rs:494:12 [INFO] [stdout] | [INFO] [stdout] 473 | let mut builder = csv::ReaderBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | Ok(builder.from_reader(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sample.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 57 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Some(Ok(output)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field_type.rs:102:48 [INFO] [stdout] | [INFO] [stdout] 102 | DATE_PREFERENCE.with(|preference| *preference.borrow()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `qsv-sniffer` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:127:26 [INFO] [stdout] | [INFO] [stdout] 126 | pub fn open_path>(&self, path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 127 | self.open_reader(File::open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/metadata.rs:135:12 [INFO] [stdout] | [INFO] [stdout] 132 | pub fn open_reader(&self, mut rdr: R) -> Result> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | snip_preamble(&mut rdr, self.header.num_preamble_rows)?; [INFO] [stdout] 134 | let bldr: ReaderBuilder = self.clone().into(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 135 | Ok(bldr.from_reader(rdr)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sniffer.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 101 | pub fn open_path>(&mut self, path: P) -> Result> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | self.open_reader(File::open(path)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sniffer.rs:143:50 [INFO] [stdout] | [INFO] [stdout] 143 | self.is_utf8 = Some(IS_UTF8.with(|flag| *flag.borrow())); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sniffer.rs:494:12 [INFO] [stdout] | [INFO] [stdout] 473 | let mut builder = csv::ReaderBuilder::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 494 | Ok(builder.from_reader(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sample.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 57 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | Some(Ok(output)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/field_type.rs:102:48 [INFO] [stdout] | [INFO] [stdout] 102 | DATE_PREFERENCE.with(|preference| *preference.borrow()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `qsv-sniffer` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "462ea2ae00bc6c40899c4c5bd67097388a136240f2525f23e78648f3a5449598", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "462ea2ae00bc6c40899c4c5bd67097388a136240f2525f23e78648f3a5449598", kill_on_drop: false }` [INFO] [stdout] 462ea2ae00bc6c40899c4c5bd67097388a136240f2525f23e78648f3a5449598