[INFO] fetching crate python-packaging 0.16.0... [INFO] checking python-packaging-0.16.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate python-packaging 0.16.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate python-packaging 0.16.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate python-packaging 0.16.0 [INFO] finished tweaking crates.io crate python-packaging 0.16.0 [INFO] tweaked toml for crates.io crate python-packaging 0.16.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding base64 v0.20.0 (latest: v0.22.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mailparse v0.14.1 (latest: v0.15.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6d72f15f73e9e148eeff49ab85b7323ccbf423fc117715c810fcc1260711d3ac [INFO] running `Command { std: "docker" "start" "-a" "6d72f15f73e9e148eeff49ab85b7323ccbf423fc117715c810fcc1260711d3ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6d72f15f73e9e148eeff49ab85b7323ccbf423fc117715c810fcc1260711d3ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d72f15f73e9e148eeff49ab85b7323ccbf423fc117715c810fcc1260711d3ac", kill_on_drop: false }` [INFO] [stdout] 6d72f15f73e9e148eeff49ab85b7323ccbf423fc117715c810fcc1260711d3ac [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 036e13076a8b5bfd72bf2f27233f258765b977abb385972f703d31f79db846d8 [INFO] running `Command { std: "docker" "start" "-a" "036e13076a8b5bfd72bf2f27233f258765b977abb385972f703d31f79db846d8", kill_on_drop: false }` [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking quoted_printable v0.5.1 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking spdx v0.10.6 [INFO] [stderr] Checking simple-file-manifest v0.11.0 [INFO] [stderr] Checking base64 v0.20.0 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking python-packed-resources v0.12.0 [INFO] [stderr] Checking charset v0.1.5 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking mailparse v0.14.1 [INFO] [stderr] Checking python-packaging v0.16.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bytecode.rs:115:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn new(python: &Path, script_dir: impl AsRef) -> Result { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | let mut command = process::Command::new(python) [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | Ok(BytecodeCompiler { [INFO] [stdout] | ____________^ [INFO] [stdout] 116 | | command, [INFO] [stdout] 117 | | magic_number, [INFO] [stdout] 118 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/filesystem_scanning.rs:140:12 [INFO] [stdout] | [INFO] [stdout] 116 | let res = walkdir::WalkDir::new(path).sort_by(|a, b| a.file_name().cmp(b.file_name())); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(PythonResourceIterator { [INFO] [stdout] | ____________^ [INFO] [stdout] 141 | | root_path: path.to_path_buf(), [INFO] [stdout] 142 | | cache_tag: cache_tag.to_string(), [INFO] [stdout] 143 | | suffixes: suffixes.clone(), [INFO] [stdout] ... | [INFO] [stdout] 150 | | _phantom: std::marker::PhantomData, [INFO] [stdout] 151 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/licensing.rs:260:12 [INFO] [stdout] | [INFO] [stdout] 252 | let spdx_expression = Expression::parse(spdx_expression).map_err(|e| anyhow!("{}", e))?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 253 | [INFO] [stdout] 254 | let license = if spdx_expression.evaluate(|req| req.license.id().is_some()) { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 260 | Ok(Self::new(flavor, license)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/licensing.rs:606:41 [INFO] [stdout] | [INFO] [stdout] 606 | .filter(|c| c.license() == &LicenseFlavor::None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/licensing.rs:613:41 [INFO] [stdout] | [INFO] [stdout] 613 | .filter(|c| c.license() == &LicenseFlavor::PublicDomain) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:718:25 [INFO] [stdout] | [INFO] [stdout] 716 | fn from_iter>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 717 | Self { [INFO] [stdout] 718 | extensions: Vec::from_iter(iter), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/resource.rs:945:41 [INFO] [stdout] | [INFO] [stdout] 944 | fn from(r: PythonExtensionModule) -> Self { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 945 | PythonResource::ExtensionModule(Cow::Owned(r)) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wheel_builder.rs:25:18 [INFO] [stdout] | [INFO] [stdout] 25 | Lazy::new(|| regex::Regex::new(r"[^\w\d.]+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wheel_builder.rs:412:22 [INFO] [stdout] | [INFO] [stdout] 412 | .map(|x| RE_FILENAME_ESCAPE.replace_all(x, "_")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `python-packaging` (lib) due to 10 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "036e13076a8b5bfd72bf2f27233f258765b977abb385972f703d31f79db846d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "036e13076a8b5bfd72bf2f27233f258765b977abb385972f703d31f79db846d8", kill_on_drop: false }` [INFO] [stdout] 036e13076a8b5bfd72bf2f27233f258765b977abb385972f703d31f79db846d8