[INFO] fetching crate pyotr 0.1.0... [INFO] checking pyotr-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pyotr 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pyotr 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pyotr 0.1.0 [INFO] finished tweaking crates.io crate pyotr 0.1.0 [INFO] tweaked toml for crates.io crate pyotr 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate pyotr 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7c356314466951a4b14c76233a46715e35c19fbe839a565cc7b9208a72314f89 [INFO] running `Command { std: "docker" "start" "-a" "7c356314466951a4b14c76233a46715e35c19fbe839a565cc7b9208a72314f89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7c356314466951a4b14c76233a46715e35c19fbe839a565cc7b9208a72314f89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7c356314466951a4b14c76233a46715e35c19fbe839a565cc7b9208a72314f89", kill_on_drop: false }` [INFO] [stdout] 7c356314466951a4b14c76233a46715e35c19fbe839a565cc7b9208a72314f89 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b169a1cbe55f76d3a7f59e68496d39471b2f185b4f984e8a7de51b4711e48fa4 [INFO] running `Command { std: "docker" "start" "-a" "b169a1cbe55f76d3a7f59e68496d39471b2f185b4f984e8a7de51b4711e48fa4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling rustix v0.38.4 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Checking bitflags v2.3.3 [INFO] [stderr] Checking linux-raw-sys v0.4.3 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Compiling cc v1.0.79 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Compiling signal-hook v0.3.16 [INFO] [stderr] Checking smallvec v1.10.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking lock_api v0.4.10 [INFO] [stderr] Checking tracing-subscriber v0.3.17 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking parking_lot_core v0.9.8 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Compiling eyre v0.6.8 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling portable-atomic v1.4.2 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Checking gimli v0.27.3 [INFO] [stderr] Checking tracing-error v0.2.0 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Checking miniz_oxide v0.7.1 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking object v0.31.1 [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Compiling async-trait v0.1.71 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking rustc-demangle v0.1.23 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Compiling backtrace v0.3.68 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking owo-colors v3.5.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking clap_builder v4.3.12 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking indicatif v0.17.5 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking color-spantrace v0.2.0 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking addr2line v0.20.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking color-eyre v0.6.2 [INFO] [stderr] Checking clap v4.3.12 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking pyotr v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `path` and `marked_as_fail` are never read [INFO] [stdout] --> src/driver.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct TestResult { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 12 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | pub success: bool, [INFO] [stdout] 14 | pub marked_as_fail: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `status_text` is never used [INFO] [stdout] --> src/driver.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl Test { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn status_text(&self) -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/driver.rs:65:93 [INFO] [stdout] | [INFO] [stdout] 65 | async fn run(&mut self, stdout: Stdio, stderr: Stdio) -> color_eyre::Result { [INFO] [stdout] | _____________________________-------------__-------------____________________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | | let mut process = Command::new("node") [INFO] [stdout] 67 | | .arg("--unhandled-rejections=strict") [INFO] [stdout] 68 | | .arg(self.path.as_os_str()) [INFO] [stdout] ... | [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `path` and `marked_as_fail` are never read [INFO] [stdout] --> src/driver.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct TestResult { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 12 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] 13 | pub success: bool, [INFO] [stdout] 14 | pub marked_as_fail: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TestResult` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `status_text` is never used [INFO] [stdout] --> src/driver.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 39 | impl Test { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 46 | pub fn status_text(&self) -> &'static str { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/driver.rs:65:93 [INFO] [stdout] | [INFO] [stdout] 65 | async fn run(&mut self, stdout: Stdio, stderr: Stdio) -> color_eyre::Result { [INFO] [stdout] | _____________________________-------------__-------------____________________________________^ [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | | let mut process = Command::new("node") [INFO] [stdout] 67 | | .arg("--unhandled-rejections=strict") [INFO] [stdout] 68 | | .arg(self.path.as_os_str()) [INFO] [stdout] ... | [INFO] [stdout] 108 | | } [INFO] [stdout] 109 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyotr` (bin "pyotr") due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyotr` (bin "pyotr" test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b169a1cbe55f76d3a7f59e68496d39471b2f185b4f984e8a7de51b4711e48fa4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b169a1cbe55f76d3a7f59e68496d39471b2f185b4f984e8a7de51b4711e48fa4", kill_on_drop: false }` [INFO] [stdout] b169a1cbe55f76d3a7f59e68496d39471b2f185b4f984e8a7de51b4711e48fa4