[INFO] fetching crate pyo3-testing 0.3.5... [INFO] checking pyo3-testing-0.3.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pyo3-testing 0.3.5 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pyo3-testing 0.3.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pyo3-testing 0.3.5 [INFO] finished tweaking crates.io crate pyo3-testing 0.3.5 [INFO] tweaked toml for crates.io crate pyo3-testing 0.3.5 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3b0f4c6e7d32f63deebcc4c3c851dbb50c95ea6651b68e85e9e4947dae9b114 [INFO] running `Command { std: "docker" "start" "-a" "b3b0f4c6e7d32f63deebcc4c3c851dbb50c95ea6651b68e85e9e4947dae9b114", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3b0f4c6e7d32f63deebcc4c3c851dbb50c95ea6651b68e85e9e4947dae9b114", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3b0f4c6e7d32f63deebcc4c3c851dbb50c95ea6651b68e85e9e4947dae9b114", kill_on_drop: false }` [INFO] [stdout] b3b0f4c6e7d32f63deebcc4c3c851dbb50c95ea6651b68e85e9e4947dae9b114 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9daaeb2a7310c383907c4a93326f6b0a4a68106d57db7b89f8bfa1ab7edf3776 [INFO] running `Command { std: "docker" "start" "-a" "9daaeb2a7310c383907c4a93326f6b0a4a68106d57db7b89f8bfa1ab7edf3776", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Compiling trybuild v1.0.99 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling pyo3-build-config v0.22.2 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking unindent v0.2.3 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling pyo3-ffi v0.22.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.22.2 [INFO] [stderr] Compiling pyo3 v0.22.2 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling pyo3-macros v0.22.2 [INFO] [stderr] Checking pyo3-testing v0.3.5 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn pyo3test(attr: TokenStream1, input: TokenStream1) -> TokenStream1 { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | impl_pyo3test(attr.into(), input.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn with_py_raises(input: TokenStream1) -> TokenStream1 { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | impl_with_py_raises(input.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pyo3test.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 48 | fn try_from(testcase: ItemFn) -> syn::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let mut pyo3imports = Vec::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut otherattributes = Vec::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Pyo3TestCase { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | pyo3imports, [INFO] [stdout] 61 | | signature: testcase.sig, [INFO] [stdout] 62 | | statements: testcase.block.stmts, [INFO] [stdout] 63 | | otherattributes, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pyo3test.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 85 | let o3_moduleident; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(Pyo3Import { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | o3_moduleident, [INFO] [stdout] 104 | | py_modulename, [INFO] [stdout] 105 | | py_functionname, [INFO] [stdout] 106 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/withpyraises.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 48 | let err: Ident = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let block: Block = match input.parse() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(block) => block, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(WithRaisesStmt { err, block }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyo3-testing` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:120:5 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn pyo3test(attr: TokenStream1, input: TokenStream1) -> TokenStream1 { [INFO] [stdout] | ------------------ ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | impl_pyo3test(attr.into(), input.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:5 [INFO] [stdout] | [INFO] [stdout] 158 | pub fn with_py_raises(input: TokenStream1) -> TokenStream1 { [INFO] [stdout] | ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 159 | impl_with_py_raises(input.into()).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pyo3test.rs:59:12 [INFO] [stdout] | [INFO] [stdout] 48 | fn try_from(testcase: ItemFn) -> syn::Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | let mut pyo3imports = Vec::::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let mut otherattributes = Vec::::new(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Ok(Pyo3TestCase { [INFO] [stdout] | ____________^ [INFO] [stdout] 60 | | pyo3imports, [INFO] [stdout] 61 | | signature: testcase.sig, [INFO] [stdout] 62 | | statements: testcase.block.stmts, [INFO] [stdout] 63 | | otherattributes, [INFO] [stdout] 64 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pyo3test.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 85 | let o3_moduleident; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | Ok(Pyo3Import { [INFO] [stdout] | ____________^ [INFO] [stdout] 103 | | o3_moduleident, [INFO] [stdout] 104 | | py_modulename, [INFO] [stdout] 105 | | py_functionname, [INFO] [stdout] 106 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/withpyraises.rs:68:12 [INFO] [stdout] | [INFO] [stdout] 48 | let err: Ident = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 58 | let block: Block = match input.parse() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | Ok(block) => block, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | Ok(WithRaisesStmt { err, block }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/withpyraises.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 94 | let codeblock = parse_quote! { [INFO] [stdout] | _____________---------___- [INFO] [stdout] | |_____________|___________| [INFO] [stdout] | |_____________|___________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | | {addone.call1("4",)} [INFO] [stdout] 96 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | let errortype = parse_quote! { [INFO] [stdout] | _____________---------___- [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 98 | PyTypeError [INFO] [stdout] 99 | | }; [INFO] [stdout] | |_________- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | | let invocation = WithRaisesStmt { [INFO] [stdout] | | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... | [INFO] [stdout] 104 | let expected: TokenStream2 = quote! { [INFO] [stdout] | _____________--------_________________- [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | |_____________|________________________| [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 105 | | match { [INFO] [stdout] 106 | | addone.call1("4",) [INFO] [stdout] 107 | | } { [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | }; [INFO] [stdout] | | - [INFO] [stdout] | |_________| [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | | assert_eq!(expand(invocation).to_string(), expected.to_string()) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyo3-testing` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "9daaeb2a7310c383907c4a93326f6b0a4a68106d57db7b89f8bfa1ab7edf3776", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9daaeb2a7310c383907c4a93326f6b0a4a68106d57db7b89f8bfa1ab7edf3776", kill_on_drop: false }` [INFO] [stdout] 9daaeb2a7310c383907c4a93326f6b0a4a68106d57db7b89f8bfa1ab7edf3776