[INFO] fetching crate pymedusa-zip 0.0.9... [INFO] checking pymedusa-zip-0.0.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pymedusa-zip 0.0.9 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate pymedusa-zip 0.0.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pymedusa-zip 0.0.9 [INFO] finished tweaking crates.io crate pymedusa-zip 0.0.9 [INFO] tweaked toml for crates.io crate pymedusa-zip 0.0.9 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 118 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding num_enum v0.6.1 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.6.1 (latest: v0.7.3) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding pyo3 v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-asyncio v0.19.0 (latest: v0.20.0) [INFO] [stderr] Adding pyo3-build-config v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11ef77d4c0c5663795649bf9e411bd05307e6d856082dbdb48e8aa50b34d307b [INFO] running `Command { std: "docker" "start" "-a" "11ef77d4c0c5663795649bf9e411bd05307e6d856082dbdb48e8aa50b34d307b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11ef77d4c0c5663795649bf9e411bd05307e6d856082dbdb48e8aa50b34d307b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11ef77d4c0c5663795649bf9e411bd05307e6d856082dbdb48e8aa50b34d307b", kill_on_drop: false }` [INFO] [stdout] 11ef77d4c0c5663795649bf9e411bd05307e6d856082dbdb48e8aa50b34d307b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c9a2d6d660e4aea3ca9019b37c2fec8966461ef0fe6b24940019d48b7736a96d [INFO] running `Command { std: "docker" "start" "-a" "c9a2d6d660e4aea3ca9019b37c2fec8966461ef0fe6b24940019d48b7736a96d", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling static_init_macro v1.0.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling static_init v1.0.3 [INFO] [stderr] Compiling pyo3-build-config v0.19.2 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling pyo3-ffi v0.19.2 [INFO] [stderr] Compiling pyo3 v0.19.2 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling pyo3-macros-backend v0.19.2 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling num_enum_derive v0.6.1 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking num_enum v0.6.1 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking zip-merge v0.6.6 [INFO] [stderr] Compiling pyo3-macros v0.19.2 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking libmedusa-zip v0.0.9 [INFO] [stderr] Checking pyo3-asyncio v0.19.0 [INFO] [stderr] Checking pymedusa-zip v0.0.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 176 | let patterns = RegexSet::new(patterns).map_err(|e| PyValueError::new_err(format!("{}", e)))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Ok(Self { patterns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 214 | fn new(paths_to_crawl: &PyAny, ignores: Option) -> PyResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let ignores = ignores.unwrap_or_default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 221 | | paths_to_crawl, [INFO] [stdout] 222 | | ignores, [INFO] [stdout] 223 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:242:45 [INFO] [stdout] | [INFO] [stdout] 241 | let crawl: lib_crawl::MedusaCrawl = self.clone().into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 243 | | let ret: PyResult = crawl [INFO] [stdout] 244 | | .crawl_paths() [INFO] [stdout] 245 | | .await [INFO] [stdout] ... | [INFO] [stdout] 249 | | ret [INFO] [stdout] 250 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 256 | let crawl: lib_crawl::MedusaCrawl = self.clone().into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 258 | | let ret: PyResult = handle.block_on(crawl [INFO] [stdout] 259 | | .crawl_paths()) [INFO] [stdout] 260 | | /* TODO: better error! */ [INFO] [stdout] ... | [INFO] [stdout] 263 | | ret [INFO] [stdout] 264 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 269 | fn from(x: MedusaCrawl) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | ignores, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | ignores: ignores.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 48 | let output_zip_writer: ZipWriter = behavior [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let output_wrapper = lib_destination::OutputWrapper::wrap(output_zip_writer); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(ZipFileWriter { [INFO] [stdout] | __________^ [INFO] [stdout] 55 | | output_path: path, [INFO] [stdout] 56 | | zip_writer: output_wrapper, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 66 | let output_zip_writer: ZipWriter = handle [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let output_wrapper = lib_destination::OutputWrapper::wrap(output_zip_writer); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok::<_, PyErr>(ZipFileWriter { [INFO] [stdout] | ______________________^ [INFO] [stdout] 72 | | output_path: path, [INFO] [stdout] 73 | | zip_writer: output_wrapper, [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:120:45 [INFO] [stdout] | [INFO] [stdout] 118 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | } = self.clone(); [INFO] [stdout] 120 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 121 | | tokio::task::spawn_blocking(move || { [INFO] [stdout] 122 | | let file = zip_writer [INFO] [stdout] 123 | | .clone() [INFO] [stdout] ... | [INFO] [stdout] 133 | | .map_err(|e| PyIOError::new_err(format!("{}", e)))? [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:140:45 [INFO] [stdout] | [INFO] [stdout] 139 | let obj = self.clone().into_py(py); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | pyo3_asyncio::tokio::future_into_py(py, async move { Ok(obj) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:154:45 [INFO] [stdout] | [INFO] [stdout] 151 | let obj = self.clone().into_py(py); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let res = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | pyo3_asyncio::tokio::into_future(obj.call_method0(py, intern!(py, "finish"))?.as_ref(py))?; [INFO] [stdout] 154 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 155 | | let _res = res.await?; [INFO] [stdout] 156 | | Ok(Python::with_gil(|py| { [INFO] [stdout] 157 | | let ret: Py = PyBool::new(py, false).into(); [INFO] [stdout] 158 | | ret [INFO] [stdout] 159 | | })) [INFO] [stdout] 160 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:156:10 [INFO] [stdout] | [INFO] [stdout] 152 | let res = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let _res = res.await?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(Python::with_gil(|py| { [INFO] [stdout] | __________^ [INFO] [stdout] 157 | | let ret: Py = PyBool::new(py, false).into(); [INFO] [stdout] 158 | | ret [INFO] [stdout] 159 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:170:22 [INFO] [stdout] | [INFO] [stdout] 168 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | } = self.clone(); [INFO] [stdout] 170 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 171 | | handle.block_on(async move { [INFO] [stdout] 172 | | handle [INFO] [stdout] 173 | | .spawn_blocking(move || { [INFO] [stdout] ... | [INFO] [stdout] 186 | | }) [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 168 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | handle.block_on(async move { [INFO] [stdout] | _______________________^ [INFO] [stdout] 172 | | handle [INFO] [stdout] 173 | | .spawn_blocking(move || { [INFO] [stdout] 174 | | let file = zip_writer [INFO] [stdout] ... | [INFO] [stdout] 185 | | .map_err(|e| PyIOError::new_err(format!("{}", e)))? [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:134:45 [INFO] [stdout] | [INFO] [stdout] 122 | output_zip: ZipFileWriter, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | } = output_zip; [INFO] [stdout] 134 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 135 | | let zip_writer = merge [INFO] [stdout] 136 | | .merge(mtime_behavior, zip_writer) [INFO] [stdout] 137 | | .await [INFO] [stdout] ... | [INFO] [stdout] 144 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 145 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:166:22 [INFO] [stdout] | [INFO] [stdout] 153 | output_zip: ZipFileWriter, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | } = output_zip; [INFO] [stdout] 166 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 167 | | let zip_writer = handle.block_on(merge.merge(mtime_behavior, zip_writer)) [INFO] [stdout] 168 | | /* TODO: better error! */ [INFO] [stdout] 169 | | .map_err(|e| PyException::new_err(format!("{}", e)))?; [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:177:8 [INFO] [stdout] | [INFO] [stdout] 176 | let patterns = RegexSet::new(patterns).map_err(|e| PyValueError::new_err(format!("{}", e)))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | Ok(Self { patterns }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip.rs:573:45 [INFO] [stdout] | [INFO] [stdout] 567 | fn zip<'a>(&self, py: Python<'a>, output_zip: ZipFileWriter) -> PyResult<&'a PyAny> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 571 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | } = output_zip; [INFO] [stdout] 573 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 574 | | /* TODO: make a wrapper for this packing/unpacking of ZipFileWriter! */ [INFO] [stdout] 575 | | let zip_writer = zip.zip(zip_writer) [INFO] [stdout] 576 | | .await [INFO] [stdout] ... | [INFO] [stdout] 583 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 584 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip.rs:595:22 [INFO] [stdout] | [INFO] [stdout] 588 | fn zip_sync(&self, py: Python, output_zip: ZipFileWriter) -> PyResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 594 | } = output_zip; [INFO] [stdout] 595 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 596 | | let zip_writer = handle.block_on(zip.zip(zip_writer)) [INFO] [stdout] 597 | | /* TODO: better error! */ [INFO] [stdout] 598 | | .map_err(|e| PyException::new_err(format!("{}", e)))?; [INFO] [stdout] ... | [INFO] [stdout] 603 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 604 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:220:8 [INFO] [stdout] | [INFO] [stdout] 214 | fn new(paths_to_crawl: &PyAny, ignores: Option) -> PyResult { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 215 | let ignores = ignores.unwrap_or_default(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | Ok(Self { [INFO] [stdout] | ________^ [INFO] [stdout] 221 | | paths_to_crawl, [INFO] [stdout] 222 | | ignores, [INFO] [stdout] 223 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn repr>>(py: Python<'_>, arg: I) -> PyResult { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | / arg [INFO] [stdout] 17 | | .into_py(py) [INFO] [stdout] 18 | | .call_method0(py, intern!(py, "__repr__"))? [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:242:45 [INFO] [stdout] | [INFO] [stdout] 241 | let crawl: lib_crawl::MedusaCrawl = self.clone().into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 242 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 243 | | let ret: PyResult = crawl [INFO] [stdout] 244 | | .crawl_paths() [INFO] [stdout] 245 | | .await [INFO] [stdout] ... | [INFO] [stdout] 249 | | ret [INFO] [stdout] 250 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:257:22 [INFO] [stdout] | [INFO] [stdout] 256 | let crawl: lib_crawl::MedusaCrawl = self.clone().into(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 257 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 258 | | let ret: PyResult = handle.block_on(crawl [INFO] [stdout] 259 | | .crawl_paths()) [INFO] [stdout] 260 | | /* TODO: better error! */ [INFO] [stdout] ... | [INFO] [stdout] 263 | | ret [INFO] [stdout] 264 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crawl.rs:276:16 [INFO] [stdout] | [INFO] [stdout] 269 | fn from(x: MedusaCrawl) -> Self { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 272 | ignores, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 276 | ignores: ignores.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 48 | let output_zip_writer: ZipWriter = behavior [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | let output_wrapper = lib_destination::OutputWrapper::wrap(output_zip_writer); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 54 | Ok(ZipFileWriter { [INFO] [stdout] | __________^ [INFO] [stdout] 55 | | output_path: path, [INFO] [stdout] 56 | | zip_writer: output_wrapper, [INFO] [stdout] 57 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:71:22 [INFO] [stdout] | [INFO] [stdout] 66 | let output_zip_writer: ZipWriter = handle [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | let output_wrapper = lib_destination::OutputWrapper::wrap(output_zip_writer); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | Ok::<_, PyErr>(ZipFileWriter { [INFO] [stdout] | ______________________^ [INFO] [stdout] 72 | | output_path: path, [INFO] [stdout] 73 | | zip_writer: output_wrapper, [INFO] [stdout] 74 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_______these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:120:45 [INFO] [stdout] | [INFO] [stdout] 118 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | } = self.clone(); [INFO] [stdout] 120 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 121 | | tokio::task::spawn_blocking(move || { [INFO] [stdout] 122 | | let file = zip_writer [INFO] [stdout] 123 | | .clone() [INFO] [stdout] ... | [INFO] [stdout] 133 | | .map_err(|e| PyIOError::new_err(format!("{}", e)))? [INFO] [stdout] 134 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:140:45 [INFO] [stdout] | [INFO] [stdout] 139 | let obj = self.clone().into_py(py); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | pyo3_asyncio::tokio::future_into_py(py, async move { Ok(obj) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:154:45 [INFO] [stdout] | [INFO] [stdout] 151 | let obj = self.clone().into_py(py); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let res = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | pyo3_asyncio::tokio::into_future(obj.call_method0(py, intern!(py, "finish"))?.as_ref(py))?; [INFO] [stdout] 154 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 155 | | let _res = res.await?; [INFO] [stdout] 156 | | Ok(Python::with_gil(|py| { [INFO] [stdout] 157 | | let ret: Py = PyBool::new(py, false).into(); [INFO] [stdout] 158 | | ret [INFO] [stdout] 159 | | })) [INFO] [stdout] 160 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:156:10 [INFO] [stdout] | [INFO] [stdout] 152 | let res = [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 155 | let _res = res.await?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 156 | Ok(Python::with_gil(|py| { [INFO] [stdout] | __________^ [INFO] [stdout] 157 | | let ret: Py = PyBool::new(py, false).into(); [INFO] [stdout] 158 | | ret [INFO] [stdout] 159 | | })) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:170:22 [INFO] [stdout] | [INFO] [stdout] 168 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | } = self.clone(); [INFO] [stdout] 170 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 171 | | handle.block_on(async move { [INFO] [stdout] 172 | | handle [INFO] [stdout] 173 | | .spawn_blocking(move || { [INFO] [stdout] ... | [INFO] [stdout] 186 | | }) [INFO] [stdout] 187 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/destination.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 168 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 171 | handle.block_on(async move { [INFO] [stdout] | _______________________^ [INFO] [stdout] 172 | | handle [INFO] [stdout] 173 | | .spawn_blocking(move || { [INFO] [stdout] 174 | | let file = zip_writer [INFO] [stdout] ... | [INFO] [stdout] 185 | | .map_err(|e| PyIOError::new_err(format!("{}", e)))? [INFO] [stdout] 186 | | }) [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:134:45 [INFO] [stdout] | [INFO] [stdout] 122 | output_zip: ZipFileWriter, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 133 | } = output_zip; [INFO] [stdout] 134 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 135 | | let zip_writer = merge [INFO] [stdout] 136 | | .merge(mtime_behavior, zip_writer) [INFO] [stdout] 137 | | .await [INFO] [stdout] ... | [INFO] [stdout] 144 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 145 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/merge.rs:166:22 [INFO] [stdout] | [INFO] [stdout] 153 | output_zip: ZipFileWriter, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 165 | } = output_zip; [INFO] [stdout] 166 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 167 | | let zip_writer = handle.block_on(merge.merge(mtime_behavior, zip_writer)) [INFO] [stdout] 168 | | /* TODO: better error! */ [INFO] [stdout] 169 | | .map_err(|e| PyException::new_err(format!("{}", e)))?; [INFO] [stdout] ... | [INFO] [stdout] 174 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 175 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip.rs:573:45 [INFO] [stdout] | [INFO] [stdout] 567 | fn zip<'a>(&self, py: Python<'a>, output_zip: ZipFileWriter) -> PyResult<&'a PyAny> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 571 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 572 | } = output_zip; [INFO] [stdout] 573 | pyo3_asyncio::tokio::future_into_py(py, async move { [INFO] [stdout] | _____________________________________________^ [INFO] [stdout] 574 | | /* TODO: make a wrapper for this packing/unpacking of ZipFileWriter! */ [INFO] [stdout] 575 | | let zip_writer = zip.zip(zip_writer) [INFO] [stdout] 576 | | .await [INFO] [stdout] ... | [INFO] [stdout] 583 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 584 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zip.rs:595:22 [INFO] [stdout] | [INFO] [stdout] 588 | fn zip_sync(&self, py: Python, output_zip: ZipFileWriter) -> PyResult { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 593 | zip_writer, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 594 | } = output_zip; [INFO] [stdout] 595 | py.allow_threads(move || { [INFO] [stdout] | ______________________^ [INFO] [stdout] 596 | | let zip_writer = handle.block_on(zip.zip(zip_writer)) [INFO] [stdout] 597 | | /* TODO: better error! */ [INFO] [stdout] 598 | | .map_err(|e| PyException::new_err(format!("{}", e)))?; [INFO] [stdout] ... | [INFO] [stdout] 603 | | Ok::<_, PyErr>(output_zip) [INFO] [stdout] 604 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:16:3 [INFO] [stdout] | [INFO] [stdout] 15 | pub fn repr>>(py: Python<'_>, arg: I) -> PyResult { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | / arg [INFO] [stdout] 17 | | .into_py(py) [INFO] [stdout] 18 | | .call_method0(py, intern!(py, "__repr__"))? [INFO] [stdout] | |_______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pymedusa-zip` (lib) due to 19 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `pymedusa-zip` (lib test) due to 19 previous errors [INFO] running `Command { std: "docker" "inspect" "c9a2d6d660e4aea3ca9019b37c2fec8966461ef0fe6b24940019d48b7736a96d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c9a2d6d660e4aea3ca9019b37c2fec8966461ef0fe6b24940019d48b7736a96d", kill_on_drop: false }` [INFO] [stdout] c9a2d6d660e4aea3ca9019b37c2fec8966461ef0fe6b24940019d48b7736a96d