[INFO] fetching crate pyluwen 0.5.2... [INFO] checking pyluwen-0.5.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pyluwen 0.5.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pyluwen 0.5.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pyluwen 0.5.2 [INFO] finished tweaking crates.io crate pyluwen 0.5.2 [INFO] tweaked toml for crates.io crate pyluwen 0.5.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 79 packages to latest compatible versions [INFO] [stderr] Adding bitfield-struct v0.4.4 (latest: v0.8.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding encode_unicode v0.3.6 (latest: v1.0.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding memmap2 v0.7.1 (latest: v0.9.4) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] [stderr] Adding pyo3 v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-build-config v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.19.2 (latest: v0.22.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a5b1cc08ea749a1dc82400f9715103b232ba074fd1c10eb8013932ffbb02dc2f [INFO] running `Command { std: "docker" "start" "-a" "a5b1cc08ea749a1dc82400f9715103b232ba074fd1c10eb8013932ffbb02dc2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a5b1cc08ea749a1dc82400f9715103b232ba074fd1c10eb8013932ffbb02dc2f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a5b1cc08ea749a1dc82400f9715103b232ba074fd1c10eb8013932ffbb02dc2f", kill_on_drop: false }` [INFO] [stdout] a5b1cc08ea749a1dc82400f9715103b232ba074fd1c10eb8013932ffbb02dc2f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 620a92dad4cfd33f32e1a37148ced9d44d1f7f12eccd8ed7bd1fb4f1c7d9a84a [INFO] running `Command { std: "docker" "start" "-a" "620a92dad4cfd33f32e1a37148ced9d44d1f7f12eccd8ed7bd1fb4f1c7d9a84a", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Compiling same-file v1.0.6 [INFO] [stderr] Compiling cpufeatures v0.2.13 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling portable-atomic v1.7.0 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling walkdir v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling memoffset v0.9.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking unicode-width v0.1.13 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling bitfield-struct v0.4.4 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Checking inventory v0.3.15 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Compiling pyo3-build-config v0.19.2 [INFO] [stderr] Checking luwen-core v0.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling pyo3-ffi v0.19.2 [INFO] [stderr] Compiling pyo3 v0.19.2 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking memmap2 v0.7.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Checking rust-embed-utils v8.5.0 [INFO] [stderr] Compiling rust-embed-impl v8.5.0 [INFO] [stderr] Compiling pyo3-macros-backend v0.19.2 [INFO] [stderr] Checking rust-embed v8.5.0 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking luwen-if v0.4.4 [INFO] [stderr] Checking ttkmd-if v0.1.0 [INFO] [stderr] Checking luwen-ref v0.3.1 [INFO] [stderr] Compiling pyo3-macros v0.19.2 [INFO] [stderr] Checking pyluwen v0.5.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:502:44 [INFO] [stdout] | [INFO] [stdout] 502 | self.0.as_wh().map(|v| PciWormhole(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:506:45 [INFO] [stdout] | [INFO] [stdout] 506 | self.0.as_gs().map(|v| PciGrayskull(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:525:12 [INFO] [stdout] | [INFO] [stdout] 521 | let chip = luwen_ref::ExtendedPciDevice::open(pci_interface).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | Ok(PciChip( [INFO] [stdout] | ____________^ [INFO] [stdout] 526 | | luwen_if::chip::Chip::open( [INFO] [stdout] 527 | | arch, [INFO] [stdout] 528 | | luwen_if::CallbackStorage { [INFO] [stdout] ... | [INFO] [stdout] 535 | | })?, [INFO] [stdout] 536 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:794:12 [INFO] [stdout] | [INFO] [stdout] 788 | let buffer = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 794 | Ok(DmaBuffer(buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1237:8 [INFO] [stdout] | [INFO] [stdout] 1137 | callback: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1163 | let mut root_chips = Vec::with_capacity(interfaces.len()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1164 | let mut failed_chips = Vec::with_capacity(interfaces.len()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1196 | let mut callback: Box Result<(), PyErr>> = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1197 | if let Some(callback) = callback { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1214 | let mut chips = match luwen_if::detect_chips(root_chips, &mut callback, options) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1215 | Ok(chips) => chips, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1216 | Err(InitError::PlatformError(err)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1219 | Err(InitError::CallbackError(err)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1237 | Ok(chips [INFO] [stdout] | ________^ [INFO] [stdout] 1238 | | .into_iter() [INFO] [stdout] 1239 | | .map(|chip| UninitPciChip { chip }) [INFO] [stdout] 1240 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyluwen` (lib test) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:502:44 [INFO] [stdout] | [INFO] [stdout] 502 | self.0.as_wh().map(|v| PciWormhole(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:506:45 [INFO] [stdout] | [INFO] [stdout] 506 | self.0.as_gs().map(|v| PciGrayskull(v.clone())) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:525:12 [INFO] [stdout] | [INFO] [stdout] 521 | let chip = luwen_ref::ExtendedPciDevice::open(pci_interface).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 525 | Ok(PciChip( [INFO] [stdout] | ____________^ [INFO] [stdout] 526 | | luwen_if::chip::Chip::open( [INFO] [stdout] 527 | | arch, [INFO] [stdout] 528 | | luwen_if::CallbackStorage { [INFO] [stdout] ... | [INFO] [stdout] 535 | | })?, [INFO] [stdout] 536 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:794:12 [INFO] [stdout] | [INFO] [stdout] 788 | let buffer = self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 794 | Ok(DmaBuffer(buffer)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1237:8 [INFO] [stdout] | [INFO] [stdout] 1137 | callback: Option, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1163 | let mut root_chips = Vec::with_capacity(interfaces.len()); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1164 | let mut failed_chips = Vec::with_capacity(interfaces.len()); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1196 | let mut callback: Box Result<(), PyErr>> = [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1197 | if let Some(callback) = callback { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1214 | let mut chips = match luwen_if::detect_chips(root_chips, &mut callback, options) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1215 | Ok(chips) => chips, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1216 | Err(InitError::PlatformError(err)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1219 | Err(InitError::CallbackError(err)) => { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 1237 | Ok(chips [INFO] [stdout] | ________^ [INFO] [stdout] 1238 | | .into_iter() [INFO] [stdout] 1239 | | .map(|chip| UninitPciChip { chip }) [INFO] [stdout] 1240 | | .collect()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyluwen` (lib) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "620a92dad4cfd33f32e1a37148ced9d44d1f7f12eccd8ed7bd1fb4f1c7d9a84a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "620a92dad4cfd33f32e1a37148ced9d44d1f7f12eccd8ed7bd1fb4f1c7d9a84a", kill_on_drop: false }` [INFO] [stdout] 620a92dad4cfd33f32e1a37148ced9d44d1f7f12eccd8ed7bd1fb4f1c7d9a84a