[INFO] fetching crate pyenv-python 0.4.0... [INFO] checking pyenv-python-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pyenv-python 0.4.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate pyenv-python 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pyenv-python 0.4.0 [INFO] finished tweaking crates.io crate pyenv-python 0.4.0 [INFO] tweaked toml for crates.io crate pyenv-python 0.4.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate pyenv-python 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c882efa936417f06131107e96e6e3c13032312007438a48ff7ba0ca0c02063f4 [INFO] running `Command { std: "docker" "start" "-a" "c882efa936417f06131107e96e6e3c13032312007438a48ff7ba0ca0c02063f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c882efa936417f06131107e96e6e3c13032312007438a48ff7ba0ca0c02063f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c882efa936417f06131107e96e6e3c13032312007438a48ff7ba0ca0c02063f4", kill_on_drop: false }` [INFO] [stdout] c882efa936417f06131107e96e6e3c13032312007438a48ff7ba0ca0c02063f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bb78970637a0c6fb7d1f46f3c2262dbdc6c3ce918602beb1e48be62bbba3809d [INFO] running `Command { std: "docker" "start" "-a" "bb78970637a0c6fb7d1f46f3c2262dbdc6c3ce918602beb1e48be62bbba3809d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.23 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.95 [INFO] [stderr] Compiling syn v1.0.67 [INFO] [stderr] Compiling anyhow v1.0.42 [INFO] [stderr] Checking apply v0.3.0 [INFO] [stderr] Checking is_executable v1.0.1 [INFO] [stderr] Checking print_bytes v0.4.2 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Compiling thiserror-impl v1.0.26 [INFO] [stderr] Checking thiserror v1.0.26 [INFO] [stderr] Checking pyenv-python v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `root` is never read [INFO] [stdout] --> src/lib.rs:276:5 [INFO] [stdout] | [INFO] [stdout] 275 | pub struct Pyenv { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 276 | root: PyenvRoot, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Pyenv` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | match root.metadata() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 238 | let handle = Handle::from_path(path.as_path())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 240 | | name, [INFO] [stdout] 241 | | path, [INFO] [stdout] 242 | | handle, [INFO] [stdout] 243 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 336 | let python_path = match root.python_version_path(&version).check() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | Err((error, python_path)) => return Err(NoExecutable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Ok(path) => path, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | }; [INFO] [stdout] 345 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 346 | | root, [INFO] [stdout] 347 | | version, [INFO] [stdout] 348 | | python_path, [INFO] [stdout] 349 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 412 | let current_python = PythonExecutable::current()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | let pyenv_shim_python = pyenv_root [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | / env::split_paths(&path_var) [INFO] [stdout] 418 | | .map(|mut path| { [INFO] [stdout] 419 | | path.push(current_python.name()); [INFO] [stdout] 420 | | path [INFO] [stdout] ... | [INFO] [stdout] 423 | | .filter_map(|python| python.check().ok()) [INFO] [stdout] 424 | | .find(|python| python != ¤t_python && Some(python) != pyenv_shim_python.as_ref()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:425:20 [INFO] [stdout] | [INFO] [stdout] 412 | let current_python = PythonExecutable::current()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | let pyenv_shim_python = pyenv_root [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | .ok_or(NotInPath) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:30 [INFO] [stdout] | [INFO] [stdout] 415 | .and_then(|path| path.check().ok()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:423:34 [INFO] [stdout] | [INFO] [stdout] 423 | .filter_map(|python| python.check().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `root` is never read [INFO] [stdout] --> src/lib.rs:276:5 [INFO] [stdout] | [INFO] [stdout] 275 | pub struct Pyenv { [INFO] [stdout] | ----- field in this struct [INFO] [stdout] 276 | root: PyenvRoot, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Pyenv` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:57:15 [INFO] [stdout] | [INFO] [stdout] 57 | match root.metadata() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:239:12 [INFO] [stdout] | [INFO] [stdout] 238 | let handle = Handle::from_path(path.as_path())?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 240 | | name, [INFO] [stdout] 241 | | path, [INFO] [stdout] 242 | | handle, [INFO] [stdout] 243 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 336 | let python_path = match root.python_version_path(&version).check() { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 337 | Err((error, python_path)) => return Err(NoExecutable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 343 | Ok(path) => path, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 344 | }; [INFO] [stdout] 345 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 346 | | root, [INFO] [stdout] 347 | | version, [INFO] [stdout] 348 | | python_path, [INFO] [stdout] 349 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:417:9 [INFO] [stdout] | [INFO] [stdout] 412 | let current_python = PythonExecutable::current()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | let pyenv_shim_python = pyenv_root [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 417 | / env::split_paths(&path_var) [INFO] [stdout] 418 | | .map(|mut path| { [INFO] [stdout] 419 | | path.push(current_python.name()); [INFO] [stdout] 420 | | path [INFO] [stdout] ... | [INFO] [stdout] 423 | | .filter_map(|python| python.check().ok()) [INFO] [stdout] 424 | | .find(|python| python != ¤t_python && Some(python) != pyenv_shim_python.as_ref()) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________________________________________________________________________________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:425:20 [INFO] [stdout] | [INFO] [stdout] 412 | let current_python = PythonExecutable::current()?; [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 413 | let pyenv_shim_python = pyenv_root [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 425 | .ok_or(NotInPath) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:415:30 [INFO] [stdout] | [INFO] [stdout] 415 | .and_then(|path| path.check().ok()); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:423:34 [INFO] [stdout] | [INFO] [stdout] 423 | .filter_map(|python| python.check().ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyenv-python` (lib) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `pyenv-python` (lib test) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "bb78970637a0c6fb7d1f46f3c2262dbdc6c3ce918602beb1e48be62bbba3809d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb78970637a0c6fb7d1f46f3c2262dbdc6c3ce918602beb1e48be62bbba3809d", kill_on_drop: false }` [INFO] [stdout] bb78970637a0c6fb7d1f46f3c2262dbdc6c3ce918602beb1e48be62bbba3809d