[INFO] fetching crate pyembed 0.24.0... [INFO] checking pyembed-0.24.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pyembed 0.24.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate pyembed 0.24.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pyembed 0.24.0 [INFO] finished tweaking crates.io crate pyembed 0.24.0 [INFO] tweaked toml for crates.io crate pyembed 0.24.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 91 packages to latest compatible versions [INFO] [stderr] Adding indoc v1.0.9 (latest: v2.0.5) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding mailparse v0.14.1 (latest: v0.15.0) [INFO] [stderr] Adding memmap2 v0.5.10 (latest: v0.9.4) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding pyo3 v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-build-config v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-ffi v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-macros-backend v0.17.3 (latest: v0.22.2) [INFO] [stderr] Adding quick-error v1.2.3 (latest: v2.0.1) [INFO] [stderr] Adding snmalloc-sys v0.2.28 (latest: v0.3.6) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zip v0.6.6 (latest: v2.2.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e5627f78a02e2a59bf9932ff8c9fd6bf063160a588409ea13f7c5a07ba8e7e15 [INFO] running `Command { std: "docker" "start" "-a" "e5627f78a02e2a59bf9932ff8c9fd6bf063160a588409ea13f7c5a07ba8e7e15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e5627f78a02e2a59bf9932ff8c9fd6bf063160a588409ea13f7c5a07ba8e7e15", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5627f78a02e2a59bf9932ff8c9fd6bf063160a588409ea13f7c5a07ba8e7e15", kill_on_drop: false }` [INFO] [stdout] e5627f78a02e2a59bf9932ff8c9fd6bf063160a588409ea13f7c5a07ba8e7e15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1e1322a2d8809da74b19dd917129ebce016fb0cde75e1ee86a894be04529017f [INFO] running `Command { std: "docker" "start" "-a" "1e1322a2d8809da74b19dd917129ebce016fb0cde75e1ee86a894be04529017f", kill_on_drop: false }` [INFO] [stderr] Compiling target-lexicon v0.12.16 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking adler2 v2.0.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking quoted_printable v0.5.1 [INFO] [stderr] Checking data-encoding v2.6.0 [INFO] [stderr] Checking python-packed-resources v0.12.0 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking charset v0.1.5 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking spdx v0.10.6 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Checking mailparse v0.14.1 [INFO] [stderr] Compiling indoc v1.0.9 [INFO] [stderr] Checking simple-file-manifest v0.11.0 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking quick-error v1.2.3 [INFO] [stderr] Checking dunce v1.0.5 [INFO] [stderr] Checking pathdiff v0.2.1 [INFO] [stderr] Checking python-packaging v0.16.0 [INFO] [stderr] Checking rusty-fork v0.3.0 [INFO] [stderr] Compiling pyo3-build-config v0.17.3 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Compiling pyo3-ffi v0.17.3 [INFO] [stderr] Compiling pyo3 v0.17.3 [INFO] [stderr] Compiling pyembed v0.24.0 (/opt/rustwide/workdir) [INFO] [stderr] Compiling pyo3-macros-backend v0.17.3 [INFO] [stderr] Compiling pyo3-macros v0.17.3 [INFO] [stderr] Checking python-oxidized-importer v0.9.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:529:12 [INFO] [stdout] | [INFO] [stdout] 464 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | Ok(ResolvedOxidizedPythonInterpreterConfig { [INFO] [stdout] | ____________^ [INFO] [stdout] 530 | | inner: Self { [INFO] [stdout] 531 | | exe: Some(exe), [INFO] [stdout] 532 | | origin: Some(origin), [INFO] [stdout] ... | [INFO] [stdout] 541 | | }, [INFO] [stdout] 542 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::into_raw` that must be used [INFO] [stdout] --> src/pyalloc.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | Box::into_raw(self.inner.take().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 197 | let _ = Box::into_raw(self.inner.take().unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyembed` (lib) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:529:12 [INFO] [stdout] | [INFO] [stdout] 464 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 529 | Ok(ResolvedOxidizedPythonInterpreterConfig { [INFO] [stdout] | ____________^ [INFO] [stdout] 530 | | inner: Self { [INFO] [stdout] 531 | | exe: Some(exe), [INFO] [stdout] 532 | | origin: Some(origin), [INFO] [stdout] ... | [INFO] [stdout] 541 | | }, [INFO] [stdout] 542 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `Box::::into_raw` that must be used [INFO] [stdout] --> src/pyalloc.rs:197:9 [INFO] [stdout] | [INFO] [stdout] 197 | Box::into_raw(self.inner.take().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: losing the pointer will leak memory [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 197 | let _ = Box::into_raw(self.inner.take().unwrap()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/test/python_resources.rs:119:17 [INFO] [stdout] | [INFO] [stdout] 119 | drop(py); // PyTempDir::drop reacquires the GIL for itself [INFO] [stdout] | ^^^^^--^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `pyo3::Python<'_>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 119 - drop(py); // PyTempDir::drop reacquires the GIL for itself [INFO] [stdout] 119 + let _ = py; // PyTempDir::drop reacquires the GIL for itself [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pyembed` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1e1322a2d8809da74b19dd917129ebce016fb0cde75e1ee86a894be04529017f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1e1322a2d8809da74b19dd917129ebce016fb0cde75e1ee86a894be04529017f", kill_on_drop: false }` [INFO] [stdout] 1e1322a2d8809da74b19dd917129ebce016fb0cde75e1ee86a894be04529017f