[INFO] fetching crate py-pkstl 0.1.0... [INFO] checking py-pkstl-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate py-pkstl 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate py-pkstl 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate py-pkstl 0.1.0 [INFO] finished tweaking crates.io crate py-pkstl 0.1.0 [INFO] tweaked toml for crates.io crate py-pkstl 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 72 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding constant_time_eq v0.1.5 (latest: v0.3.1) [INFO] [stderr] Adding ctor v0.1.26 (latest: v0.2.8) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding indoc v0.3.6 (latest: v2.0.5) [INFO] [stderr] Adding indoc-impl v0.3.6 (latest: v0.3.7) [INFO] [stderr] Adding inventory v0.1.11 (latest: v0.3.15) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding paste v0.1.18 (latest: v1.0.15) [INFO] [stderr] Adding pyo3 v0.8.5 (latest: v0.22.2) [INFO] [stderr] Adding pyo3-derive-backend v0.8.5 (latest: v0.12.5) [INFO] [stderr] Adding pyo3cls v0.8.5 (latest: v0.12.5) [INFO] [stderr] Adding ring v0.16.20 (latest: v0.17.8) [INFO] [stderr] Adding spin v0.5.2 (latest: v0.9.8) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding untrusted v0.7.1 (latest: v0.9.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 847907800a25b9546d79703fd8ca94c3e0d0db68d3f32cfbd2d08596ea4d02ae [INFO] running `Command { std: "docker" "start" "-a" "847907800a25b9546d79703fd8ca94c3e0d0db68d3f32cfbd2d08596ea4d02ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "847907800a25b9546d79703fd8ca94c3e0d0db68d3f32cfbd2d08596ea4d02ae", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "847907800a25b9546d79703fd8ca94c3e0d0db68d3f32cfbd2d08596ea4d02ae", kill_on_drop: false }` [INFO] [stdout] 847907800a25b9546d79703fd8ca94c3e0d0db68d3f32cfbd2d08596ea4d02ae [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3c6f3dccd854daa1e8771683bdc7f60657c81ba7977b78ef49dc1be647bb14ce [INFO] running `Command { std: "docker" "start" "-a" "3c6f3dccd854daa1e8771683bdc7f60657c81ba7977b78ef49dc1be647bb14ce", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling backtrace v0.3.73 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking gimli v0.29.0 [INFO] [stderr] Checking miniz_oxide v0.7.4 [INFO] [stderr] Checking object v0.36.4 [INFO] [stderr] Compiling clear_on_drop v0.2.5 [INFO] [stderr] Compiling ring v0.16.20 [INFO] [stderr] Checking rustc-demangle v0.1.24 [INFO] [stderr] Compiling unindent v0.1.11 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Compiling inventory v0.1.11 [INFO] [stderr] Compiling ghost v0.1.17 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling paste-impl v0.1.18 [INFO] [stderr] Checking chacha20-poly1305-aead v0.1.2 [INFO] [stderr] Checking paste v0.1.18 [INFO] [stderr] Compiling regex-automata v0.4.7 [INFO] [stderr] Checking addr2line v0.22.0 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling pyo3-derive-backend v0.8.5 [INFO] [stderr] Compiling regex v1.10.6 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Compiling inventory-impl v0.1.11 [INFO] [stderr] Compiling indoc-impl v0.3.6 [INFO] [stderr] Compiling pyo3 v0.8.5 [INFO] [stderr] Checking indoc v0.3.6 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Compiling pyo3cls v0.8.5 [INFO] [stderr] Checking pkstl v0.1.0 [INFO] [stderr] Checking py-pkstl v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/lib.rs:82:2 [INFO] [stdout] | [INFO] [stdout] 81 | struct MinimalSecureLayer { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 82 | inner: pkstl::MinimalSecureLayer [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 34 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let py = gil.python(); [INFO] [stdout] 36 | Ok(PyBytes::new(py, self.inner.public_key().as_ref()).to_object(py)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `inner` is never read [INFO] [stdout] --> src/lib.rs:82:2 [INFO] [stdout] | [INFO] [stdout] 81 | struct MinimalSecureLayer { [INFO] [stdout] | ------------------ field in this struct [INFO] [stdout] 82 | inner: pkstl::MinimalSecureLayer [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:36:6 [INFO] [stdout] | [INFO] [stdout] 34 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 35 | let py = gil.python(); [INFO] [stdout] 36 | Ok(PyBytes::new(py, self.inner.public_key().as_ref()).to_object(py)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 58 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let py = gil.python(); [INFO] [stdout] 60 | Ok(PyBytes::new(py, self.inner.as_ref()).to_object(py)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 94 | fn create(config: &SecureLayerConfig, expected_remote_sig_public_key: Option>) -> PyResult { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let py = gil.python(); [INFO] [stdout] 97 | match pkstl::MinimalSecureLayer::create( [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | config.inner, [INFO] [stdout] 99 | | match expected_remote_sig_public_key { [INFO] [stdout] 100 | | Some(val) => Some(val.as_ref(py).as_bytes().to_vec()), [INFO] [stdout] 101 | | None => None [INFO] [stdout] 102 | | } [INFO] [stdout] 103 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 174 | expected_remote_sig_public_key: Option> [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let py = gil.python(); [INFO] [stdout] 179 | match pkstl::SecureLayer::create( [INFO] [stdout] | _______________^ [INFO] [stdout] 180 | | config.inner, [INFO] [stdout] 181 | | match sig_key_pair_seed { [INFO] [stdout] 182 | | Some(val) => Some(val.inner.clone()), [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] 189 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:60:6 [INFO] [stdout] | [INFO] [stdout] 58 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let py = gil.python(); [INFO] [stdout] 60 | Ok(PyBytes::new(py, self.inner.as_ref()).to_object(py)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 94 | fn create(config: &SecureLayerConfig, expected_remote_sig_public_key: Option>) -> PyResult { [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 96 | let py = gil.python(); [INFO] [stdout] 97 | match pkstl::MinimalSecureLayer::create( [INFO] [stdout] | _______________^ [INFO] [stdout] 98 | | config.inner, [INFO] [stdout] 99 | | match expected_remote_sig_public_key { [INFO] [stdout] 100 | | Some(val) => Some(val.as_ref(py).as_bytes().to_vec()), [INFO] [stdout] 101 | | None => None [INFO] [stdout] 102 | | } [INFO] [stdout] 103 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:179:9 [INFO] [stdout] | [INFO] [stdout] 174 | expected_remote_sig_public_key: Option> [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let py = gil.python(); [INFO] [stdout] 179 | match pkstl::SecureLayer::create( [INFO] [stdout] | _______________^ [INFO] [stdout] 180 | | config.inner, [INFO] [stdout] 181 | | match sig_key_pair_seed { [INFO] [stdout] 182 | | Some(val) => Some(val.inner.clone()), [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] 189 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 257 | fn write_bin(&mut self, data: Py) -> PyResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let py = gil.python(); [INFO] [stdout] 260 | let mut channel = BufWriter::new(Vec::with_capacity(1_024)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | [INFO] [stdout] 262 | match self.inner.write_bin( [INFO] [stdout] | _______________^ [INFO] [stdout] 263 | | data.as_ref(py).as_bytes(), [INFO] [stdout] 264 | | &mut channel [INFO] [stdout] 265 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 257 | fn write_bin(&mut self, data: Py) -> PyResult { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | let gil = Python::acquire_gil(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 259 | let py = gil.python(); [INFO] [stdout] 260 | let mut channel = BufWriter::new(Vec::with_capacity(1_024)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 261 | [INFO] [stdout] 262 | match self.inner.write_bin( [INFO] [stdout] | _______________^ [INFO] [stdout] 263 | | data.as_ref(py).as_bytes(), [INFO] [stdout] 264 | | &mut channel [INFO] [stdout] 265 | | ) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `py-pkstl` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `py-pkstl` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3c6f3dccd854daa1e8771683bdc7f60657c81ba7977b78ef49dc1be647bb14ce", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3c6f3dccd854daa1e8771683bdc7f60657c81ba7977b78ef49dc1be647bb14ce", kill_on_drop: false }` [INFO] [stdout] 3c6f3dccd854daa1e8771683bdc7f60657c81ba7977b78ef49dc1be647bb14ce