[INFO] fetching crate pwdm 0.4.0... [INFO] checking pwdm-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pwdm 0.4.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pwdm 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pwdm 0.4.0 [INFO] finished tweaking crates.io crate pwdm 0.4.0 [INFO] tweaked toml for crates.io crate pwdm 0.4.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate pwdm 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8b88463c8b974ea300c18e0155836e6d40b0bd4184868c37311e1f22e521b70f [INFO] running `Command { std: "docker" "start" "-a" "8b88463c8b974ea300c18e0155836e6d40b0bd4184868c37311e1f22e521b70f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8b88463c8b974ea300c18e0155836e6d40b0bd4184868c37311e1f22e521b70f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8b88463c8b974ea300c18e0155836e6d40b0bd4184868c37311e1f22e521b70f", kill_on_drop: false }` [INFO] [stdout] 8b88463c8b974ea300c18e0155836e6d40b0bd4184868c37311e1f22e521b70f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ade2195685305ef627fffc404315bc1661007404b81cf0ea50a3882248f5c461 [INFO] running `Command { std: "docker" "start" "-a" "ade2195685305ef627fffc404315bc1661007404b81cf0ea50a3882248f5c461", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.153 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking utf8parse v0.2.1 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Checking anstyle-parse v0.2.3 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking anstyle-query v1.0.2 [INFO] [stderr] Compiling cc v1.0.91 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking colorchoice v1.0.0 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking anstyle v1.0.6 [INFO] [stderr] Checking zerocopy v0.7.32 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking getrandom v0.2.13 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Compiling terminfo v0.8.0 [INFO] [stderr] Checking universal-hash v0.5.1 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking allocator-api2 v0.2.16 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking bit-vec v0.6.3 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking polyval v0.6.2 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking bit-set v0.5.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hashbrown v0.14.3 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Checking which v6.0.1 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking blake2 v0.10.6 [INFO] [stderr] Checking hashlink v0.9.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking fancy-regex v0.11.0 [INFO] [stderr] Checking ghash v0.5.1 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking ctr v0.9.2 [INFO] [stderr] Checking aead v0.5.2 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking aes-gcm v0.10.3 [INFO] [stderr] Checking argon2 v0.5.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking pwdg v0.1.0 [INFO] [stderr] Checking clearscreen v3.0.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking zxcvbn v2.2.2 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking pwdm v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 63 | let mut conn = Connection::open(db_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let tx = conn.transaction()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let cipher = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Self { conn, cipher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:211:11 [INFO] [stdout] | [INFO] [stdout] 211 | match self.conn.execute( [INFO] [stdout] | ___________^ [INFO] [stdout] 212 | | " [INFO] [stdout] 213 | | INSERT INTO passwords (service, username, ciphertext, nonce) [INFO] [stdout] 214 | | VALUES (?1, ?2, ?3, ?4) [INFO] [stdout] ... | [INFO] [stdout] 221 | | ], [INFO] [stdout] 222 | | ) { [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pwdm` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:84:8 [INFO] [stdout] | [INFO] [stdout] 63 | let mut conn = Connection::open(db_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | let tx = conn.transaction()?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let cipher = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | Ok(Self { conn, cipher }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager.rs:211:11 [INFO] [stdout] | [INFO] [stdout] 211 | match self.conn.execute( [INFO] [stdout] | ___________^ [INFO] [stdout] 212 | | " [INFO] [stdout] 213 | | INSERT INTO passwords (service, username, ciphertext, nonce) [INFO] [stdout] 214 | | VALUES (?1, ?2, ?3, ?4) [INFO] [stdout] ... | [INFO] [stdout] 221 | | ], [INFO] [stdout] 222 | | ) { [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manager/tests.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 116 | let (manager, _temp_file) = setup_db(); [INFO] [stdout] | ------- ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | match manager.add_password(&uid, "password") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pwdm` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "ade2195685305ef627fffc404315bc1661007404b81cf0ea50a3882248f5c461", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ade2195685305ef627fffc404315bc1661007404b81cf0ea50a3882248f5c461", kill_on_drop: false }` [INFO] [stdout] ade2195685305ef627fffc404315bc1661007404b81cf0ea50a3882248f5c461