[INFO] fetching crate pv_rhino 3.0.3... [INFO] checking pv_rhino-3.0.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pv_rhino 3.0.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate pv_rhino 3.0.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pv_rhino 3.0.3 [INFO] finished tweaking crates.io crate pv_rhino 3.0.3 [INFO] tweaked toml for crates.io crate pv_rhino 3.0.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 124 packages to latest compatible versions [INFO] [stderr] Adding alsa v0.6.0 (latest: v0.9.1) [INFO] [stderr] Adding bindgen v0.69.4 (latest: v0.70.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding coreaudio-rs v0.10.0 (latest: v0.12.1) [INFO] [stderr] Adding cpal v0.13.5 (latest: v0.15.3) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding itertools v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding jni v0.19.0 (latest: v0.21.1) [INFO] [stderr] Adding jni-sys v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding libloading v0.7.4 (latest: v0.8.5) [INFO] [stderr] Adding memoffset v0.6.5 (latest: v0.9.1) [INFO] [stderr] Adding ndk v0.6.0 (latest: v0.9.0) [INFO] [stderr] Adding ndk-glue v0.6.2 (latest: v0.7.0) [INFO] [stderr] Adding ndk-sys v0.3.0 (latest: v0.6.0+11769913) [INFO] [stderr] Adding nix v0.23.2 (latest: v0.29.0) [INFO] [stderr] Adding num-derive v0.3.3 (latest: v0.4.2) [INFO] [stderr] Adding num_enum v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding num_enum_derive v0.5.11 (latest: v0.7.3) [INFO] [stderr] Adding oboe v0.4.6 (latest: v0.6.1) [INFO] [stderr] Adding oboe-sys v0.4.5 (latest: v0.6.1) [INFO] [stderr] Adding ogg v0.8.0 (latest: v0.9.1) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding proc-macro-crate v1.3.1 (latest: v3.2.0) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding rodio v0.14.0 (latest: v0.19.0) [INFO] [stderr] Adding rustc-hash v1.1.0 (latest: v2.0.0) [INFO] [stderr] Adding stdweb v0.1.3 (latest: v0.4.20) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml_edit v0.19.15 (latest: v0.22.20) [INFO] [stderr] Adding winnow v0.5.40 (latest: v0.6.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `rhino` library target) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 98192633e45aa7d5aee936e55e81da0b1ca5b95fcb2c761b398fda9f921d1da7 [INFO] running `Command { std: "docker" "start" "-a" "98192633e45aa7d5aee936e55e81da0b1ca5b95fcb2c761b398fda9f921d1da7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "98192633e45aa7d5aee936e55e81da0b1ca5b95fcb2c761b398fda9f921d1da7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98192633e45aa7d5aee936e55e81da0b1ca5b95fcb2c761b398fda9f921d1da7", kill_on_drop: false }` [INFO] [stdout] 98192633e45aa7d5aee936e55e81da0b1ca5b95fcb2c761b398fda9f921d1da7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 426132999f464cf446de70eed3b76989b4cb1a9bd02e946b39c62266c86e32a9 [INFO] running `Command { std: "docker" "start" "-a" "426132999f464cf446de70eed3b76989b4cb1a9bd02e946b39c62266c86e32a9", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `rhino` library target) [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling cpal v0.13.5 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking ogg v0.8.0 [INFO] [stderr] Compiling pv_rhino v3.0.3 (/opt/rustwide/workdir) [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking claxon v0.4.3 [INFO] [stderr] Checking lewton v0.10.2 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking nix v0.23.2 [INFO] [stderr] Checking slice-deque v0.3.0 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rhino.rs:228:20 [INFO] [stdout] | [INFO] [stdout] 227 | .map(|inner| Rhino { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 228 | inner: Arc::new(inner), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rhino.rs:510:12 [INFO] [stdout] | [INFO] [stdout] 385 | library_path: P, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 386 | model_path: P, [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 387 | context_path: P, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 445 | let lib = unsafe { Library::new(library_path.as_ref()) }.map_err(|err| { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 451 | let vtable = RhinoInnerVTable::new(lib)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 452 | [INFO] [stdout] 453 | let sdk_string = match CString::new("rust") { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 454 | Ok(sdk_string) => sdk_string, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 464 | let pv_access_key = CString::new(access_key).map_err(|err| { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 471 | let pv_model_path = pathbuf_to_cstring(model_path); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 472 | let pv_context_path = pathbuf_to_cstring(context_path); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 510 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 511 | | crhino, [INFO] [stdout] 512 | | sample_rate, [INFO] [stdout] 513 | | frame_length, [INFO] [stdout] ... | [INFO] [stdout] 516 | | vtable, [INFO] [stdout] 517 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:107:5 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn pathbuf_to_cstring>(pathbuf: P) -> CString { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 106 | let pathstr = pathbuf.as_ref().to_str().unwrap(); [INFO] [stdout] 107 | CString::new(pathstr).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pv_rhino` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "426132999f464cf446de70eed3b76989b4cb1a9bd02e946b39c62266c86e32a9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "426132999f464cf446de70eed3b76989b4cb1a9bd02e946b39c62266c86e32a9", kill_on_drop: false }` [INFO] [stdout] 426132999f464cf446de70eed3b76989b4cb1a9bd02e946b39c62266c86e32a9