[INFO] fetching crate puzz-server 0.1.0... [INFO] checking puzz-server-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate puzz-server 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate puzz-server 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate puzz-server 0.1.0 [INFO] finished tweaking crates.io crate puzz-server 0.1.0 [INFO] tweaked toml for crates.io crate puzz-server 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding convert_case v0.4.0 (latest: v0.6.0) [INFO] [stderr] Adding derive_more v0.99.18 (latest: v1.0.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a39988ec1f95c0fd382b8f5c6318d61dd1f067d8cc0eaa8ca172d05c615da9a2 [INFO] running `Command { std: "docker" "start" "-a" "a39988ec1f95c0fd382b8f5c6318d61dd1f067d8cc0eaa8ca172d05c615da9a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a39988ec1f95c0fd382b8f5c6318d61dd1f067d8cc0eaa8ca172d05c615da9a2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a39988ec1f95c0fd382b8f5c6318d61dd1f067d8cc0eaa8ca172d05c615da9a2", kill_on_drop: false }` [INFO] [stdout] a39988ec1f95c0fd382b8f5c6318d61dd1f067d8cc0eaa8ca172d05c615da9a2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a948ddf9b6f5cee0083b28f1eae2a6cbe8046b5dcbe501a7bef05539d2d07d7b [INFO] running `Command { std: "docker" "start" "-a" "a948ddf9b6f5cee0083b28f1eae2a6cbe8046b5dcbe501a7bef05539d2d07d7b", kill_on_drop: false }` [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling paste v1.0.15 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking local-waker v0.1.4 [INFO] [stderr] Checking actix-utils v3.0.1 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking puzz-http v0.1.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking bytestring v1.3.1 [INFO] [stderr] Checking language-tags v0.3.2 [INFO] [stderr] Checking actix-service v2.0.2 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling derive_more v0.99.18 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking actix-rt v2.10.0 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking actix-codec v0.5.2 [INFO] [stderr] Checking puzz-service v0.1.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking actix-server v2.5.0 [INFO] [stderr] Checking puzz-core v0.1.0 [INFO] [stderr] Checking actix-http v3.9.0 [INFO] [stderr] Checking puzz-server v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(factory: F) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | options: Ok(ServerOptions { [INFO] [stdout] | ______________________^ [INFO] [stdout] 50 | | workers: None, [INFO] [stdout] 51 | | addr: vec![], [INFO] [stdout] 52 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/mod.rs:88:46 [INFO] [stdout] | [INFO] [stdout] 86 | let service = move |request: actix_http::Request| service.call(request); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | [INFO] [stdout] 88 | async move { Ok::<_, Infallible>(service.into_service()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/mod.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 84 | let factory = move || { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / HttpService::::build() [INFO] [stdout] 100 | | .finish(factory.clone()) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/compat.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 62 | service: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / service [INFO] [stdout] 74 | | .map_request(|request: actix_http::Request| { [INFO] [stdout] 75 | | let (head, body) = request.into_parts(); [INFO] [stdout] ... | [INFO] [stdout] 90 | | request.body(IntoPuzzBody { body }.boxed()).unwrap() [INFO] [stdout] 91 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/compat.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 74 | .map_request(|request: actix_http::Request| { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let (head, body) = request.into_parts(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | let mut request = Request::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | request.body(IntoPuzzBody { body }.boxed()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/compat.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 92 | .map_response(|response: S::Response| { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let (head, body) = response.into_response().into_head(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | let mut response = actix_http::Response::build(head.status); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | response.message_body(IntoActixBody { body }).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `puzz-server` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/mod.rs:49:22 [INFO] [stdout] | [INFO] [stdout] 46 | pub fn new(factory: F) -> Self { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 49 | options: Ok(ServerOptions { [INFO] [stdout] | ______________________^ [INFO] [stdout] 50 | | workers: None, [INFO] [stdout] 51 | | addr: vec![], [INFO] [stdout] 52 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/mod.rs:88:46 [INFO] [stdout] | [INFO] [stdout] 86 | let service = move |request: actix_http::Request| service.call(request); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | [INFO] [stdout] 88 | async move { Ok::<_, Infallible>(service.into_service()) } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/mod.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 84 | let factory = move || { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / HttpService::::build() [INFO] [stdout] 100 | | .finish(factory.clone()) [INFO] [stdout] | |____________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/compat.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 62 | service: S, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | / service [INFO] [stdout] 74 | | .map_request(|request: actix_http::Request| { [INFO] [stdout] 75 | | let (head, body) = request.into_parts(); [INFO] [stdout] ... | [INFO] [stdout] 90 | | request.body(IntoPuzzBody { body }.boxed()).unwrap() [INFO] [stdout] 91 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/compat.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 74 | .map_request(|request: actix_http::Request| { [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 75 | let (head, body) = request.into_parts(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | [INFO] [stdout] 77 | let mut request = Request::builder() [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | request.body(IntoPuzzBody { body }.boxed()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/actix/compat.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 92 | .map_response(|response: S::Response| { [INFO] [stdout] | --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | let (head, body) = response.into_response().into_head(); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | [INFO] [stdout] 95 | let mut response = actix_http::Response::build(head.status); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | response.message_body(IntoActixBody { body }).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `puzz-server` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "a948ddf9b6f5cee0083b28f1eae2a6cbe8046b5dcbe501a7bef05539d2d07d7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a948ddf9b6f5cee0083b28f1eae2a6cbe8046b5dcbe501a7bef05539d2d07d7b", kill_on_drop: false }` [INFO] [stdout] a948ddf9b6f5cee0083b28f1eae2a6cbe8046b5dcbe501a7bef05539d2d07d7b