[INFO] fetching crate pushtx 0.4.0... [INFO] checking pushtx-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pushtx 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pushtx 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pushtx 0.4.0 [INFO] finished tweaking crates.io crate pushtx 0.4.0 [INFO] tweaked toml for crates.io crate pushtx 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 60 packages to latest compatible versions [INFO] [stderr] Adding bech32 v0.10.0-beta (latest: v0.11.0) [INFO] [stderr] Adding bitcoin v0.31.2 (latest: v0.32.2) [INFO] [stderr] Adding bitcoin-internals v0.2.0 (latest: v0.3.0) [INFO] [stderr] Adding bitcoin_hashes v0.13.0 (latest: v0.14.0) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding hex-conservative v0.1.2 (latest: v0.2.1) [INFO] [stderr] Adding mio v0.8.11 (latest: v1.0.2) [INFO] [stderr] Adding secp256k1 v0.28.2 (latest: v0.29.0) [INFO] [stderr] Adding secp256k1-sys v0.9.2 (latest: v0.10.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8caa6994970e8eb8ca51da9813aad1cb80646a7b8466f94e315c9723df2566b3 [INFO] running `Command { std: "docker" "start" "-a" "8caa6994970e8eb8ca51da9813aad1cb80646a7b8466f94e315c9723df2566b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8caa6994970e8eb8ca51da9813aad1cb80646a7b8466f94e315c9723df2566b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8caa6994970e8eb8ca51da9813aad1cb80646a7b8466f94e315c9723df2566b3", kill_on_drop: false }` [INFO] [stdout] 8caa6994970e8eb8ca51da9813aad1cb80646a7b8466f94e315c9723df2566b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 7a4d011b24d485fd415bf0c39e4e666a36d872ef59378068010cebced9ee86f9 [INFO] running `Command { std: "docker" "start" "-a" "7a4d011b24d485fd415bf0c39e4e666a36d872ef59378068010cebced9ee86f9", kill_on_drop: false }` [INFO] [stderr] Compiling bitcoin-internals v0.2.0 [INFO] [stderr] Checking hex-conservative v0.1.2 [INFO] [stderr] Compiling hex_lit v0.1.1 [INFO] [stderr] Compiling bitcoin v0.31.2 [INFO] [stderr] Checking keccak v0.1.5 [INFO] [stderr] Checking nohash-hasher v0.2.0 [INFO] [stderr] Checking bech32 v0.10.0-beta [INFO] [stderr] Compiling secp256k1-sys v0.9.2 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socks v0.3.4 [INFO] [stderr] Checking sha3 v0.10.8 [INFO] [stderr] Checking peerlink v0.8.0 [INFO] [stderr] Checking dns-lookup v2.0.4 [INFO] [stderr] Checking bitcoin_hashes v0.13.0 [INFO] [stderr] Checking secp256k1 v0.28.2 [INFO] [stderr] Checking pushtx v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `version`, `wants_addr_v2`, and `wtxid_relay` are never read [INFO] [stdout] --> src/handshake.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 39 | Done { [INFO] [stdout] | ---- fields in this variant [INFO] [stdout] 40 | /// The peer's advertised version. [INFO] [stdout] 41 | version: &'a VersionMessage, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | /// Whether the peer prefers AddrV2 messages. [INFO] [stdout] 43 | wants_addr_v2: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 44 | /// Wtxid relay [INFO] [stdout] 45 | wtxid_relay: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `peer`, `addr`, and `interface` are never read [INFO] [stdout] --> src/p2p.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | ConnectedFrom { [INFO] [stdout] | ------------- fields in this variant [INFO] [stdout] 63 | /// The peer associated with the event. [INFO] [stdout] 64 | peer: P, [INFO] [stdout] | ^^^^ [INFO] [stdout] 65 | /// The address of the remote peer. [INFO] [stdout] 66 | addr: SocketAddr, [INFO] [stdout] | ^^^^ [INFO] [stdout] 67 | /// The address of the local interface that accepted the connection. [INFO] [stdout] 68 | interface: SocketAddr, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `peer` and `message` are never read [INFO] [stdout] --> src/p2p.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | SendBufferFull { [INFO] [stdout] | -------------- fields in this variant [INFO] [stdout] 90 | /// The peer associated with the event. [INFO] [stdout] 91 | peer: P, [INFO] [stdout] | ^^^^ [INFO] [stdout] 92 | /// The message that could not be sent to the peer. [INFO] [stdout] 93 | message: RawNetworkMessage, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version`, `wants_addr_v2`, and `wtxid_relay` are never read [INFO] [stdout] --> src/handshake.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 39 | Done { [INFO] [stdout] | ---- fields in this variant [INFO] [stdout] 40 | /// The peer's advertised version. [INFO] [stdout] 41 | version: &'a VersionMessage, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | /// Whether the peer prefers AddrV2 messages. [INFO] [stdout] 43 | wants_addr_v2: bool, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 44 | /// Wtxid relay [INFO] [stdout] 45 | wtxid_relay: bool, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `peer`, `addr`, and `interface` are never read [INFO] [stdout] --> src/p2p.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 62 | ConnectedFrom { [INFO] [stdout] | ------------- fields in this variant [INFO] [stdout] 63 | /// The peer associated with the event. [INFO] [stdout] 64 | peer: P, [INFO] [stdout] | ^^^^ [INFO] [stdout] 65 | /// The address of the remote peer. [INFO] [stdout] 66 | addr: SocketAddr, [INFO] [stdout] | ^^^^ [INFO] [stdout] 67 | /// The address of the local interface that accepted the connection. [INFO] [stdout] 68 | interface: SocketAddr, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `peer` and `message` are never read [INFO] [stdout] --> src/p2p.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 89 | SendBufferFull { [INFO] [stdout] | -------------- fields in this variant [INFO] [stdout] 90 | /// The peer associated with the event. [INFO] [stdout] 91 | peer: P, [INFO] [stdout] | ^^^^ [INFO] [stdout] 92 | /// The message that could not be sent to the peer. [INFO] [stdout] 93 | message: RawNetworkMessage, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Event` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seeds.rs:52:25 [INFO] [stdout] | [INFO] [stdout] 52 | .filter_map(|h| h.join().ok()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/seeds.rs:52:25 [INFO] [stdout] | [INFO] [stdout] 52 | .filter_map(|h| h.join().ok()) [INFO] [stdout] | - ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pushtx` (lib test) due to 2 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `pushtx` (lib) due to 2 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "7a4d011b24d485fd415bf0c39e4e666a36d872ef59378068010cebced9ee86f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7a4d011b24d485fd415bf0c39e4e666a36d872ef59378068010cebced9ee86f9", kill_on_drop: false }` [INFO] [stdout] 7a4d011b24d485fd415bf0c39e4e666a36d872ef59378068010cebced9ee86f9