[INFO] fetching crate push2talk 1.3.2... [INFO] checking push2talk-1.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate push2talk 1.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate push2talk 1.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate push2talk 1.3.2 [INFO] finished tweaking crates.io crate push2talk 1.3.2 [INFO] tweaked toml for crates.io crate push2talk 1.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate push2talk 1.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b3395b3f9f225c10a94c219917f444f90da65eb6de8761fd7cb0ee4fb560455c [INFO] running `Command { std: "docker" "start" "-a" "b3395b3f9f225c10a94c219917f444f90da65eb6de8761fd7cb0ee4fb560455c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b3395b3f9f225c10a94c219917f444f90da65eb6de8761fd7cb0ee4fb560455c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b3395b3f9f225c10a94c219917f444f90da65eb6de8761fd7cb0ee4fb560455c", kill_on_drop: false }` [INFO] [stdout] b3395b3f9f225c10a94c219917f444f90da65eb6de8761fd7cb0ee4fb560455c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26c2ea221b2135a5e703491127656b9fd6f284fb8d2a7089b2792924a5ee38f9 [INFO] running `Command { std: "docker" "start" "-a" "26c2ea221b2135a5e703491127656b9fd6f284fb8d2a7089b2792924a5ee38f9", kill_on_drop: false }` [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling input-sys v1.18.0 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Compiling libpulse-sys v1.21.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Compiling rustversion v1.0.17 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking memmap2 v0.8.0 [INFO] [stderr] Checking xkeysym v0.2.1 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking directories-next v2.0.0 [INFO] [stderr] Compiling clap_derive v4.5.5 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking udev v0.7.0 [INFO] [stderr] Checking input v0.8.3 [INFO] [stderr] Checking clap_builder v4.5.7 [INFO] [stderr] Checking procfs-core v0.16.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Checking xkbcommon v0.7.0 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking clap v4.5.7 [INFO] [stderr] Checking libpulse-binding v2.28.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking procfs v0.16.0 [INFO] [stderr] Checking push2talk v1.3.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 56 | let is_paused = Arc::new(Mutex::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let (pulseaudio_ctl, tx_libinput) = pulseaudio::Controller::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | libinput::Controller::new()?.run(tx_libinput, is_paused) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libinput/mod.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | Ok(Controller { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | first_key: keybind_parsed[0], [INFO] [stdout] 43 | | first_key_pressed: Cell::new(false), [INFO] [stdout] 44 | | second_key: keybind_parsed.get(1).cloned(), [INFO] [stdout] ... | [INFO] [stdout] 47 | | xkb_state: init_xkb_state()?, [INFO] [stdout] 48 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libinput/mod.rs:190:8 [INFO] [stdout] | [INFO] [stdout] 185 | let xkb_context = xkb::Context::new(xkb::CONTEXT_NO_FLAGS); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let keymap = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(xkb::State::new(&keymap)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pulseaudio/mod.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 23 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / Controller { [INFO] [stdout] 27 | | source: parse_source(), [INFO] [stdout] 28 | | tx: tx.clone(), [INFO] [stdout] 29 | | rx, [INFO] [stdout] 30 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pulseaudio/mod.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 37 | tx_exit: Sender, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | is_paused: Arc>, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let tx = self.tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | context.set_subscribe_callback(Some(Box::new(move |facility, operation, _index| { [INFO] [stdout] 65 | match (is_paused.lock(), facility, operation) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `push2talk` (bin "push2talk") due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 56 | let is_paused = Arc::new(Mutex::new(false)); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | let (pulseaudio_ctl, tx_libinput) = pulseaudio::Controller::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | libinput::Controller::new()?.run(tx_libinput, is_paused) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libinput/mod.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 41 | Ok(Controller { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | first_key: keybind_parsed[0], [INFO] [stdout] 43 | | first_key_pressed: Cell::new(false), [INFO] [stdout] 44 | | second_key: keybind_parsed.get(1).cloned(), [INFO] [stdout] ... | [INFO] [stdout] 47 | | xkb_state: init_xkb_state()?, [INFO] [stdout] 48 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/libinput/mod.rs:190:8 [INFO] [stdout] | [INFO] [stdout] 185 | let xkb_context = xkb::Context::new(xkb::CONTEXT_NO_FLAGS); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | let keymap = [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(xkb::State::new(&keymap)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pulseaudio/mod.rs:26:13 [INFO] [stdout] | [INFO] [stdout] 23 | let (tx, rx) = mpsc::channel(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | / Controller { [INFO] [stdout] 27 | | source: parse_source(), [INFO] [stdout] 28 | | tx: tx.clone(), [INFO] [stdout] 29 | | rx, [INFO] [stdout] 30 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pulseaudio/mod.rs:65:19 [INFO] [stdout] | [INFO] [stdout] 37 | tx_exit: Sender, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | is_paused: Arc>, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 63 | let tx = self.tx.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | context.set_subscribe_callback(Some(Box::new(move |facility, operation, _index| { [INFO] [stdout] 65 | match (is_paused.lock(), facility, operation) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `push2talk` (bin "push2talk" test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "26c2ea221b2135a5e703491127656b9fd6f284fb8d2a7089b2792924a5ee38f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26c2ea221b2135a5e703491127656b9fd6f284fb8d2a7089b2792924a5ee38f9", kill_on_drop: false }` [INFO] [stdout] 26c2ea221b2135a5e703491127656b9fd6f284fb8d2a7089b2792924a5ee38f9