[INFO] fetching crate punt 0.3.0... [INFO] checking punt-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate punt 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate punt 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate punt 0.3.0 [INFO] finished tweaking crates.io crate punt 0.3.0 [INFO] tweaked toml for crates.io crate punt 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 10 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b31c7004af9abe9ac94a3b1cb972100138583360d62025fde020a0ac93fd5387 [INFO] running `Command { std: "docker" "start" "-a" "b31c7004af9abe9ac94a3b1cb972100138583360d62025fde020a0ac93fd5387", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b31c7004af9abe9ac94a3b1cb972100138583360d62025fde020a0ac93fd5387", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b31c7004af9abe9ac94a3b1cb972100138583360d62025fde020a0ac93fd5387", kill_on_drop: false }` [INFO] [stdout] b31c7004af9abe9ac94a3b1cb972100138583360d62025fde020a0ac93fd5387 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ef088fb658a337a068bca69ca70ee4203dfb184fbe3eecbd6270b33fb75b187 [INFO] running `Command { std: "docker" "start" "-a" "5ef088fb658a337a068bca69ca70ee4203dfb184fbe3eecbd6270b33fb75b187", kill_on_drop: false }` [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Compiling rusb v0.9.4 [INFO] [stderr] Checking debug-helper v0.3.13 [INFO] [stderr] Checking crc-any v2.5.0 [INFO] [stderr] Compiling libusb1-sys v0.7.0 [INFO] [stderr] Checking punt v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/target.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut device_handle = self.usb_device.open()?; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/target_handle.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | fn try_from(mut handle: rusb::DeviceHandle) -> Result { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | .filter_map(|d| Target::try_from(d).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 29 | let config_descriptor = self.usb_device.active_config_descriptor()?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut device_handle = self.usb_device.open()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(TargetHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | usb_device_handle: device_handle, [INFO] [stdout] 53 | | in_buffer_length, [INFO] [stdout] 54 | | out_buffer_length, [INFO] [stdout] 55 | | serial: self.serial()?, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 67 | fn try_from(device: Device) -> Result> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let device_handle = device.open()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Target { usb_device: device }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target_handle.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 284 | fn try_from(mut handle: rusb::DeviceHandle) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | // Fetch endpoint sizes [INFO] [stdout] 286 | let device = handle.device(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | let config_descriptor = device.active_config_descriptor()?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Ok(TargetHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 314 | | usb_device_handle: handle, [INFO] [stdout] 315 | | in_buffer_length, [INFO] [stdout] 316 | | out_buffer_length, [INFO] [stdout] 317 | | serial, [INFO] [stdout] 318 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/target.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | let mut device_handle = self.usb_device.open()?; [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/target_handle.rs:284:17 [INFO] [stdout] | [INFO] [stdout] 284 | fn try_from(mut handle: rusb::DeviceHandle) -> Result { [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `punt` (lib test) due to 5 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:19:29 [INFO] [stdout] | [INFO] [stdout] 19 | .filter_map(|d| Target::try_from(d).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 29 | let config_descriptor = self.usb_device.active_config_descriptor()?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 48 | let mut device_handle = self.usb_device.open()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | Ok(TargetHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 52 | | usb_device_handle: device_handle, [INFO] [stdout] 53 | | in_buffer_length, [INFO] [stdout] 54 | | out_buffer_length, [INFO] [stdout] 55 | | serial: self.serial()?, [INFO] [stdout] 56 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 67 | fn try_from(device: Device) -> Result> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | let device_handle = device.open()?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Ok(Target { usb_device: device }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/target_handle.rs:313:12 [INFO] [stdout] | [INFO] [stdout] 284 | fn try_from(mut handle: rusb::DeviceHandle) -> Result { [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 285 | // Fetch endpoint sizes [INFO] [stdout] 286 | let device = handle.device(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 287 | let config_descriptor = device.active_config_descriptor()?; [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | Ok(TargetHandle { [INFO] [stdout] | ____________^ [INFO] [stdout] 314 | | usb_device_handle: handle, [INFO] [stdout] 315 | | in_buffer_length, [INFO] [stdout] 316 | | out_buffer_length, [INFO] [stdout] 317 | | serial, [INFO] [stdout] 318 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `punt` (lib) due to 5 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5ef088fb658a337a068bca69ca70ee4203dfb184fbe3eecbd6270b33fb75b187", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ef088fb658a337a068bca69ca70ee4203dfb184fbe3eecbd6270b33fb75b187", kill_on_drop: false }` [INFO] [stdout] 5ef088fb658a337a068bca69ca70ee4203dfb184fbe3eecbd6270b33fb75b187