[INFO] fetching crate pui-arena 0.5.1... [INFO] checking pui-arena-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pui-arena 0.5.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pui-arena 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pui-arena 0.5.1 [INFO] finished tweaking crates.io crate pui-arena 0.5.1 [INFO] tweaked toml for crates.io crate pui-arena 0.5.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 74 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding criterion v0.3.6 (latest: v0.5.1) [INFO] [stderr] Adding criterion-plot v0.4.5 (latest: v0.5.0) [INFO] [stderr] Adding half v1.8.3 (latest: v2.4.1) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding radium v0.6.2 (latest: v1.1.0) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e1f68633eff36434d1dfd7cc58933adc140f380df098069bb330c8ca38c1719 [INFO] running `Command { std: "docker" "start" "-a" "3e1f68633eff36434d1dfd7cc58933adc140f380df098069bb330c8ca38c1719", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e1f68633eff36434d1dfd7cc58933adc140f380df098069bb330c8ca38c1719", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e1f68633eff36434d1dfd7cc58933adc140f380df098069bb330c8ca38c1719", kill_on_drop: false }` [INFO] [stdout] 3e1f68633eff36434d1dfd7cc58933adc140f380df098069bb330c8ca38c1719 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0f8605bbf3e9dea5cb92e99be46b876388db160b6b52d7bf029e9d468830e9d5 [INFO] running `Command { std: "docker" "start" "-a" "0f8605bbf3e9dea5cb92e99be46b876388db160b6b52d7bf029e9d468830e9d5", kill_on_drop: false }` [INFO] [stderr] Compiling radium v0.6.2 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stderr] Checking pui-core v0.5.2 [INFO] [stderr] Checking pui-vec v0.5.1 [INFO] [stderr] Checking pui-arena v0.5.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `UB_DEBUG` [INFO] [stdout] --> src/base/hop/imp.rs:101:23 [INFO] [stdout] | [INFO] [stdout] 101 | #[cfg(all(UB_DEBUG, not(miri)))] [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(UB_DEBUG)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(UB_DEBUG)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/dense.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn remove>(&mut self, key: K) -> T { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | self.try_remove(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/dense.rs:326:14 [INFO] [stdout] | [INFO] [stdout] 324 | pub fn try_remove>(&mut self, key: K) -> Option { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 325 | let index = self.slots.try_remove(key)?; [INFO] [stdout] 326 | Some(self.remove_unchecked(index)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/base/dense.rs:639:36 [INFO] [stdout] | [INFO] [stdout] 639 | iter.for_each(move |value| drop::(self.vacant_entry().insert(value))); [INFO] [stdout] | ^^^^^^^^^^^^^^---------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `usize` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] = note: `#[warn(dropping_copy_types)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/hop.rs:69:20 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn with_ident(ident: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | slots: PuiVec::from_raw_parts(std::vec![Slot::SENTINEL], ident), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/hop.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 154 | pub fn remove>(&mut self, key: K) -> T { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | self.try_remove(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/hop.rs:353:20 [INFO] [stdout] | [INFO] [stdout] 350 | pub fn into_entries>(self) -> IntoEntries { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | let (ident, slots) = unsafe { self.slots.into_raw_parts() }; [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | IntoEntries { [INFO] [stdout] 353 | slots: IntoOccupied { [INFO] [stdout] | ____________________^ [INFO] [stdout] 354 | | len: self.num_elements, [INFO] [stdout] 355 | | slots: iter_unchecked::IntoIter::new(slots).enumerate(), [INFO] [stdout] 356 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/hop.rs:369:20 [INFO] [stdout] | [INFO] [stdout] 367 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 368 | IntoIter { [INFO] [stdout] 369 | slots: IntoOccupied { [INFO] [stdout] | ____________________^ [INFO] [stdout] 370 | | len: self.num_elements, [INFO] [stdout] 371 | | slots: iter_unchecked::IntoIter::new(unsafe { self.slots.into_raw_parts().1 }).enumerate(), [INFO] [stdout] 372 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/hop.rs:472:39 [INFO] [stdout] | [INFO] [stdout] 472 | move |(index, (version, value))| (K::new_unchecked(index, version.save(), ident), value) [INFO] [stdout] | ------------------------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/sparse.rs:162:20 [INFO] [stdout] | [INFO] [stdout] 160 | pub fn with_ident(ident: I) -> Self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | Self { [INFO] [stdout] 162 | slots: PuiVec::new(ident), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/sparse.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 275 | pub fn remove>(&mut self, key: K) -> T { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 276 | self.try_remove(key) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/sparse.rs:486:20 [INFO] [stdout] | [INFO] [stdout] 482 | pub fn into_entries>(self) -> IntoEntries { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 483 | let (ident, slots) = unsafe { self.slots.into_raw_parts() }; [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 486 | slots: Occupied { [INFO] [stdout] | ____________________^ [INFO] [stdout] 487 | | slots: slots.into_iter().enumerate(), [INFO] [stdout] 488 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/sparse.rs:501:20 [INFO] [stdout] | [INFO] [stdout] 499 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 500 | IntoIter { [INFO] [stdout] 501 | slots: Occupied { [INFO] [stdout] | ____________________^ [INFO] [stdout] 502 | | slots: unsafe { self.slots.into_raw_parts().1.into_iter() }, [INFO] [stdout] 503 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a value that implements `Copy` does nothing [INFO] [stdout] --> src/base/sparse.rs:527:36 [INFO] [stdout] | [INFO] [stdout] 527 | iter.for_each(move |value| drop::(self.vacant_entry().insert(value))); [INFO] [stdout] | ^^^^^^^^^^^^^^---------------------------------^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `usize` [INFO] [stdout] | [INFO] [stdout] = note: use `let _ = ...` to ignore the expression or result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/sparse.rs:877:14 [INFO] [stdout] | [INFO] [stdout] 874 | self.slots.next().map(|(index, slot)| unsafe { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 875 | let mut slot = ManuallyDrop::new(slot); [INFO] [stdout] 876 | let value = ManuallyDrop::take(&mut slot.data.value); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 877 | (K::new_unchecked(index, slot.version.save(), ident), value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/base/sparse.rs:888:14 [INFO] [stdout] | [INFO] [stdout] 885 | self.slots.next_back().map(|(index, slot)| unsafe { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 886 | let mut slot = ManuallyDrop::new(slot); [INFO] [stdout] 887 | let value = ManuallyDrop::take(&mut slot.data.value); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 888 | (K::new_unchecked(index, slot.version.save(), ident), value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 13 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pui-arena` (lib) due to 14 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "0f8605bbf3e9dea5cb92e99be46b876388db160b6b52d7bf029e9d468830e9d5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0f8605bbf3e9dea5cb92e99be46b876388db160b6b52d7bf029e9d468830e9d5", kill_on_drop: false }` [INFO] [stdout] 0f8605bbf3e9dea5cb92e99be46b876388db160b6b52d7bf029e9d468830e9d5