[INFO] fetching crate puffin 0.19.1... [INFO] checking puffin-0.19.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate puffin 0.19.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate puffin 0.19.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate puffin 0.19.1 [INFO] finished tweaking crates.io crate puffin 0.19.1 [INFO] tweaked toml for crates.io crate puffin 0.19.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 94 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding ruzstd v0.4.0 (latest: v0.7.1) [INFO] [stderr] Adding web-time v0.2.4 (latest: v1.1.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding zstd v0.12.4 (latest: v0.13.2) [INFO] [stderr] Adding zstd-safe v6.0.6 (latest: v7.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 11a4087ba6358dd5d72d8ecf99fadf1c43927858a17d59895aa8cc5a27963070 [INFO] running `Command { std: "docker" "start" "-a" "11a4087ba6358dd5d72d8ecf99fadf1c43927858a17d59895aa8cc5a27963070", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "11a4087ba6358dd5d72d8ecf99fadf1c43927858a17d59895aa8cc5a27963070", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11a4087ba6358dd5d72d8ecf99fadf1c43927858a17d59895aa8cc5a27963070", kill_on_drop: false }` [INFO] [stdout] 11a4087ba6358dd5d72d8ecf99fadf1c43927858a17d59895aa8cc5a27963070 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f9405219c248ad08a8ea0efd412f77632718a647a69eee27ac2e83becc7a1019 [INFO] running `Command { std: "docker" "start" "-a" "f9405219c248ad08a8ea0efd412f77632718a647a69eee27ac2e83becc7a1019", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking puffin v0.19.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame_data.rs:48:47 [INFO] [stdout] | [INFO] [stdout] 48 | .map(|(info, stream_info)| (info, Arc::new(stream_info))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/frame_data.rs:123:12 [INFO] [stdout] | [INFO] [stdout] 120 | scope_delta: Vec>, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 123 | Ok(Self::from_unpacked( [INFO] [stdout] | ____________^ [INFO] [stdout] 124 | | Arc::new(UnpackedFrameData::new(frame_index, thread_streams)?), [INFO] [stdout] 125 | | scope_delta, [INFO] [stdout] 126 | | full_delta, [INFO] [stdout] 127 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_profiler.rs:157:41 [INFO] [stdout] | [INFO] [stdout] 157 | THREAD_PROFILER.with(|p| f(&mut p.borrow_mut())) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `puffin` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f9405219c248ad08a8ea0efd412f77632718a647a69eee27ac2e83becc7a1019", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f9405219c248ad08a8ea0efd412f77632718a647a69eee27ac2e83becc7a1019", kill_on_drop: false }` [INFO] [stdout] f9405219c248ad08a8ea0efd412f77632718a647a69eee27ac2e83becc7a1019