[INFO] fetching crate public-api 0.37.0... [INFO] checking public-api-0.37.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate public-api 0.37.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate public-api 0.37.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate public-api 0.37.0 [INFO] finished tweaking crates.io crate public-api 0.37.0 [INFO] tweaked toml for crates.io crate public-api 0.37.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate public-api 0.37.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2ba1f69c7fb276516b374fe08ec23bbb2fcdc174c80b5116a58181307cec7722 [INFO] running `Command { std: "docker" "start" "-a" "2ba1f69c7fb276516b374fe08ec23bbb2fcdc174c80b5116a58181307cec7722", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2ba1f69c7fb276516b374fe08ec23bbb2fcdc174c80b5116a58181307cec7722", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2ba1f69c7fb276516b374fe08ec23bbb2fcdc174c80b5116a58181307cec7722", kill_on_drop: false }` [INFO] [stdout] 2ba1f69c7fb276516b374fe08ec23bbb2fcdc174c80b5116a58181307cec7722 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 98912d21a93f30c911ef3fb94c9af78ca5703c224eee02e2edf2ba4f663059c5 [INFO] running `Command { std: "docker" "start" "-a" "98912d21a93f30c911ef3fb94c9af78ca5703c224eee02e2edf2ba4f663059c5", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.179 [INFO] [stderr] Compiling serde_derive v1.0.179 [INFO] [stderr] Compiling proc-macro2 v1.0.76 [INFO] [stderr] Compiling unicode-ident v1.0.8 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Checking once_cell v1.17.1 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking equivalent v1.0.0 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking winnow v0.6.5 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Compiling camino v1.1.4 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.6 [INFO] [stderr] Compiling rustix v0.38.31 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling anyhow v1.0.75 [INFO] [stderr] Checking anstyle v1.0.0 [INFO] [stderr] Checking bitflags v2.4.1 [INFO] [stderr] Checking linux-raw-sys v0.4.12 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling assert_cmd v2.0.14 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking predicates-tree v1.0.9 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking either v1.8.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking yansi v0.5.1 [INFO] [stderr] Checking fastrand v2.0.1 [INFO] [stderr] Checking dissimilar v1.0.6 [INFO] [stderr] Checking hashbag v0.1.12 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking predicates v3.1.0 [INFO] [stderr] Checking pretty_assertions v1.4.0 [INFO] [stderr] Checking expect-test v1.5.0 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking bstr v1.4.0 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking serde_spanned v0.6.6 [INFO] [stderr] Checking toml_datetime v0.6.6 [INFO] [stderr] Checking cargo-platform v0.1.2 [INFO] [stderr] Checking rustdoc-types v0.27.0 [INFO] [stderr] Checking toml_edit v0.22.16 [INFO] [stderr] Checking toml v0.8.15 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking cargo-manifest v0.15.0 [INFO] [stderr] Checking cargo_metadata v0.18.1 [INFO] [stderr] Checking public-api v0.37.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustdoc-json v0.9.2 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/common/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 30 | test_crate: impl AsRef, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | target_dir: impl AsRef, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | / rustdoc_json::Builder::default() [INFO] [stdout] 37 | | .manifest_path(&manifest_path) [INFO] [stdout] 38 | | .toolchain("nightly") [INFO] [stdout] 39 | | .target_dir(target_dir) [INFO] [stdout] 40 | | .quiet(true) [INFO] [stdout] 41 | | .build() [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `public-api` (test "public-api-lib-tests") due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:1046:44 [INFO] [stdout] | [INFO] [stdout] 1046 | |context| context.render_type(&Type::Infer), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:1055:44 [INFO] [stdout] | [INFO] [stdout] 1055 | |context| context.render_type(&Type::Generic(s!("name"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:1064:44 [INFO] [stdout] | [INFO] [stdout] 1064 | |context| context.render_type(&Type::Primitive(s!("name"))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:1147:44 [INFO] [stdout] | [INFO] [stdout] 1147 | |context| context.render_type(&Type::Tuple(vec![])), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/render.rs:1174:44 [INFO] [stdout] | [INFO] [stdout] 1174 | |context| context.render_type(&Type::Slice(Box::new(Type::Infer))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/diff.rs:317:20 [INFO] [stdout] | [INFO] [stdout] 315 | fn api(items: impl IntoIterator) -> PublicApi { [INFO] [stdout] | ------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 316 | PublicApi { [INFO] [stdout] 317 | items: items.into_iter().collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `public-api` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "98912d21a93f30c911ef3fb94c9af78ca5703c224eee02e2edf2ba4f663059c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "98912d21a93f30c911ef3fb94c9af78ca5703c224eee02e2edf2ba4f663059c5", kill_on_drop: false }` [INFO] [stdout] 98912d21a93f30c911ef3fb94c9af78ca5703c224eee02e2edf2ba4f663059c5