[INFO] fetching crate psacak 0.1.0... [INFO] checking psacak-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate psacak 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate psacak 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate psacak 0.1.0 [INFO] finished tweaking crates.io crate psacak 0.1.0 [INFO] tweaked toml for crates.io crate psacak 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate psacak 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] df37ad113caf7605afa100c7b93a8b983f6f888bebeea82783d8f40f190f41c5 [INFO] running `Command { std: "docker" "start" "-a" "df37ad113caf7605afa100c7b93a8b983f6f888bebeea82783d8f40f190f41c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "df37ad113caf7605afa100c7b93a8b983f6f888bebeea82783d8f40f190f41c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "df37ad113caf7605afa100c7b93a8b983f6f888bebeea82783d8f40f190f41c5", kill_on_drop: false }` [INFO] [stdout] df37ad113caf7605afa100c7b93a8b983f6f888bebeea82783d8f40f190f41c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 351e10a64914ddc596feee185e356faf9e237751df18c74211bfd49215a81113 [INFO] running `Command { std: "docker" "start" "-a" "351e10a64914ddc596feee185e356faf9e237751df18c74211bfd49215a81113", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.69 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Checking regex-syntax v0.6.17 [INFO] [stderr] Checking ppv-lite86 v0.2.6 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Checking aho-corasick v0.7.10 [INFO] [stderr] Checking crossbeam-channel v0.4.2 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rayon-core v1.7.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Checking regex v1.3.7 [INFO] [stderr] Checking psacak v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicU8::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/types.rs:195:30 [INFO] [stdout] | [INFO] [stdout] 195 | $atomic::compare_and_swap(self, current, new, order) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | impl_atomic!(u8 AtomicU8, u16 AtomicU16, u32 AtomicU32, u64 AtomicU64, usize AtomicUsize); [INFO] [stdout] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_atomic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicU16::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/types.rs:195:30 [INFO] [stdout] | [INFO] [stdout] 195 | $atomic::compare_and_swap(self, current, new, order) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | impl_atomic!(u8 AtomicU8, u16 AtomicU16, u32 AtomicU32, u64 AtomicU64, usize AtomicUsize); [INFO] [stdout] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_atomic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicU32::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/types.rs:195:30 [INFO] [stdout] | [INFO] [stdout] 195 | $atomic::compare_and_swap(self, current, new, order) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | impl_atomic!(u8 AtomicU8, u16 AtomicU16, u32 AtomicU32, u64 AtomicU64, usize AtomicUsize); [INFO] [stdout] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_atomic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicU64::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/types.rs:195:30 [INFO] [stdout] | [INFO] [stdout] 195 | $atomic::compare_and_swap(self, current, new, order) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | impl_atomic!(u8 AtomicU8, u16 AtomicU16, u32 AtomicU32, u64 AtomicU64, usize AtomicUsize); [INFO] [stdout] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_atomic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::sync::atomic::AtomicUsize::compare_and_swap`: Use `compare_exchange` or `compare_exchange_weak` instead [INFO] [stdout] --> src/types.rs:195:30 [INFO] [stdout] | [INFO] [stdout] 195 | $atomic::compare_and_swap(self, current, new, order) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 227 | impl_atomic!(u8 AtomicU8, u16 AtomicU16, u32 AtomicU32, u64 AtomicU64, usize AtomicUsize); [INFO] [stdout] | ----------------------------------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `impl_atomic` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `wrapping_add`, `checked_add`, `wrapping_sub`, and `checked_sub` are never used [INFO] [stdout] --> src/types.rs:76:8 [INFO] [stdout] | [INFO] [stdout] 36 | pub trait Uint: [INFO] [stdout] | ---- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 76 | fn wrapping_add(self, other: Self) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 77 | fn saturating_add(self, other: Self) -> Self; [INFO] [stdout] 78 | fn checked_add(self, other: Self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 79 | [INFO] [stdout] 80 | fn wrapping_sub(self, other: Self) -> Self; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 81 | fn saturating_sub(self, other: Self) -> Self; [INFO] [stdout] 82 | fn checked_sub(self, other: Self) -> Option; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple associated items are never used [INFO] [stdout] --> src/types.rs:130:8 [INFO] [stdout] | [INFO] [stdout] 129 | pub trait Atomic: Sync + Send + Debug { [INFO] [stdout] | ------ associated items in this trait [INFO] [stdout] 130 | fn new(val: T) -> Self; [INFO] [stdout] | ^^^ [INFO] [stdout] 131 | fn get_mut(&mut self) -> &mut T; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 132 | fn into_inner(self) -> T; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 136 | fn swap(&self, val: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^ [INFO] [stdout] 137 | fn compare_and_swap(&self, current: T, new: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 138 | fn compare_exchange(&self, current: T, new: T, success: Ordering, failure: Ordering) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 139 | fn compare_exchange_weak(&self, current: T, new: T, success: Ordering, failure: Ordering) -> Result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 140 | [INFO] [stdout] 141 | fn fetch_add(&self, val: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 142 | fn fetch_sub(&self, val: T, order: Ordering) -> T; [INFO] [stdout] 143 | fn fetch_and(&self, val: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 144 | fn fetch_nand(&self, val: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 145 | fn fetch_or(&self, val: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 146 | fn fetch_xor(&self, val: T, order: Ordering) -> T; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:51:28 [INFO] [stdout] | [INFO] [stdout] 38 | buffers: (RBUF, RBUF, WBUF, WBUF), [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | fetch: FETCH, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | flush: FLUSH, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | mut induce: INDUCE, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let (rbuf0, rbuf1, wbuf0, wbuf1) = buffers; [INFO] [stdout] | ----- ----- ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | self.pool().scoped(|scope| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 52 | | // setup the pipeiline. [INFO] [stdout] 53 | | let fetch_worker = Self::spawn_independent(scope, fetch); [INFO] [stdout] 54 | | let flush_worker = Self::spawn_independent(scope, flush); [INFO] [stdout] ... | [INFO] [stdout] 68 | | (rbuf0, rbuf1, wbuf0, wbuf1) [INFO] [stdout] 69 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:92:28 [INFO] [stdout] | [INFO] [stdout] 79 | buffers: (RBUF, RBUF, WBUF, WBUF), [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 80 | fetch: FETCH, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 81 | flush: FLUSH, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | mut induce: INDUCE, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 91 | let (rbuf0, rbuf1, wbuf0, wbuf1) = buffers; [INFO] [stdout] | ----- ----- ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | | [INFO] [stdout] | | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 92 | self.pool().scoped(|scope| { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 93 | | // setup the pipeiline. [INFO] [stdout] 94 | | // in the inner-level pSACAK, flush must happen before fetch to avoid data race. [INFO] [stdout] 95 | | let (flush_worker, fetch_worker) = Self::spawn_sequential(scope, flush, fetch); [INFO] [stdout] ... | [INFO] [stdout] 109 | | (rbuf0, rbuf1, wbuf0, wbuf1) [INFO] [stdout] 110 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:164:10 [INFO] [stdout] | [INFO] [stdout] 140 | before: BEFORE, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | after: AFTER, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let (ins0, inr0) = channel::bounded(1); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (outs0, outr0) = channel::bounded(1); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let (ins1, inr1) = channel::bounded(1); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let (outs1, outr1) = channel::bounded(0); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | (Worker::new(ins0, outr0), Worker::new(ins1, outr1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pipeline.rs:164:36 [INFO] [stdout] | [INFO] [stdout] 140 | before: BEFORE, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 141 | after: AFTER, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 151 | let (ins0, inr0) = channel::bounded(1); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let (outs0, outr0) = channel::bounded(1); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | let (ins1, inr1) = channel::bounded(1); [INFO] [stdout] | ---- ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let (outs1, outr1) = channel::bounded(0); [INFO] [stdout] | ----- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 164 | (Worker::new(ins0, outr0), Worker::new(ins1, outr1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `psacak` (lib) due to 5 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "351e10a64914ddc596feee185e356faf9e237751df18c74211bfd49215a81113", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "351e10a64914ddc596feee185e356faf9e237751df18c74211bfd49215a81113", kill_on_drop: false }` [INFO] [stdout] 351e10a64914ddc596feee185e356faf9e237751df18c74211bfd49215a81113