[INFO] fetching crate prs-lib 0.5.1... [INFO] checking prs-lib-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prs-lib 0.5.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate prs-lib 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prs-lib 0.5.1 [INFO] finished tweaking crates.io crate prs-lib 0.5.1 [INFO] tweaked toml for crates.io crate prs-lib 0.5.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 111 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cfg-expr v0.15.8 (latest: v0.16.0) [INFO] [stderr] Adding cfg-if v0.1.10 (latest: v1.0.0) [INFO] [stderr] Adding cfg_aliases v0.1.1 (latest: v0.2.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding memoffset v0.7.1 (latest: v0.9.1) [INFO] [stderr] Adding nix v0.17.0 (latest: v0.29.0) [INFO] [stderr] Adding nix v0.28.0 (latest: v0.29.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding system-deps v6.2.2 (latest: v7.0.2) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.10.1 (latest: v0.52.0) [INFO] [stderr] Adding winsafe v0.0.19 (latest: v0.0.22) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2384a7572258575e50bb745af867948bc8115d0f4cbaba427fae77623ca21bd2 [INFO] running `Command { std: "docker" "start" "-a" "2384a7572258575e50bb745af867948bc8115d0f4cbaba427fae77623ca21bd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2384a7572258575e50bb745af867948bc8115d0f4cbaba427fae77623ca21bd2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2384a7572258575e50bb745af867948bc8115d0f4cbaba427fae77623ca21bd2", kill_on_drop: false }` [INFO] [stdout] 2384a7572258575e50bb745af867948bc8115d0f4cbaba427fae77623ca21bd2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 58aa7bd3fc526073f27893e9ba9d61fa6b92b15b115fa0215f22ef95ae20c303 [INFO] running `Command { std: "docker" "start" "-a" "58aa7bd3fc526073f27893e9ba9d61fa6b92b15b115fa0215f22ef95ae20c303", kill_on_drop: false }` [INFO] [stderr] Compiling cfg_aliases v0.1.1 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling nix v0.17.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling prs-lib v0.5.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking secstr v0.5.1 [INFO] [stderr] Checking shlex v1.3.0 [INFO] [stderr] Compiling nix v0.28.0 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking git-state v0.1.0 [INFO] [stderr] Checking version-compare v0.2.0 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling quickcheck_macros v1.0.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking shellexpand v3.1.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking quickcheck v1.0.3 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking which v6.0.3 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking ofiles v0.2.0 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | .map_err(|err| Err::Context(err.into()))?, [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 205 | plaintext: Plaintext, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | fs::write(path, self.encrypt(recipients, plaintext)?.unsecure_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:209:28 [INFO] [stdout] | [INFO] [stdout] 209 | .map_err(|err| Err::WriteFile(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | .ok_or_else(|| Err::UnknownFingerprint.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:270:62 [INFO] [stdout] | [INFO] [stdout] 270 | fs::write(path, self.export_key(key)?).map_err(|err| Err::WriteFile(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn encrypt(config: &Config, recipients: &[&str], plaintext: Plaintext) -> Result { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Ciphertext::from( [INFO] [stdout] | ________^ [INFO] [stdout] 43 | | gpg_stdin_stdout_ok_bin(config, args.as_slice(), plaintext.unsecure_ref()) [INFO] [stdout] 44 | | .map_err(Err::Decrypt)?, [INFO] [stdout] 45 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn decrypt(config: &Config, ciphertext: Ciphertext) -> Result { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | // TODO: ensure ciphertext ends with PGP footer [INFO] [stdout] 54 | Ok(Plaintext::from( [INFO] [stdout] | ________^ [INFO] [stdout] 55 | | gpg_stdin_stdout_ok_bin(config, ["--quiet", "--decrypt"], ciphertext.unsecure_ref()) [INFO] [stdout] 56 | | .map_err(Err::Decrypt)?, [INFO] [stdout] 57 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:87:40 [INFO] [stdout] | [INFO] [stdout] 87 | parse_key_list(list).ok_or_else(|| Err::UnexpectedOutput.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | parse_key_list(list).ok_or_else(|| Err::UnexpectedOutput.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:121:24 [INFO] [stdout] | [INFO] [stdout] 121 | .map_err(|err| Err::Import(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub(super) fn gpg_output<I, S>(config: &Config, args: I) -> Result<Output> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | / cmd_gpg(config, args) [INFO] [stdout] 21 | | .output() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | .map_err(|err| Err::System(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub(super) fn gpg_stdin_output<I, S>(config: &Config, args: I, stdin: &[u8]) -> Result<Output> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let mut cmd = cmd_gpg(config, args); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut child = cmd.spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / child [INFO] [stdout] 40 | | .wait_with_output() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | .map_err(|err| Err::System(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:62:36 [INFO] [stdout] | [INFO] [stdout] 62 | .map_err(|err| Err::GpgCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/store.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 65 | fn write_fingerprints<P: AsRef<Path>, S: AsRef<str>>(path: P, fingerprints: &[S]) -> Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / fs::write( [INFO] [stdout] 67 | | path, [INFO] [stdout] 68 | | fingerprints [INFO] [stdout] 69 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 72 | | .join("\n"), [INFO] [stdout] 73 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/store.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | .map_err(|err| Err::WriteFile(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/store.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | .filter(|e| e.file_type().map(|f| f.is_file()).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:216:36 [INFO] [stdout] | [INFO] [stdout] 216 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:227:36 [INFO] [stdout] | [INFO] [stdout] 227 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 281 | fn git_output<I, S>(repo: &Path, args: I, connects_remote: bool) -> Result<Output> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | / cmd_git(args, repo, connects_remote) [INFO] [stdout] 287 | | .output() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:288:24 [INFO] [stdout] | [INFO] [stdout] 288 | .map_err(|err| Err::System(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:311:36 [INFO] [stdout] | [INFO] [stdout] 311 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:326:36 [INFO] [stdout] | [INFO] [stdout] 326 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:302:21 [INFO] [stdout] | [INFO] [stdout] 293 | let walker = WalkDir::new(&root) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | walker: Box::new(walker), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:379:36 [INFO] [stdout] | [INFO] [stdout] 379 | .map(|mut context| context.can_decrypt_file(&secret.path).unwrap_or(true)) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/git.rs:95:30 [INFO] [stdout] | [INFO] [stdout] 95 | .filter_map(|remote| git::git_remote_get_url(repo, remote).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/git.rs:170:21 [INFO] [stdout] | [INFO] [stdout] 170 | .filter(|e| e.file_type().map(|t| t.is_socket()).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prs-lib` (lib) due to 29 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:138:49 [INFO] [stdout] | [INFO] [stdout] 138 | .map_err(|err| Err::Context(err.into()))?, [INFO] [stdout] | --- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 205 | plaintext: Plaintext, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | fs::write(path, self.encrypt(recipients, plaintext)?.unsecure_ref()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:209:28 [INFO] [stdout] | [INFO] [stdout] 209 | .map_err(|err| Err::WriteFile(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | .ok_or_else(|| Err::UnknownFingerprint.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/mod.rs:270:62 [INFO] [stdout] | [INFO] [stdout] 270 | fs::write(path, self.export_key(key)?).map_err(|err| Err::WriteFile(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:42:8 [INFO] [stdout] | [INFO] [stdout] 28 | pub fn encrypt(config: &Config, recipients: &[&str], plaintext: Plaintext) -> Result<Ciphertext> { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 42 | Ok(Ciphertext::from( [INFO] [stdout] | ________^ [INFO] [stdout] 43 | | gpg_stdin_stdout_ok_bin(config, args.as_slice(), plaintext.unsecure_ref()) [INFO] [stdout] 44 | | .map_err(Err::Decrypt)?, [INFO] [stdout] 45 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 52 | pub fn decrypt(config: &Config, ciphertext: Ciphertext) -> Result<Plaintext> { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | // TODO: ensure ciphertext ends with PGP footer [INFO] [stdout] 54 | Ok(Plaintext::from( [INFO] [stdout] | ________^ [INFO] [stdout] 55 | | gpg_stdin_stdout_ok_bin(config, ["--quiet", "--decrypt"], ciphertext.unsecure_ref()) [INFO] [stdout] 56 | | .map_err(Err::Decrypt)?, [INFO] [stdout] 57 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:87:40 [INFO] [stdout] | [INFO] [stdout] 87 | parse_key_list(list).ok_or_else(|| Err::UnexpectedOutput.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:96:40 [INFO] [stdout] | [INFO] [stdout] 96 | parse_key_list(list).ok_or_else(|| Err::UnexpectedOutput.into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw.rs:121:24 [INFO] [stdout] | [INFO] [stdout] 121 | .map_err(|err| Err::Import(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub(super) fn gpg_output<I, S>(config: &Config, args: I) -> Result<Output> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | / cmd_gpg(config, args) [INFO] [stdout] 21 | | .output() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | .map_err(|err| Err::System(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 26 | pub(super) fn gpg_stdin_output<I, S>(config: &Config, args: I, stdin: &[u8]) -> Result<Output> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | let mut cmd = cmd_gpg(config, args); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let mut child = cmd.spawn().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | / child [INFO] [stdout] 40 | | .wait_with_output() [INFO] [stdout] | |___________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:41:24 [INFO] [stdout] | [INFO] [stdout] 41 | .map_err(|err| Err::System(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/backend/gnupg_bin/raw_cmd.rs:62:36 [INFO] [stdout] | [INFO] [stdout] 62 | .map_err(|err| Err::GpgCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/store.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 65 | fn write_fingerprints<P: AsRef<Path>, S: AsRef<str>>(path: P, fingerprints: &[S]) -> Result<()> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | / fs::write( [INFO] [stdout] 67 | | path, [INFO] [stdout] 68 | | fingerprints [INFO] [stdout] 69 | | .iter() [INFO] [stdout] ... | [INFO] [stdout] 72 | | .join("\n"), [INFO] [stdout] 73 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/store.rs:74:20 [INFO] [stdout] | [INFO] [stdout] 74 | .map_err(|err| Err::WriteFile(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/crypto/store.rs:154:21 [INFO] [stdout] | [INFO] [stdout] 154 | .filter(|e| e.file_type().map(|f| f.is_file()).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:216:36 [INFO] [stdout] | [INFO] [stdout] 216 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:227:36 [INFO] [stdout] | [INFO] [stdout] 227 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 281 | fn git_output<I, S>(repo: &Path, args: I, connects_remote: bool) -> Result<Output> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 286 | / cmd_git(args, repo, connects_remote) [INFO] [stdout] 287 | | .output() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:288:24 [INFO] [stdout] | [INFO] [stdout] 288 | .map_err(|err| Err::System(err).into()) [INFO] [stdout] | --- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:311:36 [INFO] [stdout] | [INFO] [stdout] 311 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/git.rs:326:36 [INFO] [stdout] | [INFO] [stdout] 326 | .map_err(|err| Err::GitCli(err.into()))? [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:302:21 [INFO] [stdout] | [INFO] [stdout] 293 | let walker = WalkDir::new(&root) [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 302 | walker: Box::new(walker), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:379:36 [INFO] [stdout] | [INFO] [stdout] 379 | .map(|mut context| context.can_decrypt_file(&secret.path).unwrap_or(true)) [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/git.rs:95:30 [INFO] [stdout] | [INFO] [stdout] 95 | .filter_map(|remote| git::git_remote_get_url(repo, remote).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/git.rs:170:21 [INFO] [stdout] | [INFO] [stdout] 170 | .filter(|e| e.file_type().map(|t| t.is_socket()).unwrap_or(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 <https://github.com/rust-lang/rust/issues/123739> [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prs-lib` (lib test) due to 29 previous errors [INFO] running `Command { std: "docker" "inspect" "58aa7bd3fc526073f27893e9ba9d61fa6b92b15b115fa0215f22ef95ae20c303", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58aa7bd3fc526073f27893e9ba9d61fa6b92b15b115fa0215f22ef95ae20c303", kill_on_drop: false }` [INFO] [stdout] 58aa7bd3fc526073f27893e9ba9d61fa6b92b15b115fa0215f22ef95ae20c303