[INFO] fetching crate proxy-server 0.6.5... [INFO] checking proxy-server-0.6.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate proxy-server 0.6.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate proxy-server 0.6.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate proxy-server 0.6.5 [INFO] finished tweaking crates.io crate proxy-server 0.6.5 [INFO] tweaked toml for crates.io crate proxy-server 0.6.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate proxy-server 0.6.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e3134af0e45c1880fdcf6b9fea250bc033a7d4222f479f88da830a44729bfd7a [INFO] running `Command { std: "docker" "start" "-a" "e3134af0e45c1880fdcf6b9fea250bc033a7d4222f479f88da830a44729bfd7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e3134af0e45c1880fdcf6b9fea250bc033a7d4222f479f88da830a44729bfd7a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e3134af0e45c1880fdcf6b9fea250bc033a7d4222f479f88da830a44729bfd7a", kill_on_drop: false }` [INFO] [stdout] e3134af0e45c1880fdcf6b9fea250bc033a7d4222f479f88da830a44729bfd7a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5ba532295a3d8018bf7278423eaddd6eeda2922e7aca7dcdb66c2ddb4f01aa5d [INFO] running `Command { std: "docker" "start" "-a" "5ba532295a3d8018bf7278423eaddd6eeda2922e7aca7dcdb66c2ddb4f01aa5d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking proxy-server v0.6.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `chunk_5MB` [INFO] [stdout] --> src/prelude/constants.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | #[cfg(feature = "chunk_5MB")] [INFO] [stdout] | ^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"chunk_5KB"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `chunk_100KB`, `chunk_10KB`, `chunk_1KB`, `chunk_1MB`, `chunk_500KB`, `chunk_50KB`, `chunk_5KB`, `default`, and `napi` [INFO] [stdout] = help: consider adding `chunk_5MB` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `chunk_10MB` [INFO] [stdout] --> src/prelude/constants.rs:34:7 [INFO] [stdout] | [INFO] [stdout] 34 | #[cfg(feature = "chunk_10MB")] [INFO] [stdout] | ^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"chunk_10KB"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `chunk_100KB`, `chunk_10KB`, `chunk_1KB`, `chunk_1MB`, `chunk_500KB`, `chunk_50KB`, `chunk_5KB`, `default`, and `napi` [INFO] [stdout] = help: consider adding `chunk_10MB` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `chunk_5MB` [INFO] [stdout] --> src/prelude/constants.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | #[cfg(feature = "chunk_5MB")] [INFO] [stdout] | ^^^^^^^^^^----------- [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"chunk_5KB"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `chunk_100KB`, `chunk_10KB`, `chunk_1KB`, `chunk_1MB`, `chunk_500KB`, `chunk_50KB`, `chunk_5KB`, `default`, and `napi` [INFO] [stdout] = help: consider adding `chunk_5MB` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `chunk_10MB` [INFO] [stdout] --> src/prelude/constants.rs:34:7 [INFO] [stdout] | [INFO] [stdout] 34 | #[cfg(feature = "chunk_10MB")] [INFO] [stdout] | ^^^^^^^^^^------------ [INFO] [stdout] | | [INFO] [stdout] | help: there is a expected value with a similar name: `"chunk_10KB"` [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `chunk_100KB`, `chunk_10KB`, `chunk_1KB`, `chunk_1MB`, `chunk_500KB`, `chunk_50KB`, `chunk_5KB`, `default`, and `napi` [INFO] [stdout] = help: consider adding `chunk_10MB` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 126 | let listener = TcpListener::bind(&self.address)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let pool = ThreadPool::new(self.threads); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Err(Error::new(ErrorKind::Interrupted, "main thread crashed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 24 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 70 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/mod.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | let socket = TcpStream::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(Http::from(socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/request.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 103 | let reg = Regex::new(r"\d{3}[ \w\-]+").unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let capts = reg.captures(raw.as_str()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let capts = capts.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / Regex::new(r"\s+$") [INFO] [stdout] 120 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 126 | let listener = TcpListener::bind(&self.address)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | let pool = ThreadPool::new(self.threads); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | Err(Error::new(ErrorKind::Interrupted, "main thread crashed")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 24 | let (sender, receiver) = mpsc::channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | [INFO] [stdout] 26 | let receiver = Arc::new(Mutex::new(receiver)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 27 | [INFO] [stdout] 28 | let mut workers = Vec::with_capacity(size); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | sender: Some(sender), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/thread_pool.rs:89:21 [INFO] [stdout] | [INFO] [stdout] 70 | fn new(id: usize, receiver: Arc>>) -> Worker { [INFO] [stdout] | ----------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 71 | let thread = thread::spawn(move || loop { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | thread: Some(thread), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/mod.rs:29:12 [INFO] [stdout] | [INFO] [stdout] 28 | let socket = TcpStream::connect(address)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 29 | Ok(Http::from(socket)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/http/request.rs:119:5 [INFO] [stdout] | [INFO] [stdout] 103 | let reg = Regex::new(r"\d{3}[ \w\-]+").unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | let capts = reg.captures(raw.as_str()); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let capts = capts.unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 119 | / Regex::new(r"\s+$") [INFO] [stdout] 120 | | .unwrap() [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `proxy-server` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `proxy-server` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "5ba532295a3d8018bf7278423eaddd6eeda2922e7aca7dcdb66c2ddb4f01aa5d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5ba532295a3d8018bf7278423eaddd6eeda2922e7aca7dcdb66c2ddb4f01aa5d", kill_on_drop: false }` [INFO] [stdout] 5ba532295a3d8018bf7278423eaddd6eeda2922e7aca7dcdb66c2ddb4f01aa5d