[INFO] fetching crate proxied 0.3.4... [INFO] checking proxied-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate proxied 0.3.4 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate proxied 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate proxied 0.3.4 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate proxied 0.3.4 [INFO] tweaked toml for crates.io crate proxied 0.3.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 83 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 40e907fe39c0e5258ef11f728c7545f4837c9393f1bbfddb74ef9966fe76070e [INFO] running `Command { std: "docker" "start" "-a" "40e907fe39c0e5258ef11f728c7545f4837c9393f1bbfddb74ef9966fe76070e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "40e907fe39c0e5258ef11f728c7545f4837c9393f1bbfddb74ef9966fe76070e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40e907fe39c0e5258ef11f728c7545f4837c9393f1bbfddb74ef9966fe76070e", kill_on_drop: false }` [INFO] [stdout] 40e907fe39c0e5258ef11f728c7545f4837c9393f1bbfddb74ef9966fe76070e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1c70037f2627deb08afde6a10333fa64b0456f215a86746f0a571aa4f71a326 [INFO] running `Command { std: "docker" "start" "-a" "c1c70037f2627deb08afde6a10333fa64b0456f215a86746f0a571aa4f71a326", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Checking overload v0.1.1 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking uri v0.4.0 [INFO] [stderr] Checking nu-ansi-term v0.46.0 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Checking async-http-proxy v1.2.5 [INFO] [stderr] Checking fast-socks5 v0.9.6 [INFO] [stderr] Checking proxied v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `ops::Deref` [INFO] [stdout] --> tests/test_socks5.rs:8:32 [INFO] [stdout] | [INFO] [stdout] 8 | use std::{convert::Infallible, ops::Deref, sync::LazyLock}; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `task::JoinSet` [INFO] [stdout] --> tests/test_socks5.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | task::JoinSet, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NoAuth` is never constructed [INFO] [stdout] --> tests/test_socks5.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 32 | enum AuthMode { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] 33 | NoAuth, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `AuthMode` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/test_socks5.rs:51:24 [INFO] [stdout] | [INFO] [stdout] 46 | fn spawn_and_log_error(fut: F) -> tokio::task::JoinHandle<()> [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | tokio::task::spawn(async move { [INFO] [stdout] | ________________________^ [INFO] [stdout] 52 | | match fut.await { [INFO] [stdout] 53 | | Ok(mut socket) => { [INFO] [stdout] 54 | | if let Some(user) = socket.take_credentials() { [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> tests/test_socks5.rs:52:15 [INFO] [stdout] | [INFO] [stdout] 46 | fn spawn_and_log_error(fut: F) -> tokio::task::JoinHandle<()> [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | match fut.await { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `VERIFICATION_SLICE` should have a snake case name [INFO] [stdout] --> tests/test_socks5.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | let VERIFICATION_SLICE: &[u8] = &[1, 2, 3, 4, 5, 6, 7, 8, 9, 10]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `verification_slice` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `proxied` (test "test_socks5") due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1c70037f2627deb08afde6a10333fa64b0456f215a86746f0a571aa4f71a326", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1c70037f2627deb08afde6a10333fa64b0456f215a86746f0a571aa4f71a326", kill_on_drop: false }` [INFO] [stdout] c1c70037f2627deb08afde6a10333fa64b0456f215a86746f0a571aa4f71a326