[INFO] fetching crate promql 0.5.0... [INFO] checking promql-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate promql 0.5.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate promql 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate promql 0.5.0 [INFO] finished tweaking crates.io crate promql 0.5.0 [INFO] tweaked toml for crates.io crate promql 0.5.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 13 packages to latest compatible versions [INFO] [stderr] Adding builder-pattern v0.3.11 (latest: v0.4.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8feb1f2a790dee461745e727f8c2a803e29d9ad64fcceba7e29003798bcf1592 [INFO] running `Command { std: "docker" "start" "-a" "8feb1f2a790dee461745e727f8c2a803e29d9ad64fcceba7e29003798bcf1592", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8feb1f2a790dee461745e727f8c2a803e29d9ad64fcceba7e29003798bcf1592", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8feb1f2a790dee461745e727f8c2a803e29d9ad64fcceba7e29003798bcf1592", kill_on_drop: false }` [INFO] [stdout] 8feb1f2a790dee461745e727f8c2a803e29d9ad64fcceba7e29003798bcf1592 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 337847b8c88bacd76fab43e3a3d2bbef08dd30148439ffbc585fb98fb4f743d7 [INFO] running `Command { std: "docker" "start" "-a" "337847b8c88bacd76fab43e3a3d2bbef08dd30148439ffbc585fb98fb4f743d7", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Compiling builder-pattern v0.3.11 [INFO] [stderr] Checking promql v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::tabs_in_doc_comments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `serde`, `serde_derive`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::tabs_in_doc_comments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default`, `serde`, `serde_derive`, and `serializable` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:173:18 [INFO] [stdout] | [INFO] [stdout] 172 | fn negation(x: Node) -> Node { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Node::Negation(Box::new(x)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:194:2 [INFO] [stdout] | [INFO] [stdout] 177 | fn label_list(input: I, opts: &ParserOptions) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | / delimited_ws( [INFO] [stdout] 195 | | char('('), [INFO] [stdout] 196 | | separated_list0(surrounded_ws_or_comment(opts, char(',')), label_name), [INFO] [stdout] 197 | | char(')') [INFO] [stdout] 198 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:218:2 [INFO] [stdout] | [INFO] [stdout] 201 | fn function_aggregation(input: I, opts: &ParserOptions) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | / surrounded_ws_or_comment(opts, map( [INFO] [stdout] 219 | | tuple_separated!(ws_or_comment(opts), ( [INFO] [stdout] 220 | | alt(( [INFO] [stdout] 221 | | value(tag("by"), AggregationAction::By), [INFO] [stdout] ... | [INFO] [stdout] 226 | | |(action, labels)| (AggregationMod { action, labels }) [INFO] [stdout] 227 | | ))(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:58 [INFO] [stdout] | [INFO] [stdout] 19 | ($delim:expr, ($first:expr, $($rest:expr),* $(,)?)) => {{ [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 20 | | use nom::sequence::{tuple, preceded}; [INFO] [stdout] 21 | | [INFO] [stdout] 22 | | tuple(( [INFO] [stdout] ... | [INFO] [stdout] 27 | | )) [INFO] [stdout] 28 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] ::: src/expr.rs:425:120 [INFO] [stdout] | [INFO] [stdout] 425 | fn with_bool_modifier<'a, I, C, O: Fn(bool, Option) -> Op + 'a>(opts: &'a ParserOptions, literal: &'static str, op: O) -> impl FnM... [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | / tuple_separated!(ws_or_comment(opts), ( [INFO] [stdout] 445 | | tag(literal), [INFO] [stdout] 446 | | opt(tag("bool")), [INFO] [stdout] 447 | | opt(move |i| op_modifier(i, opts)), [INFO] [stdout] 448 | | )), [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `tuple_separated` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:449:3 [INFO] [stdout] | [INFO] [stdout] 425 | fn with_bool_modifier<'a, I, C, O: Fn(bool, Option) -> Op + 'a>(opts: &'a ParserOptions, literal: &'static str, op: O) -> impl FnM... [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | / move |(_, boolness, op_mod)| [INFO] [stdout] 450 | | op(boolness.is_some(), op_mod) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:471:2 [INFO] [stdout] | [INFO] [stdout] 454 | fn op_modifier(input: I, opts: &ParserOptions) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 471 | / surrounded_ws_or_comment(opts, map( [INFO] [stdout] 472 | | tuple_separated!(ws_or_comment(opts), ( [INFO] [stdout] 473 | | // action [INFO] [stdout] 474 | | alt(( [INFO] [stdout] ... | [INFO] [stdout] 498 | | (OpMod { action, labels, group }) [INFO] [stdout] 499 | | ))(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:665:5 [INFO] [stdout] | [INFO] [stdout] 613 | let (tail, ops_args) = many0(tuple(( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | let (tail, last_arg) = atom(recursion_level, tail, opts)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 646 | let (mut args, mut ops): (Vec<_>, Vec<_>) = ops_args.into_iter().unzip(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 665 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 666 | | tail, [INFO] [stdout] 667 | | args.pop().unwrap(), [INFO] [stdout] 668 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str.rs:79:2 [INFO] [stdout] | [INFO] [stdout] 69 | fn rune(input: I) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / preceded(char('\\'), [INFO] [stdout] 80 | | alt(( [INFO] [stdout] 81 | | // not using value() here to avoid allocation of lots of temporary Vec *per rune() call* [INFO] [stdout] 82 | | map(char('a'), |_| vec![0x07]), [INFO] [stdout] ... | [INFO] [stdout] 109 | | )) [INFO] [stdout] 110 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str.rs:160:3 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn string(input: I) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | / alt(( [INFO] [stdout] 161 | | // newlines are not allowed in interpreted quotes, but are totally fine in raw string literals [INFO] [stdout] 162 | | delimited(char('"'), chars_except("\n\"\\"), char('"')), [INFO] [stdout] 163 | | delimited(char('\''), chars_except("\n'\\"), char('\'')), [INFO] [stdout] 164 | | // raw string literals, where "backslashes have no special meaning" [INFO] [stdout] 165 | | delimited(char('`'), is_not_v("`"), char('`')), [INFO] [stdout] 166 | | ))(input) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:99:2 [INFO] [stdout] | [INFO] [stdout] 82 | fn label_set(input: I, opts: &ParserOptions) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / delimited( [INFO] [stdout] 100 | | char('{'), [INFO] [stdout] 101 | | surrounded_ws( [INFO] [stdout] 102 | | separated_list0( [INFO] [stdout] ... | [INFO] [stdout] 115 | | char('}') [INFO] [stdout] 116 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:223:2 [INFO] [stdout] | [INFO] [stdout] 208 | fn range_literal_part(input: I, opts: &ParserOptions, max_duration: Option) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | / map_opt( [INFO] [stdout] 224 | | tuple(( [INFO] [stdout] 225 | | map( [INFO] [stdout] 226 | | move |input: I| if opts.fractional_intervals { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:383:2 [INFO] [stdout] | [INFO] [stdout] 369 | fn metric_name(input: I, opts: &ParserOptions) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | / map_res( [INFO] [stdout] 384 | | recognize(tuple(( [INFO] [stdout] 385 | | alt((alpha1, is_a("_:"))), [INFO] [stdout] 386 | | many0(alt(( [INFO] [stdout] ... | [INFO] [stdout] 390 | | |s: I| String::from_utf8(s.as_bytes().to_vec()) [INFO] [stdout] 391 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:408:1 [INFO] [stdout] | [INFO] [stdout] 394 | pub(crate) fn label_name(input: I) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | / map_res( [INFO] [stdout] 409 | | recognize(tuple(( [INFO] [stdout] 410 | | alt((alpha1, is_a("_"))), [INFO] [stdout] 411 | | many0(alt((alphanumeric1, is_a("_")))), [INFO] [stdout] 412 | | ))), [INFO] [stdout] 413 | | |s: I| String::from_utf8(s.as_bytes().to_vec()) [INFO] [stdout] 414 | | )(input) [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:423:2 [INFO] [stdout] | [INFO] [stdout] 417 | fn label_op(input: I) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 423 | / alt(( [INFO] [stdout] 424 | | value(tag("=~"), LabelMatchOp::REq), [INFO] [stdout] 425 | | value(tag("!~"), LabelMatchOp::RNe), [INFO] [stdout] 426 | | value(tag("="), LabelMatchOp::Eq), // should come after =~ [INFO] [stdout] 427 | | value(tag("!="), LabelMatchOp::Ne), [INFO] [stdout] 428 | | ))(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:58 [INFO] [stdout] | [INFO] [stdout] 19 | ($delim:expr, ($first:expr, $($rest:expr),* $(,)?)) => {{ [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 20 | | use nom::sequence::{tuple, preceded}; [INFO] [stdout] 21 | | [INFO] [stdout] 22 | | tuple(( [INFO] [stdout] ... | [INFO] [stdout] 27 | | )) [INFO] [stdout] 28 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub(crate) fn delimited_ws(p1: P1, p2: P2, p3: P3) -> impl FnMut(I) -> IResult [INFO] [stdout] | ------ ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | tuple_separated!(multispace0, (p1, p2, p3)), [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `tuple_separated` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/whitespace.rs:90:3 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn surrounded_ws_or_comment<'a, I, C, O, P>(opts: &'a ParserOptions, parser: P) -> impl FnMut(I) -> IResult + 'a [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | ws_or_comment(opts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/whitespace.rs:92:3 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn surrounded_ws_or_comment<'a, I, C, O, P>(opts: &'a ParserOptions, parser: P) -> impl FnMut(I) -> IResult + 'a [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | ws_or_comment(opts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 17 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `promql` (lib) due to 18 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:173:18 [INFO] [stdout] | [INFO] [stdout] 172 | fn negation(x: Node) -> Node { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Node::Negation(Box::new(x)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:194:2 [INFO] [stdout] | [INFO] [stdout] 177 | fn label_list(input: I, opts: &ParserOptions) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 194 | / delimited_ws( [INFO] [stdout] 195 | | char('('), [INFO] [stdout] 196 | | separated_list0(surrounded_ws_or_comment(opts, char(',')), label_name), [INFO] [stdout] 197 | | char(')') [INFO] [stdout] 198 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:218:2 [INFO] [stdout] | [INFO] [stdout] 201 | fn function_aggregation(input: I, opts: &ParserOptions) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 218 | / surrounded_ws_or_comment(opts, map( [INFO] [stdout] 219 | | tuple_separated!(ws_or_comment(opts), ( [INFO] [stdout] 220 | | alt(( [INFO] [stdout] 221 | | value(tag("by"), AggregationAction::By), [INFO] [stdout] ... | [INFO] [stdout] 226 | | |(action, labels)| (AggregationMod { action, labels }) [INFO] [stdout] 227 | | ))(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:58 [INFO] [stdout] | [INFO] [stdout] 19 | ($delim:expr, ($first:expr, $($rest:expr),* $(,)?)) => {{ [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 20 | | use nom::sequence::{tuple, preceded}; [INFO] [stdout] 21 | | [INFO] [stdout] 22 | | tuple(( [INFO] [stdout] ... | [INFO] [stdout] 27 | | )) [INFO] [stdout] 28 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] ::: src/expr.rs:425:120 [INFO] [stdout] | [INFO] [stdout] 425 | fn with_bool_modifier<'a, I, C, O: Fn(bool, Option) -> Op + 'a>(opts: &'a ParserOptions, literal: &'static str, op: O) -> impl FnM... [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | / tuple_separated!(ws_or_comment(opts), ( [INFO] [stdout] 445 | | tag(literal), [INFO] [stdout] 446 | | opt(tag("bool")), [INFO] [stdout] 447 | | opt(move |i| op_modifier(i, opts)), [INFO] [stdout] 448 | | )), [INFO] [stdout] | |__________- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `tuple_separated` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:449:3 [INFO] [stdout] | [INFO] [stdout] 425 | fn with_bool_modifier<'a, I, C, O: Fn(bool, Option) -> Op + 'a>(opts: &'a ParserOptions, literal: &'static str, op: O) -> impl FnM... [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 449 | / move |(_, boolness, op_mod)| [INFO] [stdout] 450 | | op(boolness.is_some(), op_mod) [INFO] [stdout] | |__________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:471:2 [INFO] [stdout] | [INFO] [stdout] 454 | fn op_modifier(input: I, opts: &ParserOptions) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 471 | / surrounded_ws_or_comment(opts, map( [INFO] [stdout] 472 | | tuple_separated!(ws_or_comment(opts), ( [INFO] [stdout] 473 | | // action [INFO] [stdout] 474 | | alt(( [INFO] [stdout] ... | [INFO] [stdout] 498 | | (OpMod { action, labels, group }) [INFO] [stdout] 499 | | ))(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:665:5 [INFO] [stdout] | [INFO] [stdout] 613 | let (tail, ops_args) = many0(tuple(( [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 639 | let (tail, last_arg) = atom(recursion_level, tail, opts)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 646 | let (mut args, mut ops): (Vec<_>, Vec<_>) = ops_args.into_iter().unzip(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 665 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 666 | | tail, [INFO] [stdout] 667 | | args.pop().unwrap(), [INFO] [stdout] 668 | | )) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str.rs:79:2 [INFO] [stdout] | [INFO] [stdout] 69 | fn rune(input: I) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | / preceded(char('\\'), [INFO] [stdout] 80 | | alt(( [INFO] [stdout] 81 | | // not using value() here to avoid allocation of lots of temporary Vec *per rune() call* [INFO] [stdout] 82 | | map(char('a'), |_| vec![0x07]), [INFO] [stdout] ... | [INFO] [stdout] 109 | | )) [INFO] [stdout] 110 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/str.rs:160:3 [INFO] [stdout] | [INFO] [stdout] 147 | pub fn string(input: I) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | / alt(( [INFO] [stdout] 161 | | // newlines are not allowed in interpreted quotes, but are totally fine in raw string literals [INFO] [stdout] 162 | | delimited(char('"'), chars_except("\n\"\\"), char('"')), [INFO] [stdout] 163 | | delimited(char('\''), chars_except("\n'\\"), char('\'')), [INFO] [stdout] 164 | | // raw string literals, where "backslashes have no special meaning" [INFO] [stdout] 165 | | delimited(char('`'), is_not_v("`"), char('`')), [INFO] [stdout] 166 | | ))(input) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:99:2 [INFO] [stdout] | [INFO] [stdout] 82 | fn label_set(input: I, opts: &ParserOptions) -> IResult> [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | / delimited( [INFO] [stdout] 100 | | char('{'), [INFO] [stdout] 101 | | surrounded_ws( [INFO] [stdout] 102 | | separated_list0( [INFO] [stdout] ... | [INFO] [stdout] 115 | | char('}') [INFO] [stdout] 116 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:223:2 [INFO] [stdout] | [INFO] [stdout] 208 | fn range_literal_part(input: I, opts: &ParserOptions, max_duration: Option) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | / map_opt( [INFO] [stdout] 224 | | tuple(( [INFO] [stdout] 225 | | map( [INFO] [stdout] 226 | | move |input: I| if opts.fractional_intervals { [INFO] [stdout] ... | [INFO] [stdout] 264 | | } [INFO] [stdout] 265 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:383:2 [INFO] [stdout] | [INFO] [stdout] 369 | fn metric_name(input: I, opts: &ParserOptions) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 383 | / map_res( [INFO] [stdout] 384 | | recognize(tuple(( [INFO] [stdout] 385 | | alt((alpha1, is_a("_:"))), [INFO] [stdout] 386 | | many0(alt(( [INFO] [stdout] ... | [INFO] [stdout] 390 | | |s: I| String::from_utf8(s.as_bytes().to_vec()) [INFO] [stdout] 391 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:408:1 [INFO] [stdout] | [INFO] [stdout] 394 | pub(crate) fn label_name(input: I) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 408 | / map_res( [INFO] [stdout] 409 | | recognize(tuple(( [INFO] [stdout] 410 | | alt((alpha1, is_a("_"))), [INFO] [stdout] 411 | | many0(alt((alphanumeric1, is_a("_")))), [INFO] [stdout] 412 | | ))), [INFO] [stdout] 413 | | |s: I| String::from_utf8(s.as_bytes().to_vec()) [INFO] [stdout] 414 | | )(input) [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/vec.rs:423:2 [INFO] [stdout] | [INFO] [stdout] 417 | fn label_op(input: I) -> IResult [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 423 | / alt(( [INFO] [stdout] 424 | | value(tag("=~"), LabelMatchOp::REq), [INFO] [stdout] 425 | | value(tag("!~"), LabelMatchOp::RNe), [INFO] [stdout] 426 | | value(tag("="), LabelMatchOp::Eq), // should come after =~ [INFO] [stdout] 427 | | value(tag("!="), LabelMatchOp::Ne), [INFO] [stdout] 428 | | ))(input) [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:19:58 [INFO] [stdout] | [INFO] [stdout] 19 | ($delim:expr, ($first:expr, $($rest:expr),* $(,)?)) => {{ [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 20 | | use nom::sequence::{tuple, preceded}; [INFO] [stdout] 21 | | [INFO] [stdout] 22 | | tuple(( [INFO] [stdout] ... | [INFO] [stdout] 27 | | )) [INFO] [stdout] 28 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] ... [INFO] [stdout] 44 | pub(crate) fn delimited_ws(p1: P1, p2: P2, p3: P3) -> impl FnMut(I) -> IResult [INFO] [stdout] | ------ ------ ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | tuple_separated!(multispace0, (p1, p2, p3)), [INFO] [stdout] | ------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `tuple_separated` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/utils.rs:77:7 [INFO] [stdout] | [INFO] [stdout] 76 | pub(crate) fn err(errors: Vec<(I, VerboseErrorKind)>) -> Result>> { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 77 | Err(Err::Error(VerboseError { errors })) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/whitespace.rs:90:3 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn surrounded_ws_or_comment<'a, I, C, O, P>(opts: &'a ParserOptions, parser: P) -> impl FnMut(I) -> IResult + 'a [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | ws_or_comment(opts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/whitespace.rs:92:3 [INFO] [stdout] | [INFO] [stdout] 71 | pub(crate) fn surrounded_ws_or_comment<'a, I, C, O, P>(opts: &'a ParserOptions, parser: P) -> impl FnMut(I) -> IResult + 'a [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | ws_or_comment(opts), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 18 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `promql` (lib test) due to 19 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "337847b8c88bacd76fab43e3a3d2bbef08dd30148439ffbc585fb98fb4f743d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "337847b8c88bacd76fab43e3a3d2bbef08dd30148439ffbc585fb98fb4f743d7", kill_on_drop: false }` [INFO] [stdout] 337847b8c88bacd76fab43e3a3d2bbef08dd30148439ffbc585fb98fb4f743d7