[INFO] fetching crate prometheus-static-metric 0.5.1... [INFO] checking prometheus-static-metric-0.5.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prometheus-static-metric 0.5.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate prometheus-static-metric 0.5.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prometheus-static-metric 0.5.1 [INFO] finished tweaking crates.io crate prometheus-static-metric 0.5.1 [INFO] tweaked toml for crates.io crate prometheus-static-metric 0.5.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate prometheus-static-metric 0.5.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e49c4be176817b9867ad09aacf53463d5d0c60f6edf67bc314179ae706341601 [INFO] running `Command { std: "docker" "start" "-a" "e49c4be176817b9867ad09aacf53463d5d0c60f6edf67bc314179ae706341601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e49c4be176817b9867ad09aacf53463d5d0c60f6edf67bc314179ae706341601", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e49c4be176817b9867ad09aacf53463d5d0c60f6edf67bc314179ae706341601", kill_on_drop: false }` [INFO] [stdout] e49c4be176817b9867ad09aacf53463d5d0c60f6edf67bc314179ae706341601 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3f9eb4b8941b51786159093a913677d76afffac302fa4a6b601cc5d1c5ac18e0 [INFO] running `Command { std: "docker" "start" "-a" "3f9eb4b8941b51786159093a913677d76afffac302fa4a6b601cc5d1c5ac18e0", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling const_fn v0.4.5 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling rayon-core v1.9.0 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling serde_json v1.0.61 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking thread_local v1.1.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling serde_derive v1.0.118 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Checking smallvec v1.6.0 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Compiling protobuf v2.20.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Checking half v1.6.0 [INFO] [stderr] Compiling prometheus v0.11.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.1 [INFO] [stderr] Compiling memoffset v0.6.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling rayon v1.5.0 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Checking quote v1.0.8 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking regex-automata v0.1.9 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking criterion-plot v0.4.3 [INFO] [stderr] Checking crossbeam-epoch v0.9.1 [INFO] [stderr] Checking crossbeam-channel v0.5.0 [INFO] [stderr] Checking crossbeam-deque v0.8.0 [INFO] [stderr] Checking plotters v0.2.15 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Checking bstr v0.2.14 [INFO] [stderr] Checking serde_cbor v0.11.1 [INFO] [stderr] Checking prometheus-static-metric v0.5.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking csv v1.1.5 [INFO] [stdout] warning: field `span` is never read [INFO] [stdout] --> src/parser.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 12 | struct LabelEnum { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 13 | pub span: Span, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 49 | pub fn make_static_metric(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 50 | let body: StaticMetricMacroBody = syn::parse(input).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 51 | TokensBuilder::build(body).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn make_auto_flush_static_metric(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | let body: StaticMetricMacroBody = syn::parse(input).unwrap(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | AutoFlushTokensBuilder::build(body).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 100 | fn register_static_vec(register_type: &str, input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let invoking: RegisterMethodInvoking = syn::parse(input).unwrap(); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | invoking.into_tokens(register_type).into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/auto_flush_from.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 18 | let source_var_name: Expr = input.parse()?; [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | let flush_duration = if input.peek(Comma) { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | let _: Comma = input.parse()?; [INFO] [stdout] 25 | let res: Expr = input.parse()?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 31 | Ok(AutoFlushFromDef { [INFO] [stdout] | ____________^ [INFO] [stdout] 32 | | class_name, [INFO] [stdout] 33 | | inner_class_name, [INFO] [stdout] 34 | | source_var_name, [INFO] [stdout] 35 | | flush_duration, [INFO] [stdout] 36 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:38:12 [INFO] [stdout] | [INFO] [stdout] 37 | let value = input.parse()?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 38 | Ok(MetricValueDefFull { name, value }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:102:12 [INFO] [stdout] | [INFO] [stdout] 99 | let body; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 100 | let _ = braced!(body in input); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | let p = Punctuated::::parse_terminated(&body)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Ok(MetricValueDefList(p.into_iter().collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:134:12 [INFO] [stdout] | [INFO] [stdout] 130 | let visibility = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | let definitions = input.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 134 | Ok(MetricEnumDef { [INFO] [stdout] | ____________^ [INFO] [stdout] 135 | | visibility, [INFO] [stdout] 136 | | enum_name, [INFO] [stdout] 137 | | definitions, [INFO] [stdout] 138 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:190:12 [INFO] [stdout] | [INFO] [stdout] 183 | let label_key = input.parse()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | let _: FatArrow = input.parse()?; [INFO] [stdout] 185 | let arm = if input.peek(Brace) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 190 | Ok(MetricLabelDef { label_key, arm }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:237:12 [INFO] [stdout] | [INFO] [stdout] 226 | let visibility = input.parse()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 232 | let body; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 233 | let _ = braced!(body in input); [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 234 | let p = Punctuated::::parse_terminated(&body)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 235 | let labels = p.into_iter().collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 236 | [INFO] [stdout] 237 | Ok(MetricDef { [INFO] [stdout] | ____________^ [INFO] [stdout] 238 | | visibility, [INFO] [stdout] 239 | | struct_name, [INFO] [stdout] 240 | | metric_type, [INFO] [stdout] 241 | | labels, [INFO] [stdout] 242 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 269 | let mut items = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(StaticMetricMacroBody { items }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/register_macro.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 18 | let p = Punctuated::::parse_terminated(input)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | let arguments = p.into_iter().collect(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 20 | [INFO] [stdout] 21 | Ok(RegisterMethodInvoking { [INFO] [stdout] | ____________^ [INFO] [stdout] 22 | | static_struct_name, [INFO] [stdout] 23 | | arguments, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 11 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prometheus-static-metric` (lib) due to 12 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "3f9eb4b8941b51786159093a913677d76afffac302fa4a6b601cc5d1c5ac18e0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f9eb4b8941b51786159093a913677d76afffac302fa4a6b601cc5d1c5ac18e0", kill_on_drop: false }` [INFO] [stdout] 3f9eb4b8941b51786159093a913677d76afffac302fa4a6b601cc5d1c5ac18e0