[INFO] fetching crate proj4rs 0.1.3... [INFO] checking proj4rs-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate proj4rs 0.1.3 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate proj4rs 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate proj4rs 0.1.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate proj4rs 0.1.3 [INFO] tweaked toml for crates.io crate proj4rs 0.1.3 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate proj4rs 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `proj4rs` library target) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 477f0bd3ee5d7bdda1f49a1aa1c4e98184c6dfb4ef416277e52b53b7f1d22e08 [INFO] running `Command { std: "docker" "start" "-a" "477f0bd3ee5d7bdda1f49a1aa1c4e98184c6dfb4ef416277e52b53b7f1d22e08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "477f0bd3ee5d7bdda1f49a1aa1c4e98184c6dfb4ef416277e52b53b7f1d22e08", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "477f0bd3ee5d7bdda1f49a1aa1c4e98184c6dfb4ef416277e52b53b7f1d22e08", kill_on_drop: false }` [INFO] [stdout] 477f0bd3ee5d7bdda1f49a1aa1c4e98184c6dfb4ef416277e52b53b7f1d22e08 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d75b40659e3e511296a72a806cec960c62f77bd4b90722e5d136f2296e550efe [INFO] running `Command { std: "docker" "start" "-a" "d75b40659e3e511296a72a806cec960c62f77bd4b90722e5d136f2296e550efe", kill_on_drop: false }` [INFO] [stderr] warning: `crate_type` is deprecated in favor of `crate-type` and will not work in the 2024 edition [INFO] [stderr] (in the `proj4rs` library target) [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking memchr v2.7.2 [INFO] [stderr] Compiling thiserror v1.0.61 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Checking either v1.12.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling thiserror-impl v1.0.61 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking proj4rs v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `rb` and `rf` are never read [INFO] [stdout] --> src/ellps.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 74 | pub struct Ellipsoid { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 79 | pub rb: f64, // 1/b [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 96 | pub rf: f64, // 1/f [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `Ellipsoid` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ellps.rs:169:9 [INFO] [stdout] | [INFO] [stdout] 169 | Self::calc_ellipsoid_params(a, sp).and_then(|ellps| ellps.spherification(params)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ellps.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | Self::calc_ellipsoid_params(a, sp).and_then(|ellps| ellps.spherification(params)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parameters.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 101 | fn from_iter>>(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 102 | Self(iter.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nadgrids/catlg.rs:153:18 [INFO] [stdout] | [INFO] [stdout] 151 | let mut iter = self.iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let node = iter.find(|n| n.name == name); [INFO] [stdout] 153 | node.map(|node| { [INFO] [stdout] | __________________^ [INFO] [stdout] 154 | | std::iter::once(&node.grid).chain(iter.filter(|n| n.is_child_of(node)).map(|n| &n.grid)) [INFO] [stdout] 155 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nadgrids/catlg.rs:154:47 [INFO] [stdout] | [INFO] [stdout] 151 | let mut iter = self.iter(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | std::iter::once(&node.grid).chain(iter.filter(|n| n.is_child_of(node)).map(|n| &n.grid)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nadgrids/catlg.rs:186:15 [INFO] [stdout] | [INFO] [stdout] 185 | let cat = CATALOG.lock().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | match cat.find(name) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nadgrids/catlg.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 203 | pub fn add_grid(name: String, grid: Grid) -> Result<(), Error> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | CATALOG.lock().unwrap().add_grid(name, grid) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/nadgrids/files/ntv2.rs:123:9 [INFO] [stdout] | [INFO] [stdout] 123 | / Grid { [INFO] [stdout] 124 | | id, [INFO] [stdout] 125 | | lineage, [INFO] [stdout] 126 | | ll, [INFO] [stdout] ... | [INFO] [stdout] 131 | | cvs: cvs.into_boxed_slice(), [INFO] [stdout] 132 | | }, [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/proj.rs:315:70 [INFO] [stdout] | [INFO] [stdout] 315 | .and_then(|name| find_projection(name.try_into()?).ok_or(Error::ProjectionNotFound))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `proj4rs` (lib) due to 10 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "d75b40659e3e511296a72a806cec960c62f77bd4b90722e5d136f2296e550efe", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d75b40659e3e511296a72a806cec960c62f77bd4b90722e5d136f2296e550efe", kill_on_drop: false }` [INFO] [stdout] d75b40659e3e511296a72a806cec960c62f77bd4b90722e5d136f2296e550efe