[INFO] fetching crate profi 0.1.2... [INFO] checking profi-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate profi 0.1.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate profi 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate profi 0.1.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate profi 0.1.2 [INFO] tweaked toml for crates.io crate profi 0.1.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate profi 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 89036ad7bf161d1793d472f6a0a71ed82d6203a33126e8fe37178c9dc9bef134 [INFO] running `Command { std: "docker" "start" "-a" "89036ad7bf161d1793d472f6a0a71ed82d6203a33126e8fe37178c9dc9bef134", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "89036ad7bf161d1793d472f6a0a71ed82d6203a33126e8fe37178c9dc9bef134", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "89036ad7bf161d1793d472f6a0a71ed82d6203a33126e8fe37178c9dc9bef134", kill_on_drop: false }` [INFO] [stdout] 89036ad7bf161d1793d472f6a0a71ed82d6203a33126e8fe37178c9dc9bef134 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 277ec207384e8d066a3b2b8f2ab3a199d6294705df96dc332da817b68a6777ac [INFO] running `Command { std: "docker" "start" "-a" "277ec207384e8d066a3b2b8f2ab3a199d6294705df96dc332da817b68a6777ac", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling rustversion v1.0.14 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking strum v0.25.0 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking beef v0.5.2 [INFO] [stderr] Compiling akin v0.4.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling syn v2.0.57 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Compiling strum_macros v0.25.3 [INFO] [stderr] Compiling profi-attributes v0.1.2 [INFO] [stderr] Checking comfy-table v7.1.0 [INFO] [stderr] Compiling ctor v0.1.26 [INFO] [stderr] Checking minstant v0.1.7 [INFO] [stderr] Checking profi v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/measure.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn print_timings(&self, to: impl std::io::Write) -> std::io::Result<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | crate::process::print_timings(self.measures.read().unwrap().as_slice(), to) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 25 | name: impl Into, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | formatted_name: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | name: name.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 25 | name: impl Into, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | formatted_name: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | formatted_name: formatted_name.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 130 | fn to_timings(&self, name: Str, total: std::time::Duration, thread: usize) -> Vec { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let timing = Timing::from_durations(name, formatted_name, &self.measures, total, thread); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / std::iter::once(timing) [INFO] [stdout] 144 | | .chain( [INFO] [stdout] 145 | | self.children [INFO] [stdout] 146 | | .iter() [INFO] [stdout] 147 | | .flat_map(|(name, child)| child.to_timings(name.clone(), total, thread)), [INFO] [stdout] 148 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:147:64 [INFO] [stdout] | [INFO] [stdout] 147 | .flat_map(|(name, child)| child.to_timings(name.clone(), total, thread)), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:168:54 [INFO] [stdout] | [INFO] [stdout] 168 | .flat_map(|(name, node)| node.to_timings(name.clone(), total_thread, i)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zz_private.rs:18:78 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | #[cfg(feature = "enable")] [INFO] [stdout] 18 | crate::measure::THREAD_PROFILER.with_borrow_mut(|thread| thread.push(name.into())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/measure.rs:56:39 [INFO] [stdout] | [INFO] [stdout] 55 | pub(crate) fn print_timings(&self, to: impl std::io::Write) -> std::io::Result<()> { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 56 | crate::process::print_timings(self.measures.read().unwrap().as_slice(), to) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:39:19 [INFO] [stdout] | [INFO] [stdout] 25 | name: impl Into, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | formatted_name: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | name: name.into(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:40:29 [INFO] [stdout] | [INFO] [stdout] 25 | name: impl Into, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | formatted_name: impl Into, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 40 | formatted_name: formatted_name.into(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 130 | fn to_timings(&self, name: Str, total: std::time::Duration, thread: usize) -> Vec { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | let timing = Timing::from_durations(name, formatted_name, &self.measures, total, thread); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / std::iter::once(timing) [INFO] [stdout] 144 | | .chain( [INFO] [stdout] 145 | | self.children [INFO] [stdout] 146 | | .iter() [INFO] [stdout] 147 | | .flat_map(|(name, child)| child.to_timings(name.clone(), total, thread)), [INFO] [stdout] 148 | | ) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:147:64 [INFO] [stdout] | [INFO] [stdout] 147 | .flat_map(|(name, child)| child.to_timings(name.clone(), total, thread)), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:168:54 [INFO] [stdout] | [INFO] [stdout] 168 | .flat_map(|(name, node)| node.to_timings(name.clone(), total_thread, i)); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/zz_private.rs:18:78 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn new(name: impl Into) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | #[cfg(feature = "enable")] [INFO] [stdout] 18 | crate::measure::THREAD_PROFILER.with_borrow_mut(|thread| thread.push(name.into())); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `profi` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `profi` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "277ec207384e8d066a3b2b8f2ab3a199d6294705df96dc332da817b68a6777ac", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "277ec207384e8d066a3b2b8f2ab3a199d6294705df96dc332da817b68a6777ac", kill_on_drop: false }` [INFO] [stdout] 277ec207384e8d066a3b2b8f2ab3a199d6294705df96dc332da817b68a6777ac