[INFO] fetching crate product-os-request 0.0.38... [INFO] checking product-os-request-0.0.38 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate product-os-request 0.0.38 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate product-os-request 0.0.38 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate product-os-request 0.0.38 [INFO] finished tweaking crates.io crate product-os-request 0.0.38 [INFO] tweaked toml for crates.io crate product-os-request 0.0.38 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 149 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding base64 v0.21.7 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding cookie v0.17.0 (latest: v0.18.1) [INFO] [stderr] Adding cookie_store v0.20.0 (latest: v0.21.0) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding h2 v0.3.26 (latest: v0.4.6) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding http v0.2.12 (latest: v1.1.0) [INFO] [stderr] Adding http-body v0.4.6 (latest: v1.0.1) [INFO] [stderr] Adding hyper v0.14.30 (latest: v1.4.1) [INFO] [stderr] Adding hyper-rustls v0.24.2 (latest: v0.27.2) [INFO] [stderr] Adding idna v0.3.0 (latest: v1.0.2) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding reqwest v0.11.27 (latest: v0.12.7) [INFO] [stderr] Adding rustls v0.21.12 (latest: v0.23.12) [INFO] [stderr] Adding rustls-pemfile v1.0.4 (latest: v2.1.3) [INFO] [stderr] Adding rustls-webpki v0.101.7 (latest: v0.102.7) [INFO] [stderr] Adding sync_wrapper v0.1.2 (latest: v1.0.1) [INFO] [stderr] Adding system-configuration v0.5.1 (latest: v0.6.1) [INFO] [stderr] Adding system-configuration-sys v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding tokio-rustls v0.24.1 (latest: v0.26.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding webpki-roots v0.25.4 (latest: v0.26.5) [INFO] [stderr] Adding windows-sys v0.48.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] [stderr] Adding windows-targets v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_aarch64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_i686_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnu v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_gnullvm v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding windows_x86_64_msvc v0.48.5 (latest: v0.52.6) [INFO] [stderr] Adding winreg v0.50.0 (latest: v0.52.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1ed45ed8a6e55c9fc4847d4f20da3b9de9cf6beb2e51a04b7fa7cea97d706b06 [INFO] running `Command { std: "docker" "start" "-a" "1ed45ed8a6e55c9fc4847d4f20da3b9de9cf6beb2e51a04b7fa7cea97d706b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1ed45ed8a6e55c9fc4847d4f20da3b9de9cf6beb2e51a04b7fa7cea97d706b06", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1ed45ed8a6e55c9fc4847d4f20da3b9de9cf6beb2e51a04b7fa7cea97d706b06", kill_on_drop: false }` [INFO] [stdout] 1ed45ed8a6e55c9fc4847d4f20da3b9de9cf6beb2e51a04b7fa7cea97d706b06 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a131c60ea265bb5eabbd09cd4191e13a3899a16f4a7439377d8f0d913ed75ce8 [INFO] running `Command { std: "docker" "start" "-a" "a131c60ea265bb5eabbd09cd4191e13a3899a16f4a7439377d8f0d913ed75ce8", kill_on_drop: false }` [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking alloc-no-stdlib v2.0.4 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Compiling time-macros v0.2.18 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking alloc-stdlib v0.2.2 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Compiling cookie v0.17.0 [INFO] [stderr] Compiling core-error v0.0.1-rc4 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking brotli-decompressor v4.0.1 [INFO] [stderr] Checking psl-types v2.0.11 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking no-std-compat v0.4.1 [INFO] [stderr] Checking webpki-roots v0.25.4 [INFO] [stderr] Checking product-os-http v0.0.7 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking publicsuffix v2.2.3 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking brotli v6.0.0 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking product-os-http-body v0.0.14 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking async-compression v0.4.12 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking cookie_store v0.20.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stderr] Checking product-os-request v0.0.38 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `product_os_http::request` [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | use product_os_http::request; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | use bytes::Bytes; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Bytes` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use product_os_http_body::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | use bytes::Bytes; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `product_os_http::request` [INFO] [stdout] --> src/lib.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 30 | use product_os_http::request; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: private item shadows public glob re-export [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | use bytes::Bytes; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the name `Bytes` in the type namespace is supposed to be publicly re-exported here [INFO] [stdout] --> src/lib.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | pub use product_os_http_body::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: but the private item here shadows it [INFO] [stdout] --> src/lib.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | use bytes::Bytes; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(hidden_glob_reexports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:355:25 [INFO] [stdout] | [INFO] [stdout] 355 | Err(e) => { tracing::error!("Invalid bearer auth for header"); } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:334:13 [INFO] [stdout] | [INFO] [stdout] 334 | let mut uri = match Uri::from_str(url.as_str()) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:355:25 [INFO] [stdout] | [INFO] [stdout] 355 | Err(e) => { tracing::error!("Invalid bearer auth for header"); } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:334:13 [INFO] [stdout] | [INFO] [stdout] 334 | let mut uri = match Uri::from_str(url.as_str()) { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:1150:33 [INFO] [stdout] | [INFO] [stdout] 1150 | ... Err(e) => { product_os_http_body::BodyBytes::new(Bytes::new()) } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:1170:33 [INFO] [stdout] | [INFO] [stdout] 1170 | ... Err(e) => { product_os_http_body::BodyBytes::new(Bytes::new()) } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:1190:33 [INFO] [stdout] | [INFO] [stdout] 1190 | ... Err(e) => { product_os_http_body::BodyBytes::new(Bytes::new()) } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `content_type` is never read [INFO] [stdout] --> src/lib.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 154 | pub struct ProductOSRequest { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 165 | content_type: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `build` is never used [INFO] [stdout] --> src/lib.rs:305:8 [INFO] [stdout] | [INFO] [stdout] 170 | impl ProductOSRequest { [INFO] [stdout] | ------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 305 | fn build(self) -> Result, ProductOSRequestError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `new_request`, `request`, `request_simple`, and `request_raw` are never used [INFO] [stdout] --> src/lib.rs:569:8 [INFO] [stdout] | [INFO] [stdout] 485 | impl ProductOSRequester { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 569 | fn new_request(&self, method: Method, url: String, client: &mut i... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | async fn request(&self, r: ProductOSRequest, client: &mut i... [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 577 | async fn request_simple(&self, method: Method, url: &str, client:... [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 581 | async fn request_raw(&self, r: Request, client: &mut impl P... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:22 [INFO] [stdout] | [INFO] [stdout] 172 | let uri = match Uri::from_str(url.as_str()) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Ok(u) => u, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | headers: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:19 [INFO] [stdout] | [INFO] [stdout] 172 | let uri = match Uri::from_str(url.as_str()) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Ok(u) => u, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | body: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:263:19 [INFO] [stdout] | [INFO] [stdout] 195 | fn from_request(r: Request) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let uri = r.uri().to_owned(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut headers = BTreeMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let body = r.into_body(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | body: Some(body), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:393:29 [INFO] [stdout] | [INFO] [stdout] 390 | pub fn new(r: DRes, url: String) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | response_async: Some(Response::new(r)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1009:15 [INFO] [stdout] | [INFO] [stdout] 958 | fn build_request(&self, request: ProductOSRequest) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1142:168 [INFO] [stdout] | [INFO] [stdout] 1142 | async fn request(&self, r: ProductOSRequest) -> Result, ProductOSRequestError> { [INFO] [stdout] | _____________________________----------------------------------------------------_______________________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1143 | | match self.build_request(r) { [INFO] [stdout] 1144 | | Ok(request) => { [INFO] [stdout] 1145 | | match self.client.execute(request).await { [INFO] [stdout] ... | [INFO] [stdout] 1158 | | } [INFO] [stdout] 1159 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1181:163 [INFO] [stdout] | [INFO] [stdout] 1181 | async fn request_raw(&self, r: Request) -> Result, ProductOSRequestError> { [INFO] [stdout] | _________________________________-------------------------------------------_______________________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1182 | | let req = ProductOSRequest::from_request(r); [INFO] [stdout] 1183 | | match self.build_request(req) { [INFO] [stdout] 1184 | | Ok(request) => { [INFO] [stdout] ... | [INFO] [stdout] 1198 | | } [INFO] [stdout] 1199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1215:122 [INFO] [stdout] | [INFO] [stdout] 1215 | async fn text(&self, r: ProductOSResponse) -> Result { [INFO] [stdout] | __________________________-----------------------------------------------------___________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1216 | | match r.response_async { [INFO] [stdout] 1217 | | Some(res) => { [INFO] [stdout] 1218 | | match ::clone(&res.body()).collect().await { [INFO] [stdout] ... | [INFO] [stdout] 1229 | | } [INFO] [stdout] 1230 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1255:129 [INFO] [stdout] | [INFO] [stdout] 1255 | async fn bytes(&self, r: ProductOSResponse) -> Result { [INFO] [stdout] | ___________________________-----------------------------------------------------_________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1256 | | match r.response_async { [INFO] [stdout] 1257 | | Some(res) => { [INFO] [stdout] 1258 | | match ::clone(&res.body()).collect().await { [INFO] [stdout] ... | [INFO] [stdout] 1264 | | } [INFO] [stdout] 1265 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:1150:33 [INFO] [stdout] | [INFO] [stdout] 1150 | ... Err(e) => { product_os_http_body::BodyBytes::new(Bytes::new()) } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `product-os-request` (lib) due to 10 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:1170:33 [INFO] [stdout] | [INFO] [stdout] 1170 | ... Err(e) => { product_os_http_body::BodyBytes::new(Bytes::new()) } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/lib.rs:1190:33 [INFO] [stdout] | [INFO] [stdout] 1190 | ... Err(e) => { product_os_http_body::BodyBytes::new(Bytes::new()) } [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `content_type` is never read [INFO] [stdout] --> src/lib.rs:165:5 [INFO] [stdout] | [INFO] [stdout] 154 | pub struct ProductOSRequest { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 165 | content_type: Option, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `build` is never used [INFO] [stdout] --> src/lib.rs:305:8 [INFO] [stdout] | [INFO] [stdout] 170 | impl ProductOSRequest { [INFO] [stdout] | ------------------------------------------------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 305 | fn build(self) -> Result, ProductOSRequestError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `new_request`, `request`, `request_simple`, and `request_raw` are never used [INFO] [stdout] --> src/lib.rs:569:8 [INFO] [stdout] | [INFO] [stdout] 485 | impl ProductOSRequester { [INFO] [stdout] | ----------------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 569 | fn new_request(&self, method: Method, url: String, client: &mut i... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 573 | async fn request(&self, r: ProductOSRequest, client: &mut i... [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 577 | async fn request_simple(&self, method: Method, url: &str, client:... [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 581 | async fn request_raw(&self, r: Request, client: &mut impl P... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:184:22 [INFO] [stdout] | [INFO] [stdout] 172 | let uri = match Uri::from_str(url.as_str()) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Ok(u) => u, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 184 | headers: BTreeMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:189:19 [INFO] [stdout] | [INFO] [stdout] 172 | let uri = match Uri::from_str(url.as_str()) { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Ok(u) => u, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 189 | body: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:263:19 [INFO] [stdout] | [INFO] [stdout] 195 | fn from_request(r: Request) -> Self { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | let uri = r.uri().to_owned(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 199 | let mut headers = BTreeMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let body = r.into_body(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 263 | body: Some(body), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:393:29 [INFO] [stdout] | [INFO] [stdout] 390 | pub fn new(r: DRes, url: String) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 393 | response_async: Some(Response::new(r)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1009:15 [INFO] [stdout] | [INFO] [stdout] 958 | fn build_request(&self, request: ProductOSRequest) -> Result [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1142:168 [INFO] [stdout] | [INFO] [stdout] 1142 | async fn request(&self, r: ProductOSRequest) -> Result, ProductOSRequestError> { [INFO] [stdout] | _____________________________----------------------------------------------------_______________________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1143 | | match self.build_request(r) { [INFO] [stdout] 1144 | | Ok(request) => { [INFO] [stdout] 1145 | | match self.client.execute(request).await { [INFO] [stdout] ... | [INFO] [stdout] 1158 | | } [INFO] [stdout] 1159 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1181:163 [INFO] [stdout] | [INFO] [stdout] 1181 | async fn request_raw(&self, r: Request) -> Result, ProductOSRequestError> { [INFO] [stdout] | _________________________________-------------------------------------------_______________________________________________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1182 | | let req = ProductOSRequest::from_request(r); [INFO] [stdout] 1183 | | match self.build_request(req) { [INFO] [stdout] 1184 | | Ok(request) => { [INFO] [stdout] ... | [INFO] [stdout] 1198 | | } [INFO] [stdout] 1199 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1215:122 [INFO] [stdout] | [INFO] [stdout] 1215 | async fn text(&self, r: ProductOSResponse) -> Result { [INFO] [stdout] | __________________________-----------------------------------------------------___________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1216 | | match r.response_async { [INFO] [stdout] 1217 | | Some(res) => { [INFO] [stdout] 1218 | | match ::clone(&res.body()).collect().await { [INFO] [stdout] ... | [INFO] [stdout] 1229 | | } [INFO] [stdout] 1230 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1255:129 [INFO] [stdout] | [INFO] [stdout] 1255 | async fn bytes(&self, r: ProductOSResponse) -> Result { [INFO] [stdout] | ___________________________-----------------------------------------------------_________________________________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 1256 | | match r.response_async { [INFO] [stdout] 1257 | | Some(res) => { [INFO] [stdout] 1258 | | match ::clone(&res.body()).collect().await { [INFO] [stdout] ... | [INFO] [stdout] 1264 | | } [INFO] [stdout] 1265 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `product-os-request` (lib test) due to 10 previous errors; 10 warnings emitted [INFO] running `Command { std: "docker" "inspect" "a131c60ea265bb5eabbd09cd4191e13a3899a16f4a7439377d8f0d913ed75ce8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a131c60ea265bb5eabbd09cd4191e13a3899a16f4a7439377d8f0d913ed75ce8", kill_on_drop: false }` [INFO] [stdout] a131c60ea265bb5eabbd09cd4191e13a3899a16f4a7439377d8f0d913ed75ce8