[INFO] fetching crate prima_datadog 0.8.0... [INFO] checking prima_datadog-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prima_datadog 0.8.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate prima_datadog 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prima_datadog 0.8.0 [INFO] finished tweaking crates.io crate prima_datadog 0.8.0 [INFO] tweaked toml for crates.io crate prima_datadog 0.8.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 113 packages to latest compatible versions [INFO] [stderr] Adding anes v0.1.6 (latest: v0.2.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding mockall v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding mockall_derive v0.12.1 (latest: v0.13.0) [INFO] [stderr] Adding termtree v0.4.1 (latest: v0.5.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9e606b9381da0a02360011cbe18c1d8043d428f0324d5aaec74bd44d08bfc270 [INFO] running `Command { std: "docker" "start" "-a" "9e606b9381da0a02360011cbe18c1d8043d428f0324d5aaec74bd44d08bfc270", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9e606b9381da0a02360011cbe18c1d8043d428f0324d5aaec74bd44d08bfc270", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9e606b9381da0a02360011cbe18c1d8043d428f0324d5aaec74bd44d08bfc270", kill_on_drop: false }` [INFO] [stdout] 9e606b9381da0a02360011cbe18c1d8043d428f0324d5aaec74bd44d08bfc270 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 5c871ab4dd117704d299bc831a265e191957ad770ed068905a112dc1f8f475ec [INFO] running `Command { std: "docker" "start" "-a" "5c871ab4dd117704d299bc831a265e191957ad770ed068905a112dc1f8f475ec", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking plotters-backend v0.3.6 [INFO] [stderr] Checking predicates-core v1.0.8 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking clap_builder v4.5.15 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking sdd v3.0.2 [INFO] [stderr] Checking termtree v0.4.1 [INFO] [stderr] Compiling mockall_derive v0.12.1 [INFO] [stderr] Compiling serial_test_derive v3.1.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking predicates-tree v1.0.11 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking predicates v3.1.2 [INFO] [stderr] Checking scc v2.1.16 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking fragile v2.0.0 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking plotters-svg v0.3.6 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking plotters v0.3.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking clap v4.5.16 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking serial_test v3.1.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking retry v2.0.0 [INFO] [stderr] Checking mockall v0.12.1 [INFO] [stderr] Checking dogstatsd v0.11.1 [INFO] [stderr] Checking prima_datadog v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:187:16 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn init(mut configuration: Configuration) -> Result<(), Error> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 183 | let tracker_config = configuration.take_tracker_config(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | let client: dogstatsd::Client = dogstatsd::Client::new(dogstatsd_client_options)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 187 | Ok(Self::new(client, tracker_config)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:313:26 [INFO] [stdout] | [INFO] [stdout] 310 | fn new(client: C, tracker_config: TagTrackerConfiguration) -> Self { [INFO] [stdout] | --------- --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 313 | tag_tracker: tracker_config.build(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:346:13 [INFO] [stdout] | [INFO] [stdout] 339 | pub(crate) fn do_time(&self, metric: impl AsRef, tags: impl TagsProvider, block: F) -> O [INFO] [stdout] | ----------------------- -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 346 | self.tag_tracker.track(&self.inner, metric.as_ref(), tags), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prima_datadog` (lib) due to 8 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:108:9 [INFO] [stdout] | [INFO] [stdout] 103 | fn time(&self, metric: &str, tags: impl TagsProvider, block: F) -> O [INFO] [stdout] | -------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | self.time(metric, tags.as_ref(), block).unwrap_or_else(|(o, _)| o) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:116:5 [INFO] [stdout] | [INFO] [stdout] 111 | async fn async_time(&self, metric: &str, tags: impl TagsProvider + Send + Sync, block: F) -> O [INFO] [stdout] | ---------------------------------------- -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | / { [INFO] [stdout] 117 | | self.async_time(metric, tags.as_ref(), block) [INFO] [stdout] 118 | | .await [INFO] [stdout] 119 | | .unwrap_or_else(|(o, _)| o) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracker.rs:37:20 [INFO] [stdout] | [INFO] [stdout] 34 | fn new(cardinality_threshold: usize, actions: Vec) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | state: if !actions.is_empty() && cardinality_threshold != 0 { [INFO] [stdout] | ____________________^ [INFO] [stdout] 38 | | Some(Mutex::new(TrackerState::Running { [INFO] [stdout] 39 | | actions, [INFO] [stdout] 40 | | seen: Default::default(), [INFO] [stdout] ... | [INFO] [stdout] 44 | | None [INFO] [stdout] 45 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tracker.rs:124:44 [INFO] [stdout] | [INFO] [stdout] 124 | .map(|(metric, sets)| (metric, sets.into_iter().map(|set| set.into_iter().collect()).collect())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "5c871ab4dd117704d299bc831a265e191957ad770ed068905a112dc1f8f475ec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c871ab4dd117704d299bc831a265e191957ad770ed068905a112dc1f8f475ec", kill_on_drop: false }` [INFO] [stdout] 5c871ab4dd117704d299bc831a265e191957ad770ed068905a112dc1f8f475ec