[INFO] fetching crate prew 0.3.3... [INFO] checking prew-0.3.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prew 0.3.3 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate prew 0.3.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prew 0.3.3 [INFO] finished tweaking crates.io crate prew 0.3.3 [INFO] tweaked toml for crates.io crate prew 0.3.3 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate prew 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 710d19317eb9053307ee1c252b12aa1f18cfabb1e3a17cb69674c3b9c65fbedb [INFO] running `Command { std: "docker" "start" "-a" "710d19317eb9053307ee1c252b12aa1f18cfabb1e3a17cb69674c3b9c65fbedb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "710d19317eb9053307ee1c252b12aa1f18cfabb1e3a17cb69674c3b9c65fbedb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "710d19317eb9053307ee1c252b12aa1f18cfabb1e3a17cb69674c3b9c65fbedb", kill_on_drop: false }` [INFO] [stdout] 710d19317eb9053307ee1c252b12aa1f18cfabb1e3a17cb69674c3b9c65fbedb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b1c9725e298c99e6c61abd49593d382e8deebcc5d30ef3a2a5d5ec36c2a27e3e [INFO] running `Command { std: "docker" "start" "-a" "b1c9725e298c99e6c61abd49593d382e8deebcc5d30ef3a2a5d5ec36c2a27e3e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.78 [INFO] [stderr] Compiling libc v0.2.152 [INFO] [stderr] Compiling either v1.9.0 [INFO] [stderr] Compiling rustix v0.38.30 [INFO] [stderr] Compiling anyhow v1.0.79 [INFO] [stderr] Compiling cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling bitflags v2.4.2 [INFO] [stderr] Compiling linux-raw-sys v0.4.13 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Checking bytes v1.5.0 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling serde v1.0.195 [INFO] [stderr] Checking subtle v2.5.0 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Compiling prettyplease v0.2.16 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling lock_api v0.4.11 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Compiling parking_lot_core v0.9.9 [INFO] [stderr] Compiling hashbrown v0.14.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling libloading v0.8.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Compiling serde_json v1.0.111 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling bindgen v0.66.1 [INFO] [stderr] Compiling log v0.4.20 [INFO] [stderr] Compiling fastrand v2.0.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling indexmap v2.1.0 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling lazycell v1.3.0 [INFO] [stderr] Compiling multimap v0.8.3 [INFO] [stderr] Checking finl_unicode v1.2.0 [INFO] [stderr] Compiling shlex v1.2.0 [INFO] [stderr] Checking ryu v1.0.16 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Compiling syn v2.0.48 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling cc v1.0.83 [INFO] [stderr] Checking getrandom v0.2.12 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Checking socket2 v0.5.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking mio v0.8.10 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Compiling petgraph v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking stringprep v0.1.4 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Compiling thiserror v1.0.56 [INFO] [stderr] Compiling async-trait v0.1.77 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking whoami v1.4.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.9.0 [INFO] [stderr] Checking postgres-protocol v0.6.6 [INFO] [stderr] Compiling prost-build v0.10.4 [INFO] [stderr] Compiling regex-automata v0.4.3 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling prost-derive v0.10.1 [INFO] [stderr] Compiling regex v1.10.2 [INFO] [stderr] Compiling prost v0.10.4 [INFO] [stderr] Compiling prost-types v0.10.1 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.195 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling postgres-derive v0.4.5 [INFO] [stderr] Compiling thiserror-impl v1.0.56 [INFO] [stderr] Checking tokio v1.35.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.10 [INFO] [stderr] Compiling pg_query v0.8.2 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking postgres-types v0.2.6 [INFO] [stderr] Checking tokio-postgres v0.7.10 [INFO] [stderr] Checking prew v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/postgresql.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | let mut auth_guard = context.authinfo(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/postgresql.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | let mut auth_guard = context.authinfo(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/postgresql.rs:44:25 [INFO] [stdout] | [INFO] [stdout] 44 | let mut auth_guard = context.authinfo(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/postgresql.rs:61:29 [INFO] [stdout] | [INFO] [stdout] 61 | let mut auth_guard = context.authinfo(); [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `packet_handler` is never read [INFO] [stdout] --> src/pipe.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Pipe { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 15 | name: String, [INFO] [stdout] 16 | packet_handler: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:29 [INFO] [stdout] | [INFO] [stdout] 133 | .map(|listener| listener.accept().boxed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `packet_handler` is never read [INFO] [stdout] --> src/pipe.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub struct Pipe { [INFO] [stdout] | ---- field in this struct [INFO] [stdout] 15 | name: String, [INFO] [stdout] 16 | packet_handler: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 102 | let context = (self.create_context)(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let session = RuleSetSession::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Arc::new(Mutex::new(session)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:29 [INFO] [stdout] | [INFO] [stdout] 133 | .map(|listener| listener.accept().boxed()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rule.rs:112:18 [INFO] [stdout] | [INFO] [stdout] 102 | let context = (self.create_context)(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | let session = RuleSetSession::new( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | Arc::new(Mutex::new(session)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prew` (lib) due to 3 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `prew` (lib test) due to 3 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b1c9725e298c99e6c61abd49593d382e8deebcc5d30ef3a2a5d5ec36c2a27e3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b1c9725e298c99e6c61abd49593d382e8deebcc5d30ef3a2a5d5ec36c2a27e3e", kill_on_drop: false }` [INFO] [stdout] b1c9725e298c99e6c61abd49593d382e8deebcc5d30ef3a2a5d5ec36c2a27e3e