[INFO] fetching crate prettyprint 0.8.1... [INFO] checking prettyprint-0.8.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prettyprint 0.8.1 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate prettyprint 0.8.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prettyprint 0.8.1 [INFO] finished tweaking crates.io crate prettyprint 0.8.1 [INFO] tweaked toml for crates.io crate prettyprint 0.8.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate prettyprint 0.8.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b14ecf5d6103e6a01ab7117a332d8284bc4b3dc4cc1776adc8b3916af862695e [INFO] running `Command { std: "docker" "start" "-a" "b14ecf5d6103e6a01ab7117a332d8284bc4b3dc4cc1776adc8b3916af862695e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b14ecf5d6103e6a01ab7117a332d8284bc4b3dc4cc1776adc8b3916af862695e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b14ecf5d6103e6a01ab7117a332d8284bc4b3dc4cc1776adc8b3916af862695e", kill_on_drop: false }` [INFO] [stdout] b14ecf5d6103e6a01ab7117a332d8284bc4b3dc4cc1776adc8b3916af862695e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2e6e3fc38bb2f1568e25c744c4bdc9e118b1ae438ba7f993b96c74b31adf3257 [INFO] running `Command { std: "docker" "start" "-a" "2e6e3fc38bb2f1568e25c744c4bdc9e118b1ae438ba7f993b96c74b31adf3257", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.68 [INFO] [stderr] Compiling cc v1.0.50 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Compiling proc-macro2 v1.0.10 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling glob v0.3.0 [INFO] [stderr] Compiling unicode-xid v0.2.0 [INFO] [stderr] Compiling rustc-demangle v0.1.16 [INFO] [stderr] Compiling syn v1.0.17 [INFO] [stderr] Compiling log v0.4.8 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling quick-error v1.2.3 [INFO] [stderr] Compiling thread_local v1.0.1 [INFO] [stderr] Compiling unicode-width v0.1.7 [INFO] [stderr] Compiling regex-syntax v0.6.17 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling termcolor v1.1.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Compiling vec_map v0.8.1 [INFO] [stderr] Compiling clang-sys v0.28.1 [INFO] [stderr] Compiling bindgen v0.50.1 [INFO] [stderr] Compiling ansi_term v0.11.0 [INFO] [stderr] Checking encoding_index_tests v0.1.4 [INFO] [stderr] Compiling aho-corasick v0.7.10 [INFO] [stderr] Compiling fxhash v0.2.1 [INFO] [stderr] Compiling serde v1.0.106 [INFO] [stderr] Compiling shlex v0.1.1 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Compiling pkg-config v0.3.17 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling fnv v1.0.6 [INFO] [stderr] Compiling strsim v0.9.3 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling autocfg v1.0.0 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.3 [INFO] [stderr] Compiling ryu v1.0.3 [INFO] [stderr] Compiling clap v2.33.0 [INFO] [stderr] Compiling crc32fast v1.2.0 [INFO] [stderr] Checking safemem v0.3.3 [INFO] [stderr] Checking adler32 v1.0.4 [INFO] [stderr] Compiling indexmap v1.3.2 [INFO] [stderr] Compiling version_check v0.9.1 [INFO] [stderr] Checking miniz_oxide v0.3.6 [INFO] [stderr] Compiling backtrace-sys v0.1.35 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling ansi_colours v1.0.1 [INFO] [stderr] Checking line-wrap v0.1.1 [INFO] [stderr] Compiling cexpr v0.3.6 [INFO] [stderr] Compiling error-chain v0.12.2 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking humantime v2.0.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking itoa v0.4.5 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking xml-rs v0.8.1 [INFO] [stderr] Checking walkdir v2.3.1 [INFO] [stderr] Checking flate2 v1.0.14 [INFO] [stderr] Checking dirs-sys v0.3.4 [INFO] [stderr] Checking termios v0.3.1 [INFO] [stderr] Checking clicolors-control v1.0.1 [INFO] [stderr] Checking encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Checking encoding-index-japanese v1.20141219.5 [INFO] [stderr] Checking encoding-index-korean v1.20141219.5 [INFO] [stderr] Checking encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Checking encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Checking lazycell v1.2.1 [INFO] [stderr] Compiling regex v1.3.6 [INFO] [stderr] Checking directories v2.0.2 [INFO] [stderr] Checking content_inspector v0.2.4 [INFO] [stderr] Checking shell-words v0.1.0 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling backtrace v0.3.46 [INFO] [stderr] Checking encoding v0.2.33 [INFO] [stderr] Compiling failure v0.1.7 [INFO] [stderr] Compiling which v2.0.1 [INFO] [stderr] Checking console v0.10.0 [INFO] [stderr] Compiling env_logger v0.6.2 [INFO] [stderr] Checking serde_json v1.0.50 [INFO] [stderr] Checking bincode v1.2.1 [INFO] [stderr] Checking plist v0.5.3 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling serde_derive v1.0.106 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Compiling onig_sys v69.2.0 [INFO] [stderr] Checking onig v5.0.0 [INFO] [stderr] Checking syntect v4.1.0 [INFO] [stderr] Checking prettyprint v0.8.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 28 | let syntax_set_file = File::open(&syntax_set_path()).chain_err(|| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let syntax_set: SyntaxSet = from_reader(BufReader::new(syntax_set_file)) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let theme_set_file = File::open(&theme_set_path).chain_err(|| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(HighlightingAssets { [INFO] [stdout] | ____________^ [INFO] [stdout] 47 | | syntax_set, [INFO] [stdout] 48 | | theme_set, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:228:15 [INFO] [stdout] | [INFO] [stdout] 225 | let syntax_set = self.load_syntax.as_ref().map(|b| from_binary(b.as_slice())); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | match (syntax_set, theme_set) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inputfile.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 15 | fn new(mut reader: R) -> InputFileReader<'a> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | inner: Box::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/assets.rs:46:12 [INFO] [stdout] | [INFO] [stdout] 28 | let syntax_set_file = File::open(&syntax_set_path()).chain_err(|| { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let syntax_set: SyntaxSet = from_reader(BufReader::new(syntax_set_file)) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 37 | let theme_set_file = File::open(&theme_set_path).chain_err(|| { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | Ok(HighlightingAssets { [INFO] [stdout] | ____________^ [INFO] [stdout] 47 | | syntax_set, [INFO] [stdout] 48 | | theme_set, [INFO] [stdout] 49 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/builder.rs:228:15 [INFO] [stdout] | [INFO] [stdout] 225 | let syntax_set = self.load_syntax.as_ref().map(|b| from_binary(b.as_slice())); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | match (syntax_set, theme_set) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/inputfile.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 15 | fn new(mut reader: R) -> InputFileReader<'a> { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | inner: Box::new(reader), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/line_range.rs:145:40 [INFO] [stdout] | [INFO] [stdout] 145 | LineRanges::from(rs.iter().map(|r| LineRange::from(r).unwrap()).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:103:38 [INFO] [stdout] | [INFO] [stdout] 103 | let print_heading = |string| printer.string(format!("## {}", string)).expect("Printed"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prettyprint` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `prettyprint` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "2e6e3fc38bb2f1568e25c744c4bdc9e118b1ae438ba7f993b96c74b31adf3257", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e6e3fc38bb2f1568e25c744c4bdc9e118b1ae438ba7f993b96c74b31adf3257", kill_on_drop: false }` [INFO] [stdout] 2e6e3fc38bb2f1568e25c744c4bdc9e118b1ae438ba7f993b96c74b31adf3257