[INFO] fetching crate preftool-clap-derive 0.2.0... [INFO] checking preftool-clap-derive-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate preftool-clap-derive 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate preftool-clap-derive 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate preftool-clap-derive 0.2.0 [INFO] finished tweaking crates.io crate preftool-clap-derive 0.2.0 [INFO] tweaked toml for crates.io crate preftool-clap-derive 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 50 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding crossbeam v0.2.12 (latest: v0.8.4) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding proc-macro2 v0.4.30 (latest: v1.0.86) [INFO] [stderr] Adding quote v0.6.13 (latest: v1.0.37) [INFO] [stderr] Adding slog-stdlog v3.0.5 (latest: v4.1.1) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v0.15.44 (latest: v2.0.77) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding unicode-xid v0.1.0 (latest: v0.2.5) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e208c70777a9246592f76e933d1ea5e3f73cbb2a9266d3ffb2a29a5886cdb50 [INFO] running `Command { std: "docker" "start" "-a" "6e208c70777a9246592f76e933d1ea5e3f73cbb2a9266d3ffb2a29a5886cdb50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e208c70777a9246592f76e933d1ea5e3f73cbb2a9266d3ffb2a29a5886cdb50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e208c70777a9246592f76e933d1ea5e3f73cbb2a9266d3ffb2a29a5886cdb50", kill_on_drop: false }` [INFO] [stdout] 6e208c70777a9246592f76e933d1ea5e3f73cbb2a9266d3ffb2a29a5886cdb50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9f9d63d67eca70ff9f23629212a7c59f822e42c095714b0e6b51ca8d1a644ff0 [INFO] running `Command { std: "docker" "start" "-a" "9f9d63d67eca70ff9f23629212a7c59f822e42c095714b0e6b51ca8d1a644ff0", kill_on_drop: false }` [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling caseless v0.2.1 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking unicode-xid v0.1.0 [INFO] [stderr] Checking backtrace v0.3.73 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking crossbeam v0.2.12 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking Inflector v0.11.4 [INFO] [stderr] Compiling lazy_static v1.5.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking error-chain v0.12.4 [INFO] [stderr] Checking slog-scope v4.4.0 [INFO] [stderr] Checking slog-stdlog v3.0.5 [INFO] [stderr] Checking preftool v0.2.0 [INFO] [stderr] Checking preftool-clap v0.2.0 [INFO] [stderr] Checking preftool-clap-derive v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | Unnamed(usize), [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 14 | Unnamed(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 35 | let ty = data.ty.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(ClapField { [INFO] [stdout] | ________^ [INFO] [stdout] 75 | | name, [INFO] [stdout] 76 | | long, [INFO] [stdout] 77 | | help, [INFO] [stdout] 78 | | ty, [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:8 [INFO] [stdout] | [INFO] [stdout] 139 | let fields = ClapField::parse_fields(&item.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | Ok(ClapStruct { name, fields }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 146 | let fields = ClapField::parse_fields(&variant.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | [INFO] [stdout] 148 | Ok(ClapStruct { name, fields }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 159 | let mut variants = Vec::with_capacity(item.variants.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(ClapEnum { variants }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:26 [INFO] [stdout] | [INFO] [stdout] 175 | fn from(s: ClapStruct) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | ClapItemData::Struct(Rc::new(s)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 181 | fn from(e: ClapEnum) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | ClapItemData::Enum(Rc::new(e)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 194 | let input = DeriveInput::parse(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let data = match &input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let generics = input.generics; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let ident = input.ident; [INFO] [stdout] 203 | Ok(ClapItem { [INFO] [stdout] | ________^ [INFO] [stdout] 204 | | data, [INFO] [stdout] 205 | | generics, [INFO] [stdout] 206 | | ident, [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `preftool-clap-derive` (lib test) due to 8 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/lib.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | Unnamed(usize), [INFO] [stdout] | ------- ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 14 | Unnamed(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 35 | let ty = data.ty.clone(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(ClapField { [INFO] [stdout] | ________^ [INFO] [stdout] 75 | | name, [INFO] [stdout] 76 | | long, [INFO] [stdout] 77 | | help, [INFO] [stdout] 78 | | ty, [INFO] [stdout] 79 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:141:8 [INFO] [stdout] | [INFO] [stdout] 139 | let fields = ClapField::parse_fields(&item.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 140 | [INFO] [stdout] 141 | Ok(ClapStruct { name, fields }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:148:8 [INFO] [stdout] | [INFO] [stdout] 146 | let fields = ClapField::parse_fields(&variant.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | [INFO] [stdout] 148 | Ok(ClapStruct { name, fields }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 159 | let mut variants = Vec::with_capacity(item.variants.len()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(ClapEnum { variants }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:176:26 [INFO] [stdout] | [INFO] [stdout] 175 | fn from(s: ClapStruct) -> Self { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | ClapItemData::Struct(Rc::new(s)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:182:24 [INFO] [stdout] | [INFO] [stdout] 181 | fn from(e: ClapEnum) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 182 | ClapItemData::Enum(Rc::new(e)) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:203:8 [INFO] [stdout] | [INFO] [stdout] 194 | let input = DeriveInput::parse(input)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | let data = match &input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let generics = input.generics; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let ident = input.ident; [INFO] [stdout] 203 | Ok(ClapItem { [INFO] [stdout] | ________^ [INFO] [stdout] 204 | | data, [INFO] [stdout] 205 | | generics, [INFO] [stdout] 206 | | ident, [INFO] [stdout] 207 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `preftool-clap-derive` (lib) due to 8 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "9f9d63d67eca70ff9f23629212a7c59f822e42c095714b0e6b51ca8d1a644ff0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f9d63d67eca70ff9f23629212a7c59f822e42c095714b0e6b51ca8d1a644ff0", kill_on_drop: false }` [INFO] [stdout] 9f9d63d67eca70ff9f23629212a7c59f822e42c095714b0e6b51ca8d1a644ff0