[INFO] fetching crate prefixed-api-key 0.3.0... [INFO] checking prefixed-api-key-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prefixed-api-key 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate prefixed-api-key 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prefixed-api-key 0.3.0 [INFO] finished tweaking crates.io crate prefixed-api-key 0.3.0 [INFO] tweaked toml for crates.io crate prefixed-api-key 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 27 packages to latest compatible versions [INFO] [stderr] Adding bs58 v0.4.0 (latest: v0.5.1) [INFO] [stderr] Adding constant_time_eq v0.2.6 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 435f6f87ece9a881ed528a3de31eaf0442714d25b8cf071530143976910acc18 [INFO] running `Command { std: "docker" "start" "-a" "435f6f87ece9a881ed528a3de31eaf0442714d25b8cf071530143976910acc18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "435f6f87ece9a881ed528a3de31eaf0442714d25b8cf071530143976910acc18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "435f6f87ece9a881ed528a3de31eaf0442714d25b8cf071530143976910acc18", kill_on_drop: false }` [INFO] [stdout] 435f6f87ece9a881ed528a3de31eaf0442714d25b8cf071530143976910acc18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e51daa9a91c334db8eb560f297f7c0df820a208a1ca4fbef4d3203fbf763a6cd [INFO] running `Command { std: "docker" "start" "-a" "e51daa9a91c334db8eb560f297f7c0df820a208a1ca4fbef4d3203fbf763a6cd", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking hex v0.4.3 [INFO] [stderr] Checking bs58 v0.4.0 [INFO] [stderr] Checking constant_time_eq v0.2.6 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking prefixed-api-key v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::PrefixedApiKeyController` [INFO] [stdout] --> src/controller_alias.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::PrefixedApiKeyController; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `OsRng`, `StdRng`, and `ThreadRng` [INFO] [stdout] --> src/controller_alias.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use rand::rngs::{OsRng, StdRng, ThreadRng}; [INFO] [stdout] | ^^^^^ ^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `controller_alias::*` [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use controller_alias::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::PrefixedApiKeyController` [INFO] [stdout] --> src/controller_alias.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use crate::PrefixedApiKeyController; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `OsRng`, `StdRng`, and `ThreadRng` [INFO] [stdout] --> src/controller_alias.rs:3:18 [INFO] [stdout] | [INFO] [stdout] 3 | use rand::rngs::{OsRng, StdRng, ThreadRng}; [INFO] [stdout] | ^^^^^ ^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `controller_alias::*` [INFO] [stdout] --> src/lib.rs:13:9 [INFO] [stdout] | [INFO] [stdout] 13 | pub use controller_alias::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller_builder.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn finalize(self) -> Result, BuilderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(PrefixedApiKeyController::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | self.prefix.unwrap(), [INFO] [stdout] 83 | | self.rng.unwrap(), [INFO] [stdout] 84 | | self.short_token_prefix, [INFO] [stdout] 85 | | self.short_token_length.unwrap(), [INFO] [stdout] 86 | | self.long_token_length.unwrap(), [INFO] [stdout] 87 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller_builder.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn default_lengths(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | self.short_token_length(8).long_token_length(24) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 57 | let mut rng = self.rng.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | match rng.try_fill_bytes(&mut random_bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prefixed-api-key` (lib) due to 4 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller_builder.rs:81:12 [INFO] [stdout] | [INFO] [stdout] 64 | pub fn finalize(self) -> Result, BuilderError> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | Ok(PrefixedApiKeyController::new( [INFO] [stdout] | ____________^ [INFO] [stdout] 82 | | self.prefix.unwrap(), [INFO] [stdout] 83 | | self.rng.unwrap(), [INFO] [stdout] 84 | | self.short_token_prefix, [INFO] [stdout] 85 | | self.short_token_length.unwrap(), [INFO] [stdout] 86 | | self.long_token_length.unwrap(), [INFO] [stdout] 87 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller_builder.rs:93:9 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn default_lengths(self) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | self.short_token_length(8).long_token_length(24) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/controller.rs:58:15 [INFO] [stdout] | [INFO] [stdout] 57 | let mut rng = self.rng.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 58 | match rng.try_fill_bytes(&mut random_bytes) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prefixed-api-key` (lib test) due to 4 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e51daa9a91c334db8eb560f297f7c0df820a208a1ca4fbef4d3203fbf763a6cd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e51daa9a91c334db8eb560f297f7c0df820a208a1ca4fbef4d3203fbf763a6cd", kill_on_drop: false }` [INFO] [stdout] e51daa9a91c334db8eb560f297f7c0df820a208a1ca4fbef4d3203fbf763a6cd