[INFO] fetching crate prec 1.1.0... [INFO] checking prec-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate prec 1.1.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate prec 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate prec 1.1.0 [INFO] finished tweaking crates.io crate prec 1.1.0 [INFO] tweaked toml for crates.io crate prec 1.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate prec 1.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 57d8a8a6581eb8c82a983f3b5b87669cf275f36bd5d1639bb8f8f9f45cba159c [INFO] running `Command { std: "docker" "start" "-a" "57d8a8a6581eb8c82a983f3b5b87669cf275f36bd5d1639bb8f8f9f45cba159c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "57d8a8a6581eb8c82a983f3b5b87669cf275f36bd5d1639bb8f8f9f45cba159c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57d8a8a6581eb8c82a983f3b5b87669cf275f36bd5d1639bb8f8f9f45cba159c", kill_on_drop: false }` [INFO] [stdout] 57d8a8a6581eb8c82a983f3b5b87669cf275f36bd5d1639bb8f8f9f45cba159c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3bb557abf096167ea8847f7263973e1858be1d226d3e5385ef274e65c91f9580 [INFO] running `Command { std: "docker" "start" "-a" "3bb557abf096167ea8847f7263973e1858be1d226d3e5385ef274e65c91f9580", kill_on_drop: false }` [INFO] [stderr] Checking prec v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:3 [INFO] [stdout] | [INFO] [stdout] 156 | let mut primary = expr.first_token.clone().convert(ctx)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let lhs = expr.first_token.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let mut tokens = expr.pairs.iter().peekable(); [INFO] [stdout] 159 | / self [INFO] [stdout] 160 | | .process_rec( [INFO] [stdout] 161 | | lhs, // [INFO] [stdout] 162 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 165 | | ctx, [INFO] [stdout] 166 | | )? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:10 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn new(op: Op, assoc: Assoc) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | next: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prec` (lib) due to 3 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `Paren` is never constructed [INFO] [stdout] --> src/lib.rs:336:3 [INFO] [stdout] | [INFO] [stdout] 335 | pub enum MathToken { [INFO] [stdout] | --------- variant in this enum [INFO] [stdout] 336 | Paren(Box>), [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MathToken` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:3 [INFO] [stdout] | [INFO] [stdout] 156 | let mut primary = expr.first_token.clone().convert(ctx)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 157 | let lhs = expr.first_token.clone(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | let mut tokens = expr.pairs.iter().peekable(); [INFO] [stdout] 159 | / self [INFO] [stdout] 160 | | .process_rec( [INFO] [stdout] 161 | | lhs, // [INFO] [stdout] 162 | | 0, [INFO] [stdout] ... | [INFO] [stdout] 165 | | ctx, [INFO] [stdout] 166 | | )? [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |______________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:229:10 [INFO] [stdout] | [INFO] [stdout] 225 | pub fn new(op: Op, assoc: Assoc) -> Self { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | next: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:315:8 [INFO] [stdout] | [INFO] [stdout] 312 | |lhs: MathToken, op: MathOperator, rhs: MathToken, ctx: &f32| { [INFO] [stdout] | -------------- -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 315 | Ok(match op { [INFO] [stdout] | ____________________^ [INFO] [stdout] 316 | | MathOperator::Add => MathToken::Num(lhs + rhs), [INFO] [stdout] 317 | | MathOperator::Sub => MathToken::Num(lhs - rhs), [INFO] [stdout] 318 | | MathOperator::Mul => MathToken::Num(lhs * rhs), [INFO] [stdout] 319 | | MathOperator::Div => MathToken::Num(lhs / rhs), [INFO] [stdout] 320 | | }) [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `prec` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3bb557abf096167ea8847f7263973e1858be1d226d3e5385ef274e65c91f9580", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3bb557abf096167ea8847f7263973e1858be1d226d3e5385ef274e65c91f9580", kill_on_drop: false }` [INFO] [stdout] 3bb557abf096167ea8847f7263973e1858be1d226d3e5385ef274e65c91f9580