[INFO] fetching crate pre-rfc3243-libtw2-demo 0.1.0... [INFO] checking pre-rfc3243-libtw2-demo-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pre-rfc3243-libtw2-demo 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate pre-rfc3243-libtw2-demo 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pre-rfc3243-libtw2-demo 0.1.0 [INFO] finished tweaking crates.io crate pre-rfc3243-libtw2-demo 0.1.0 [INFO] tweaked toml for crates.io crate pre-rfc3243-libtw2-demo 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding arrayvec v0.5.2 (latest: v0.7.6) [INFO] [stderr] Adding binrw v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding binrw_derive v0.11.2 (latest: v0.14.0) [INFO] [stderr] Adding itertools v0.4.19 (latest: v0.13.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding mac v0.0.2 (latest: v0.1.1) [INFO] [stderr] Adding owo-colors v3.5.0 (latest: v4.0.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding uuid v0.8.2 (latest: v1.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 26f10f67f3886a0b23fbe08f9a50e0fe6e3f128d3616231b2aa1ea44803663d1 [INFO] running `Command { std: "docker" "start" "-a" "26f10f67f3886a0b23fbe08f9a50e0fe6e3f128d3616231b2aa1ea44803663d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "26f10f67f3886a0b23fbe08f9a50e0fe6e3f128d3616231b2aa1ea44803663d1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26f10f67f3886a0b23fbe08f9a50e0fe6e3f128d3616231b2aa1ea44803663d1", kill_on_drop: false }` [INFO] [stdout] 26f10f67f3886a0b23fbe08f9a50e0fe6e3f128d3616231b2aa1ea44803663d1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dbfa05bbe0bcb298da90f8cc798e4b75b4903fbbe255fddb3e7469d1e3ea3fa1 [INFO] running `Command { std: "docker" "start" "-a" "dbfa05bbe0bcb298da90f8cc798e4b75b4903fbbe255fddb3e7469d1e3ea3fa1", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking mac v0.0.2 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking uuid v0.8.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling binrw_derive v0.11.2 [INFO] [stderr] Compiling binrw v0.11.2 [INFO] [stderr] Checking warn v0.2.2 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Compiling owo-colors v3.5.0 [INFO] [stderr] Checking array-init v2.1.0 [INFO] [stderr] Checking bytemuck v1.17.1 [INFO] [stderr] Checking itertools v0.4.19 [INFO] [stderr] Checking buffer v0.1.9 [INFO] [stderr] Checking pre-rfc3243-libtw2-common v0.1.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking pre-rfc3243-libtw2-packer v0.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-huffman v0.1.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pre-rfc3243-libtw2-gamenet-common v0.1.1 [INFO] [stderr] Checking pre-rfc3243-libtw2-gamenet-snap v0.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-snapshot v0.1.0 [INFO] [stderr] Checking pre-rfc3243-libtw2-demo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ddnet/reader.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(data: R, warn: &mut W) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let reader = reader::Reader::new(data, wrap(warn))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | Ok(DemoReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | raw: reader, [INFO] [stdout] 96 | | delta: Delta::new(), [INFO] [stdout] 97 | | snap: Snap::empty(), [INFO] [stdout] ... | [INFO] [stdout] 101 | | protocol: PhantomData, [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ddnet/writer.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 99 | file: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let raw = crate::Writer::new( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | inner: raw, [INFO] [stdout] 123 | | last_tick: -1, [INFO] [stdout] 124 | | last_keyframe: None, [INFO] [stdout] ... | [INFO] [stdout] 131 | | protocol: PhantomData, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(mut data: R, warn: &mut W) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | data: Box::new(data), [INFO] [stdout] 67 | | start: start, [INFO] [stdout] 68 | | current_tick: None, [INFO] [stdout] 69 | | raw: [0; MAX_SNAPSHOT_SIZE], [INFO] [stdout] 70 | | huffman: ArrayVec::new(), [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ddnet/reader.rs:94:12 [INFO] [stdout] | [INFO] [stdout] 88 | pub fn new(data: R, warn: &mut W) -> Result [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | let reader = reader::Reader::new(data, wrap(warn))?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 94 | Ok(DemoReader { [INFO] [stdout] | ____________^ [INFO] [stdout] 95 | | raw: reader, [INFO] [stdout] 96 | | delta: Delta::new(), [INFO] [stdout] 97 | | snap: Snap::empty(), [INFO] [stdout] ... | [INFO] [stdout] 101 | | protocol: PhantomData, [INFO] [stdout] 102 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ddnet/writer.rs:121:12 [INFO] [stdout] | [INFO] [stdout] 99 | file: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 109 | let raw = crate::Writer::new( [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 122 | | inner: raw, [INFO] [stdout] 123 | | last_tick: -1, [INFO] [stdout] 124 | | last_keyframe: None, [INFO] [stdout] ... | [INFO] [stdout] 131 | | protocol: PhantomData, [INFO] [stdout] 132 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:65:12 [INFO] [stdout] | [INFO] [stdout] 57 | pub fn new(mut data: R, warn: &mut W) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 66 | | data: Box::new(data), [INFO] [stdout] 67 | | start: start, [INFO] [stdout] 68 | | current_tick: None, [INFO] [stdout] 69 | | raw: [0; MAX_SNAPSHOT_SIZE], [INFO] [stdout] 70 | | huffman: ArrayVec::new(), [INFO] [stdout] 71 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pre-rfc3243-libtw2-demo` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pre-rfc3243-libtw2-demo` (lib test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "dbfa05bbe0bcb298da90f8cc798e4b75b4903fbbe255fddb3e7469d1e3ea3fa1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dbfa05bbe0bcb298da90f8cc798e4b75b4903fbbe255fddb3e7469d1e3ea3fa1", kill_on_drop: false }` [INFO] [stdout] dbfa05bbe0bcb298da90f8cc798e4b75b4903fbbe255fddb3e7469d1e3ea3fa1