[INFO] fetching crate pratt-gen-macros 0.1.0... [INFO] checking pratt-gen-macros-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate pratt-gen-macros 0.1.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate pratt-gen-macros 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate pratt-gen-macros 0.1.0 [INFO] finished tweaking crates.io crate pratt-gen-macros 0.1.0 [INFO] tweaked toml for crates.io crate pratt-gen-macros 0.1.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f338004fa0755c2f1ee914209885f8c2431b2add084934b0a9c2fc3713d40087 [INFO] running `Command { std: "docker" "start" "-a" "f338004fa0755c2f1ee914209885f8c2431b2add084934b0a9c2fc3713d40087", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f338004fa0755c2f1ee914209885f8c2431b2add084934b0a9c2fc3713d40087", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f338004fa0755c2f1ee914209885f8c2431b2add084934b0a9c2fc3713d40087", kill_on_drop: false }` [INFO] [stdout] f338004fa0755c2f1ee914209885f8c2431b2add084934b0a9c2fc3713d40087 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b5125ffab72d6450ad2af71cd627b95e338ba757a7a0de9ba15ee930335bad3b [INFO] running `Command { std: "docker" "start" "-a" "b5125ffab72d6450ad2af71cd627b95e338ba757a7a0de9ba15ee930335bad3b", kill_on_drop: false }` [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Compiling logos-codegen v0.14.1 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking syn v2.0.77 [INFO] [stderr] Compiling logos-derive v0.14.1 [INFO] [stderr] Checking logos v0.14.1 [INFO] [stderr] Checking pratt-gen-macros v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn parser_impl_derive(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | match impl_parser(input.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 25 | fn impl_parser(input: TokenStream) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | // Parse the input tokens into a syntax tree [INFO] [stdout] 27 | let ast = syn::parse2::(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | // Only allow enum [INFO] [stdout] 29 | let Data::Enum(data) = ast.data else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut arm_names = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut arm_impls = TokenStream::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let body = impl_parser_body(arm_names); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | // Implement ParserImpl for enum [INFO] [stdout] 48 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 49 | | impl<'a> ParserImpl<'a> for #name<'a> { [INFO] [stdout] 50 | | fn parser_impl( [INFO] [stdout] 51 | | source: Source<'a>, [INFO] [stdout] ... | [INFO] [stdout] 59 | | #arm_impls [INFO] [stdout] 60 | | }.into()) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn impl_parser_variant(name: &syn::Ident, var: syn::Variant) -> Result<(Ident, TokenStream)> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let func = prepare_func_name(&var); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let (attr, precedence) = prepare_attribute(&var)?; [INFO] [stdout] 11 | let body = prepare_func_body(&var, &attr, precedence)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok((func.clone(), quote::quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 13 | | impl<'a> #name<'a> { [INFO] [stdout] 14 | | #[inline(always)] [INFO] [stdout] 15 | | fn #func( [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }.into())) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:148:79 [INFO] [stdout] | [INFO] [stdout] 148 | let fields = named.iter().map(|x| (x.ident.as_ref().unwrap().to_string(), x.ty.clone())).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pratt-gen-macros` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:19:11 [INFO] [stdout] | [INFO] [stdout] 18 | pub fn parser_impl_derive(input: proc_macro::TokenStream) -> proc_macro::TokenStream { [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 19 | match impl_parser(input.into()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 25 | fn impl_parser(input: TokenStream) -> Result { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | // Parse the input tokens into a syntax tree [INFO] [stdout] 27 | let ast = syn::parse2::(input).unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 28 | // Only allow enum [INFO] [stdout] 29 | let Data::Enum(data) = ast.data else { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let mut arm_names = Vec::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | let mut arm_impls = TokenStream::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 46 | let body = impl_parser_body(arm_names); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 47 | // Implement ParserImpl for enum [INFO] [stdout] 48 | Ok(quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 49 | | impl<'a> ParserImpl<'a> for #name<'a> { [INFO] [stdout] 50 | | fn parser_impl( [INFO] [stdout] 51 | | source: Source<'a>, [INFO] [stdout] ... | [INFO] [stdout] 59 | | #arm_impls [INFO] [stdout] 60 | | }.into()) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:12:8 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn impl_parser_variant(name: &syn::Ident, var: syn::Variant) -> Result<(Ident, TokenStream)> { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 9 | let func = prepare_func_name(&var); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 10 | let (attr, precedence) = prepare_attribute(&var)?; [INFO] [stdout] 11 | let body = prepare_func_body(&var, &attr, precedence)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | Ok((func.clone(), quote::quote! { [INFO] [stdout] | ________^ [INFO] [stdout] 13 | | impl<'a> #name<'a> { [INFO] [stdout] 14 | | #[inline(always)] [INFO] [stdout] 15 | | fn #func( [INFO] [stdout] ... | [INFO] [stdout] 24 | | } [INFO] [stdout] 25 | | }.into())) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/variant.rs:148:79 [INFO] [stdout] | [INFO] [stdout] 148 | let fields = named.iter().map(|x| (x.ident.as_ref().unwrap().to_string(), x.ty.clone())).collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `pratt-gen-macros` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b5125ffab72d6450ad2af71cd627b95e338ba757a7a0de9ba15ee930335bad3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b5125ffab72d6450ad2af71cd627b95e338ba757a7a0de9ba15ee930335bad3b", kill_on_drop: false }` [INFO] [stdout] b5125ffab72d6450ad2af71cd627b95e338ba757a7a0de9ba15ee930335bad3b